Syntax highlighting in module not working until module is declared

[Geobert]

While working on #1730

I noticed highlight does not fully work on this code:

use hir::db::HirDatabase;
use ra_syntax::{
    ast,
    ast::{AstNode, AstToken, Literal},
    TextUnit,
};

use crate::{Assist, AssistCtx, AssistId};

pub(crate) fn make_raw_string(mut ctx: AssistCtx<impl HirDatabase>) -> Option<Assist> {
    let string = ctx.node_at_offset::<Literal>()?;
    None // I put that just to be sure that mismatch type was not causing the issue
}

Type and enum variant are not coloured.

[Geobert]

It began to be highlighted once the file has been included in lib.rs

[ice1000]

It began to be highlighted once the file has been included in lib.rs

Therefore I'd say it's the expected behavior.

[matklad]

I think it makes sense to be more resilient about handing modules like this...

[Geobert]

Therefore I'd say it's the expected behavior.

I understand what you're saying, but from a UX point of view, I don't think it's pleasant. IMO, this falls in error tolerance category

[ice1000]

Ok

[jonas-schievink]

This is now diagnosed with a quick fix to add the right mod declaration, so closing.