Skip to content

Ship static binaries #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wucke13 opened this issue May 24, 2020 · 5 comments
Closed

Ship static binaries #4589

wucke13 opened this issue May 24, 2020 · 5 comments

Comments

@wucke13
Copy link

wucke13 commented May 24, 2020

I would like to use rust-analyzer. However, most ways of obtaining it require one to use a downloaded version, which I guess is build against x86_64-unknown-linux-gnu. This hurts the portability as these binaries will not work on distros like Alpine Linux or NixOS (at least without further ).

I would appreciate if the binaries will be build against the x86_64-unknown-linux-musl target in the future in order to achieve maximum compatibility. IMHO it is always wrong to ship a dynamic linked binary if static linkage is an easy option but if one exactly knows the target system (which is not the case if one binary is provided for the whole linux world).

Other than that, thank you all for the great work!

PS: For me rust-analyzer compiles against x86_64-unknown-linux-musl just fine, so this shouldn't be fairly quick fix.

@flodiebold
Copy link
Member

Duplicate of #4354; see there and in the linked PR for why this is not possible currently.

@lnicola
Copy link
Member

lnicola commented May 24, 2020

NixOS should actually work fine after #4555.

@wucke13
Copy link
Author

wucke13 commented May 24, 2020

Woosh, that was fast. Thanks! Though #4555 is only about VSCode, right? What about coc-rust-analyzer?

@lnicola
Copy link
Member

lnicola commented May 24, 2020

coc-rust-analyzer is a fork of the Code extension, so @fannheyward might include the same changes. But indeed, it won't work today,

@fannheyward by the way, it's not very clear to me how the two extensions differ and whether it's likely for them to diverge even more or converge back.

@fannheyward
Copy link
Contributor

coc-rust-analyzer adds this patch, fannheyward/coc-rust-analyzer@29d4811, releases with 0.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants