Add suspicious group

Author: camsteffen

README.md

@@ -17,6 +17,7 @@ You can choose how much Clippy is supposed to ~~annoy~~ help you by changing the
 | `clippy::style`       | code that should be written in a more idiomatic way                     | **warn**      |
 | `clippy::complexity`  | code that does something simple but in a complex way                    | **warn**      |
 | `clippy::perf`        | code that can be written to run faster                                  | **warn**      |
+| `clippy::suspicious`  | code that seems very likely to be incorrect                             | **warn**      |
 | `clippy::pedantic`    | lints which are rather strict or might have false positives             | allow         |
 | `clippy::nursery`     | new lints that are still under development                              | allow         |
 | `clippy::cargo`       | lints for the cargo manifest                                            | allow         |

clippy_dev/src/main.rs

@@ -125,6 +125,7 @@ fn get_clap_config<'a>() -> ArgMatches<'a> {
                             "correctness",
                             "complexity",
                             "perf",
+                            "suspicious",
                             "pedantic",
                             "restriction",
                             "cargo",

clippy_dev/src/update_lints.rs

@@ -92,7 +92,10 @@ pub fn run(update_mode: UpdateMode) {
         || {
             // clippy::all should only include the following lint groups:
             let all_group_lints = usable_lints.iter().filter(|l| {
-                l.group == "correctness" || l.group == "style" || l.group == "complexity" || l.group == "perf"
+                matches!(
+                    &*l.group,
+                    "correctness" | "style" | "complexity" | "perf" | "suspicious"
+                )
             });
 
             gen_lint_group_list(all_group_lints)

clippy_lints/src/lib.rs

@@ -60,9 +60,9 @@ use rustc_session::Session;
 /// 4. The `description` that contains a short explanation on what's wrong with code where the
 ///    lint is triggered.
 ///
-/// Currently the categories `style`, `correctness`, `complexity` and `perf` are enabled by default.
-/// As said in the README.md of this repository, if the lint level mapping changes, please update
-/// README.md.
+/// Currently the categories `style`, `correctness`, `complexity`, `perf` and `suspicious` are
+/// enabled by default. As said in the README.md of this repository, if the lint level mapping
+/// changes, please update README.md.
 ///
 /// # Example
 ///
@@ -116,6 +116,11 @@ macro_rules! declare_clippy_lint {
             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
         }
     };
+    { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
+        declare_tool_lint! {
+            $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
+        }
+    };
     { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
         declare_tool_lint! {
             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true

clippy_lints/src/utils/internal_lints/metadata_collector.rs

@@ -46,13 +46,14 @@ const DEPRECATED_LINT_GROUP_STR: &str = "deprecated";
 const DEPRECATED_LINT_LEVEL: &str = "none";
 /// This array holds Clippy's lint groups with their corresponding default lint level. The
 /// lint level for deprecated lints is set in `DEPRECATED_LINT_LEVEL`.
-const DEFAULT_LINT_LEVELS: [(&str, &str); 8] = [
+const DEFAULT_LINT_LEVELS: &[(&str, &str)] = &[
     ("correctness", "deny"),
     ("restriction", "allow"),
     ("style", "warn"),
     ("pedantic", "allow"),
     ("complexity", "warn"),
     ("perf", "warn"),
+    ("suspicious", "warn"),
     ("cargo", "allow"),
     ("nursery", "allow"),
 ];

util/lintlib.py

@@ -22,6 +22,7 @@
     "style": 'Warn',
     "complexity": 'Warn',
     "perf": 'Warn',
+    "suspicious": 'Warn',
     "restriction": 'Allow',
     "pedantic": 'Allow',
     "nursery": 'Allow',