Skip to content

Commit 3d0f73e

Browse files
committed
address comments
1 parent d8e6c33 commit 3d0f73e

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ termize = "0.1"
3131
compiletest_rs = { version = "0.8", features = ["tmp"] }
3232
tester = "0.9"
3333
regex = "1.5"
34+
toml = "0.5"
3435
# This is used by the `collect-metadata` alias.
3536
filetime = "0.2"
3637

@@ -52,7 +53,6 @@ futures = "0.3"
5253
parking_lot = "0.12"
5354
tokio = { version = "1", features = ["io-util"] }
5455
rustc-semver = "1.1"
55-
toml = "0.5"
5656

5757
[build-dependencies]
5858
rustc_tools_util = { version = "0.2", path = "rustc_tools_util" }

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ Alternatively, the [`rust-version` field](https://doc.rust-lang.org/cargo/refere
218218
in the `Cargo.toml` can be used.
219219

220220
```toml
221+
# Cargo.toml
221222
rust-version = "1.30"
222223
```
223224

clippy_lints/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,7 +470,7 @@ fn read_msrv(conf: &Conf, sess: &Session) -> Option<RustcVersion> {
470470
// if both files have an msrv, let's compare them and emit a warning if they differ
471471
if clippy_msrv != cargo_msrv {
472472
sess.warn(&format!(
473-
"the MSRV in `clippy.toml` and `Cargo.toml` differ; using `{}`",
473+
"the MSRV in `clippy.toml` and `Cargo.toml` differ; using `{}` from `clippy.toml`",
474474
clippy_msrv
475475
));
476476
}

tests/ui-cargo/cargo_rust_version/fail_file_attr/src/main.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// FIXME: this should produce a warning, because the attribute says 1.58 and the cargo.toml file
2+
// says 1.13
3+
14
#![feature(custom_inner_attributes)]
25
#![clippy::msrv = "1.58.0"]
36
#![deny(clippy::use_self)]

0 commit comments

Comments
 (0)