Merge pull request #1131 from JDemler/master

Manishearth · web-flow · commit 514f77be12f9 · 2016-08-03T09:29:49.000+05:30
No warning when file is opened with read truncate and write
diff --git a/clippy_lints/src/open_options.rs b/clippy_lints/src/open_options.rs
@@ -178,7 +178,7 @@ fn check_open_options(cx: &LateContext, options: &[(OpenOption, Argument)], span
         }
     }
 
-    if read && truncate && read_arg && truncate_arg {
+    if read && truncate && read_arg && truncate_arg && !(write && write_arg) {
         span_lint(cx, NONSENSICAL_OPEN_OPTIONS, span, "file opened with \"truncate\" and \"read\"");
     }
     if append && truncate && append_arg && truncate_arg {

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ fn check_open_options(cx: &LateContext, options: &[(OpenOption, Argument)], span`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`
`181`		`- if read && truncate && read_arg && truncate_arg {`
	`181`	`+ if read && truncate && read_arg && truncate_arg && !(write && write_arg) {`
`182`	`182`	`span_lint(cx, NONSENSICAL_OPEN_OPTIONS, span, "file opened with \"truncate\" and \"read\"");`
`183`	`183`	`}`
`184`	`184`	`if append && truncate && append_arg && truncate_arg {`