fix pr comments

Author: yonip23

CHANGELOG.md

@@ -3278,7 +3278,7 @@ Released 2018-09-13
 [`allow_attributes_without_reason`]: https://rust-lang.github.io/rust-clippy/master/index.html#allow_attributes_without_reason
 [`almost_swapped`]: https://rust-lang.github.io/rust-clippy/master/index.html#almost_swapped
 [`approx_constant`]: https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
-[`arc_new_in_vec_from_slice`]: https://rust-lang.github.io/rust-clippy/master/index.html#arc_new_in_vec_from_slice
+[`arc_new_in_vec_from_elem`]: https://rust-lang.github.io/rust-clippy/master/index.html#arc_new_in_vec_from_elem
 [`as_conversions`]: https://rust-lang.github.io/rust-clippy/master/index.html#as_conversions
 [`assertions_on_constants`]: https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants
 [`assign_op_pattern`]: https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

clippy_lints/src/arc_new_in_vec_from_slice.rs renamed to clippy_lints/src/arc_new_in_vec_from_elem.rs

@@ -26,21 +26,18 @@ declare_clippy_lint! {
     /// let v = vec![data; 100];
     /// ```
     #[clippy::version = "1.62.0"]
-    pub ARC_NEW_IN_VEC_FROM_SLICE,
+    pub ARC_NEW_IN_VEC_FROM_ELEM,
     suspicious,
     "calling `Arc::new` in `vec![elem; len]`"
 }
-declare_lint_pass!(ArcNewInVecFromSlice => [ARC_NEW_IN_VEC_FROM_SLICE]);
+declare_lint_pass!(ArcNewInVecFromSlice => [ARC_NEW_IN_VEC_FROM_ELEM]);
 
 impl LateLintPass<'_> for ArcNewInVecFromSlice {
     fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
         let Some(macro_call) = root_macro_call_first_node(cx, expr) else { return; };
-        if !macro_is_vec(cx, &macro_call) {
-            return;
-        }
 
         if let Some(VecArgs::Repeat(elem, _)) = VecArgs::hir(cx, expr) {
-            if !is_arc_new(elem) {
+            if !is_arc_new(cx, elem) {
                 return;
             }
 
@@ -52,25 +49,22 @@ impl LateLintPass<'_> for ArcNewInVecFromSlice {
 fn yield_lint(cx: &LateContext<'_>, macro_call: &MacroCall) {
     span_lint_and_help(
         cx,
-        ARC_NEW_IN_VEC_FROM_SLICE,
+        ARC_NEW_IN_VEC_FROM_ELEM,
         macro_call.span,
         "calling `Arc::new` in `vec![elem; len]`",
         None,
         "consider extracting `Arc` initialization to a variable",
     );
 }
 
-fn macro_is_vec(cx: &LateContext<'_>, macro_call: &MacroCall) -> bool {
-    cx.tcx.is_diagnostic_item(sym::vec_macro, macro_call.def_id)
-}
-
 /// Checks whether the given `expr` is a call to `Arc::new`
-fn is_arc_new(expr: &Expr<'_>) -> bool {
+fn is_arc_new(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
     if_chain! {
         if let ExprKind::Call(func, _args) = expr.kind;
-        if let ExprKind::Path(ref func_path) = func.kind;
-        if let ExprKind::Path(QPath::TypeRelative(ty, _)) =  func.kind;
+        if let ExprKind::Path(ref func_path @ QPath::TypeRelative(ty, _)) = func.kind;
         if let TyKind::Path(ref ty_path) = ty.kind;
+        if let Some(def_id) = cx.qpath_res(ty_path, ty.hir_id).opt_def_id();
+        if cx.tcx.is_diagnostic_item(sym::Arc, def_id);
 
         then {
             let ty_segment = last_path_segment(ty_path);

clippy_lints/src/lib.register_all.rs

@@ -5,7 +5,7 @@
 store.register_group(true, "clippy::all", Some("clippy_all"), vec![
     LintId::of(absurd_extreme_comparisons::ABSURD_EXTREME_COMPARISONS),
     LintId::of(approx_const::APPROX_CONSTANT),
-    LintId::of(arc_new_in_vec_from_slice::ARC_NEW_IN_VEC_FROM_SLICE),
+    LintId::of(arc_new_in_vec_from_elem::ARC_NEW_IN_VEC_FROM_ELEM),
     LintId::of(assertions_on_constants::ASSERTIONS_ON_CONSTANTS),
     LintId::of(assign_ops::ASSIGN_OP_PATTERN),
     LintId::of(assign_ops::MISREFACTORED_ASSIGN_OP),

clippy_lints/src/lib.register_lints.rs

@@ -35,7 +35,7 @@ store.register_lints(&[
     utils::internal_lints::UNNECESSARY_SYMBOL_STR,
     absurd_extreme_comparisons::ABSURD_EXTREME_COMPARISONS,
     approx_const::APPROX_CONSTANT,
-    arc_new_in_vec_from_slice::ARC_NEW_IN_VEC_FROM_SLICE,
+    arc_new_in_vec_from_elem::ARC_NEW_IN_VEC_FROM_ELEM,
     arithmetic::FLOAT_ARITHMETIC,
     arithmetic::INTEGER_ARITHMETIC,
     as_conversions::AS_CONVERSIONS,

clippy_lints/src/lib.register_suspicious.rs

@@ -3,7 +3,7 @@
 // Manual edits will be overwritten.
 
 store.register_group(true, "clippy::suspicious", Some("clippy_suspicious"), vec![
-    LintId::of(arc_new_in_vec_from_slice::ARC_NEW_IN_VEC_FROM_SLICE),
+    LintId::of(arc_new_in_vec_from_elem::ARC_NEW_IN_VEC_FROM_ELEM),
     LintId::of(assign_ops::MISREFACTORED_ASSIGN_OP),
     LintId::of(attrs::BLANKET_CLIPPY_RESTRICTION_LINTS),
     LintId::of(await_holding_invalid::AWAIT_HOLDING_INVALID_TYPE),

clippy_lints/src/lib.rs

@@ -166,7 +166,7 @@ mod utils;
 // begin lints modules, do not remove this comment, it’s used in `update_lints`
 mod absurd_extreme_comparisons;
 mod approx_const;
-mod arc_new_in_vec_from_slice;
+mod arc_new_in_vec_from_elem;
 mod arithmetic;
 mod as_conversions;
 mod asm_syntax;
@@ -888,7 +888,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
     store.register_late_pass(|| Box::new(bytes_count_to_len::BytesCountToLen));
     let max_include_file_size = conf.max_include_file_size;
     store.register_late_pass(move || Box::new(large_include_file::LargeIncludeFile::new(max_include_file_size)));
-    store.register_late_pass(|| Box::new(arc_new_in_vec_from_slice::ArcNewInVecFromSlice));
+    store.register_late_pass(|| Box::new(arc_new_in_vec_from_elem::ArcNewInVecFromSlice));
     // add lints here, do not remove this comment, it's used in `new_lint`
 }
 

tests/ui/arc_new_in_vec_from_slice/complex_case.rs renamed to tests/ui/arc_new_in_vec_from_elem/complex_case.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::arc_new_in_vec_from_slice)]
+#![warn(clippy::arc_new_in_vec_from_elem)]
 use std::sync::Mutex;
 
 fn main() {

tests/ui/arc_new_in_vec_from_slice/complex_case.stderr renamed to tests/ui/arc_new_in_vec_from_elem/complex_case.stderr

@@ -11,7 +11,7 @@ LL | |         2
 LL | |     ];
    | |_____^
    |
-   = note: `-D clippy::arc-new-in-vec-from-slice` implied by `-D warnings`
+   = note: `-D clippy::arc-new-in-vec-from-elem` implied by `-D warnings`
    = help: consider extracting `Arc` initialization to a variable
 
 error: aborting due to previous error

tests/ui/arc_new_in_vec_from_elem/custom_arc_strucrt.rs

@@ -0,0 +1,14 @@
+#![warn(clippy::arc_new_in_vec_from_elem)]
+
+#[derive(Clone)]
+struct Arc;
+
+impl Arc {
+    fn new() -> Self {
+        Arc
+    }
+}
+
+fn main() {
+    let v = vec![Arc::new(); 2];
+}

tests/ui/arc_new_in_vec_from_slice/simple_case.rs renamed to tests/ui/arc_new_in_vec_from_elem/simple_case.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::arc_new_in_vec_from_slice)]
+#![warn(clippy::arc_new_in_vec_from_elem)]
 use std::sync::Arc;
 
 fn main() {

tests/ui/arc_new_in_vec_from_slice/simple_case.stderr renamed to tests/ui/arc_new_in_vec_from_elem/simple_case.stderr

@@ -4,7 +4,7 @@ error: calling `Arc::new` in `vec![elem; len]`
 LL |     let v = vec![Arc::new("x".to_string()); 2];
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = note: `-D clippy::arc-new-in-vec-from-slice` implied by `-D warnings`
+   = note: `-D clippy::arc-new-in-vec-from-elem` implied by `-D warnings`
    = help: consider extracting `Arc` initialization to a variable
 
 error: aborting due to previous error

tests/ui/arc_new_in_vec_from_slice/vec_from_elem_but_not_arc.rs renamed to tests/ui/arc_new_in_vec_from_elem/vec_from_elem_but_not_arc.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::arc_new_in_vec_from_slice)]
+#![warn(clippy::arc_new_in_vec_from_elem)]
 use std::sync::{Arc, Mutex};
 
 fn main() {

tests/ui/arc_new_in_vec_from_slice/vec_macro_but_not_from_elem.rs renamed to tests/ui/arc_new_in_vec_from_elem/vec_macro_but_not_from_elem.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::arc_new_in_vec_from_slice)]
+#![warn(clippy::arc_new_in_vec_from_elem)]
 use std::sync::Arc;
 
 fn main() {