Skip to content

Commit 79247d9

Browse files
committed
Split part of needless_borrow into needless_borrows_for_generic_args
1 parent fed036a commit 79247d9

15 files changed

+1106
-1061
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5171,6 +5171,7 @@ Released 2018-09-13
51715171
[`needless_bool_assign`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign
51725172
[`needless_borrow`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
51735173
[`needless_borrowed_reference`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
5174+
[`needless_borrows_for_generic_args`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
51745175
[`needless_collect`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
51755176
[`needless_continue`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue
51765177
[`needless_doctest_main`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main

clippy_lints/src/declared_lints.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -479,6 +479,7 @@ pub(crate) static LINTS: &[&crate::LintInfo] = &[
479479
crate::needless_bool::NEEDLESS_BOOL_INFO,
480480
crate::needless_bool::NEEDLESS_BOOL_ASSIGN_INFO,
481481
crate::needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE_INFO,
482+
crate::needless_borrows_for_generic_args::NEEDLESS_BORROWS_FOR_GENERIC_ARGS_INFO,
482483
crate::needless_continue::NEEDLESS_CONTINUE_INFO,
483484
crate::needless_else::NEEDLESS_ELSE_INFO,
484485
crate::needless_for_each::NEEDLESS_FOR_EACH_INFO,

clippy_lints/src/dereference.rs

Lines changed: 5 additions & 366 deletions
Large diffs are not rendered by default.

clippy_lints/src/lib.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,7 @@ mod mutex_atomic;
228228
mod needless_arbitrary_self_type;
229229
mod needless_bool;
230230
mod needless_borrowed_ref;
231+
mod needless_borrows_for_generic_args;
231232
mod needless_continue;
232233
mod needless_else;
233234
mod needless_for_each;
@@ -880,7 +881,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
880881
store.register_late_pass(move |_| Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
881882
store.register_late_pass(|_| Box::<redundant_pub_crate::RedundantPubCrate>::default());
882883
store.register_late_pass(|_| Box::new(unnamed_address::UnnamedAddress));
883-
store.register_late_pass(move |_| Box::new(dereference::Dereferencing::new(msrv())));
884+
store.register_late_pass(|_| Box::<dereference::Dereferencing<'_>>::default());
884885
store.register_late_pass(|_| Box::new(option_if_let_else::OptionIfLetElse));
885886
store.register_late_pass(|_| Box::new(future_not_send::FutureNotSend));
886887
let future_size_threshold = conf.future_size_threshold;
@@ -1104,6 +1105,11 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
11041105
store.register_late_pass(|_| Box::new(implied_bounds_in_impls::ImpliedBoundsInImpls));
11051106
store.register_late_pass(|_| Box::new(missing_asserts_for_indexing::MissingAssertsForIndexing));
11061107
store.register_late_pass(|_| Box::new(unnecessary_map_on_constructor::UnnecessaryMapOnConstructor));
1108+
store.register_late_pass(move |_| {
1109+
Box::new(needless_borrows_for_generic_args::NeedlessBorrowsForGenericArgs::new(
1110+
msrv(),
1111+
))
1112+
});
11071113
// add lints here, do not remove this comment, it's used in `new_lint`
11081114
}
11091115

0 commit comments

Comments
 (0)