fixup! Add suspicious group

Author: camsteffen

README.md

@@ -13,11 +13,11 @@ You can choose how much Clippy is supposed to ~~annoy~~ help you by changing the
 | Category              | Description                                                             | Default level |
 | --------------------- | ----------------------------------------------------------------------- | ------------- |
 | `clippy::all`         | all lints that are on by default (correctness, style, complexity, perf) | **warn/deny** |
-| `clippy::correctness` | code that is outright wrong or very useless                             | **deny**      |
+| `clippy::correctness` | code that is outright wrong or useless                                  | **deny**      |
+| `clippy::suspicious`  | code that most likely wrong or useless                                  | **warn**      |
 | `clippy::style`       | code that should be written in a more idiomatic way                     | **warn**      |
 | `clippy::complexity`  | code that does something simple but in a complex way                    | **warn**      |
 | `clippy::perf`        | code that can be written to run faster                                  | **warn**      |
-| `clippy::suspicious`  | code that seems very likely to be incorrect                             | **warn**      |
 | `clippy::pedantic`    | lints which are rather strict or might have false positives             | allow         |
 | `clippy::nursery`     | new lints that are still under development                              | allow         |
 | `clippy::cargo`       | lints for the cargo manifest                                            | allow         |

clippy_dev/src/main.rs

@@ -123,9 +123,9 @@ fn get_clap_config<'a>() -> ArgMatches<'a> {
                         .possible_values(&[
                             "style",
                             "correctness",
+                            "suspicious",
                             "complexity",
                             "perf",
-                            "suspicious",
                             "pedantic",
                             "restriction",
                             "cargo",

clippy_dev/src/update_lints.rs

@@ -94,7 +94,7 @@ pub fn run(update_mode: UpdateMode) {
             let all_group_lints = usable_lints.iter().filter(|l| {
                 matches!(
                     &*l.group,
-                    "correctness" | "style" | "complexity" | "perf" | "suspicious"
+                    "correctness" | "suspicious" | "style" | "complexity" | "perf"
                 )
             });
 

clippy_lints/src/lib.rs

@@ -60,7 +60,7 @@ use rustc_session::Session;
 /// 4. The `description` that contains a short explanation on what's wrong with code where the
 ///    lint is triggered.
 ///
-/// Currently the categories `style`, `correctness`, `complexity`, `perf` and `suspicious` are
+/// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
 /// changes, please update README.md.
 ///
@@ -106,17 +106,17 @@ macro_rules! declare_clippy_lint {
             $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
         }
     };
-    { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
+    { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
         declare_tool_lint! {
             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
         }
     };
-    { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
+    { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
         declare_tool_lint! {
             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
         }
     };
-    { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
+    { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
         declare_tool_lint! {
             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
         }

clippy_lints/src/utils/internal_lints/metadata_collector.rs

@@ -48,12 +48,12 @@ const DEPRECATED_LINT_LEVEL: &str = "none";
 /// lint level for deprecated lints is set in `DEPRECATED_LINT_LEVEL`.
 const DEFAULT_LINT_LEVELS: &[(&str, &str)] = &[
     ("correctness", "deny"),
+    ("suspicious", "warn"),
     ("restriction", "allow"),
     ("style", "warn"),
     ("pedantic", "allow"),
     ("complexity", "warn"),
     ("perf", "warn"),
-    ("suspicious", "warn"),
     ("cargo", "allow"),
     ("nursery", "allow"),
 ];

util/lintlib.py

@@ -19,10 +19,10 @@
 
 lint_levels = {
     "correctness": 'Deny',
+    "suspicious": 'Warn',
     "style": 'Warn',
     "complexity": 'Warn',
     "perf": 'Warn',
-    "suspicious": 'Warn',
     "restriction": 'Allow',
     "pedantic": 'Allow',
     "nursery": 'Allow',