Skip to content

Commit 9ab505a

Browse files
committed
lintcheck: add git source as an example and update logs
1 parent 10fbafa commit 9ab505a

File tree

3 files changed

+71
-13
lines changed

3 files changed

+71
-13
lines changed

clippy_dev/lintcheck_crates.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ bitflags = {name = "bitflags", versions = ['1.2.1']}
1212
libc = {name = "libc", versions = ['0.2.81']}
1313
log = {name = "log", versions = ['0.4.11']}
1414
proc-macro2 = {name = "proc-macro2", versions = ['1.0.24']}
15+
puffin = {name = "puffin", git_url = "https://github.com/EmbarkStudios/puffin", git_hash = "02dd4a3"}
1516
quote = {name = "quote", versions = ['1.0.7']}
1617
rand = {name = "rand", versions = ['0.7.3']}
1718
rand_core = {name = "rand_core", versions = ['0.6.0']}

clippy_dev/src/lintcheck.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ impl CrateSource {
118118
};
119119
// clone the repo if we have not done so
120120
if !repo_path.is_dir() {
121+
println!("Cloning {} and checking out {}", url, commit);
121122
Command::new("git")
122123
.arg("clone")
123124
.arg(url)

lintcheck-logs/logs.txt

Lines changed: 69 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2086,6 +2086,61 @@ proc-macro2-1.0.24/src/parse.rs:808:15 clippy::explicit_iter_loop "it is more co
20862086
proc-macro2-1.0.24/src/wrapper.rs:415:24 clippy::trivially_copy_pass_by_ref "this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)"
20872087
proc-macro2-1.0.24/src/wrapper.rs:429:23 clippy::trivially_copy_pass_by_ref "this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)"
20882088
proc-macro2-1.0.24/src/wrapper.rs:492:17 clippy::trivially_copy_pass_by_ref "this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)"
2089+
puffin-02dd4a3/puffin-imgui/src/ui.rs:158:15 clippy::cast_precision_loss "casting `i64` to `f32` causes a loss of precision (`i64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
2090+
puffin-02dd4a3/puffin-imgui/src/ui.rs:175:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
2091+
puffin-02dd4a3/puffin-imgui/src/ui.rs:183:5 clippy::too_many_lines "this function has too many lines (115/100)"
2092+
puffin-02dd4a3/puffin-imgui/src/ui.rs:1:5 clippy::wildcard_imports "usage of wildcard import"
2093+
puffin-02dd4a3/puffin-imgui/src/ui.rs:207:16 clippy::collapsible_else_if "this `else { if .. }` block can be collapsed"
2094+
puffin-02dd4a3/puffin-imgui/src/ui.rs:271:67 clippy::cast_precision_loss "casting `i64` to `f32` causes a loss of precision (`i64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
2095+
puffin-02dd4a3/puffin-imgui/src/ui.rs:2:5 clippy::wildcard_imports "usage of wildcard import"
2096+
puffin-02dd4a3/puffin-imgui/src/ui.rs:376:29 clippy::cast_precision_loss "casting `i64` to `f32` causes a loss of precision (`i64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
2097+
puffin-02dd4a3/puffin-imgui/src/ui.rs:381:44 clippy::cast_precision_loss "casting `i64` to `f32` causes a loss of precision (`i64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
2098+
puffin-02dd4a3/puffin-imgui/src/ui.rs:453:9 clippy::similar_names "binding's name is too similar to existing binding"
2099+
puffin-02dd4a3/puffin-imgui/src/ui.rs:540:14 clippy::cast_possible_truncation "casting `f64` to `f32` may truncate the value"
2100+
puffin-02dd4a3/puffin-imgui/src/ui.rs:551:5 clippy::cast_precision_loss "casting `i64` to `f64` causes a loss of precision (`i64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)"
2101+
puffin-02dd4a3/puffin-imgui/src/ui.rs:584:39 clippy::cast_precision_loss "casting `usize` to `f32` causes a loss of precision (`usize` is 32 or 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
2102+
puffin-02dd4a3/puffin-imgui/src/ui.rs:59:26 clippy::unsafe_derive_deserialize "you are deriving `serde::Deserialize` on a type that has methods using `unsafe`"
2103+
puffin-02dd4a3/puffin-imgui/src/ui.rs:61:1 clippy::module_name_repetitions "item name ends with its containing module's name"
2104+
puffin-02dd4a3/puffin-imgui/src/ui.rs:627:39 clippy::cast_precision_loss "casting `usize` to `f32` causes a loss of precision (`usize` is 32 or 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
2105+
puffin-02dd4a3/puffin-imgui/src/ui.rs:674:47 clippy::cast_precision_loss "casting `usize` to `f64` causes a loss of precision on targets with 64-bit wide pointers (`usize` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)"
2106+
puffin-02dd4a3/puffin-imgui/src/ui.rs:690:9 clippy::cast_precision_loss "casting `usize` to `f32` causes a loss of precision (`usize` is 32 or 64 bits wide, but `f32`'s mantissa is only 23 bits wide)"
2107+
puffin-02dd4a3/puffin/src/data.rs:102:25 clippy::cast_possible_truncation "casting `usize` to `u8` may truncate the value"
2108+
puffin-02dd4a3/puffin/src/data.rs:112:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
2109+
puffin-02dd4a3/puffin/src/data.rs:116:5 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
2110+
puffin-02dd4a3/puffin/src/data.rs:137:24 clippy::match_same_arms "this `match` has identical arm bodies"
2111+
puffin-02dd4a3/puffin/src/data.rs:177:5 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
2112+
puffin-02dd4a3/puffin/src/data.rs:211:21 clippy::cast_possible_truncation "casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers"
2113+
puffin-02dd4a3/puffin/src/data.rs:24:5 clippy::wildcard_imports "usage of wildcard import"
2114+
puffin-02dd4a3/puffin/src/data.rs:75:5 clippy::missing_panics_doc "docs for function which may panic missing `# Panics` section"
2115+
puffin-02dd4a3/puffin/src/lib.rs:113:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
2116+
puffin-02dd4a3/puffin/src/lib.rs:147:5 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
2117+
puffin-02dd4a3/puffin/src/lib.rs:147:5 clippy::missing_panics_doc "docs for function which may panic missing `# Panics` section"
2118+
puffin-02dd4a3/puffin/src/lib.rs:165:5 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
2119+
puffin-02dd4a3/puffin/src/lib.rs:200:21 clippy::default_trait_access "calling `Stream::default()` is more clear than this expression"
2120+
puffin-02dd4a3/puffin/src/lib.rs:257:78 clippy::default_trait_access "calling `std::cell::RefCell::default()` is more clear than this expression"
2121+
puffin-02dd4a3/puffin/src/lib.rs:297:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
2122+
puffin-02dd4a3/puffin/src/lib.rs:302:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
2123+
puffin-02dd4a3/puffin/src/lib.rs:308:28 clippy::default_trait_access "calling `FullProfileData::default()` is more clear than this expression"
2124+
puffin-02dd4a3/puffin/src/lib.rs:316:1 clippy::must_use_candidate "this function could have a `#[must_use]` attribute"
2125+
puffin-02dd4a3/puffin/src/lib.rs:321:5 clippy::cast_possible_truncation "casting `u128` to `i64` may truncate the value"
2126+
puffin-02dd4a3/puffin/src/lib.rs:348:28 clippy::default_trait_access "calling `std::marker::PhantomData::default()` is more clear than this expression"
2127+
puffin-02dd4a3/puffin/src/lib.rs:359:1 clippy::must_use_candidate "this function could have a `#[must_use]` attribute"
2128+
puffin-02dd4a3/puffin/src/lib.rs:375:1 clippy::must_use_candidate "this function could have a `#[must_use]` attribute"
2129+
puffin-02dd4a3/puffin/src/lib.rs:376:5 clippy::option_if_let_else "use Option::map_or instead of an if let/else"
2130+
puffin-02dd4a3/puffin/src/lib.rs:377:9 clippy::option_if_let_else "use Option::map_or instead of an if let/else"
2131+
puffin-02dd4a3/puffin/src/lib.rs:406:1 clippy::must_use_candidate "this function could have a `#[must_use]` attribute"
2132+
puffin-02dd4a3/puffin/src/lib.rs:408:5 clippy::option_if_let_else "use Option::map_or instead of an if let/else"
2133+
puffin-02dd4a3/puffin/src/lib.rs:69:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
2134+
puffin-02dd4a3/puffin/src/lib.rs:73:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
2135+
puffin-02dd4a3/puffin/src/lib.rs:77:5 clippy::must_use_candidate "this method could have a `#[must_use]` attribute"
2136+
puffin-02dd4a3/puffin/src/merge.rs:21:1 clippy::module_name_repetitions "item name starts with its containing module's name"
2137+
puffin-02dd4a3/puffin/src/merge.rs:28:1 clippy::module_name_repetitions "item name starts with its containing module's name"
2138+
puffin-02dd4a3/puffin/src/merge.rs:28:1 clippy::must_use_candidate "this function could have a `#[must_use]` attribute"
2139+
puffin-02dd4a3/puffin/src/merge.rs:35:1 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
2140+
puffin-02dd4a3/puffin/src/merge.rs:35:1 clippy::module_name_repetitions "item name starts with its containing module's name"
2141+
puffin-02dd4a3/puffin/src/merge.rs:64:43 clippy::default_trait_access "calling `std::vec::Vec::default()` is more clear than this expression"
2142+
puffin-02dd4a3/puffin/src/merge.rs:65:54 clippy::default_trait_access "calling `std::collections::HashMap::default()` is more clear than this expression"
2143+
puffin-02dd4a3/puffin/src/merge.rs:9:1 clippy::module_name_repetitions "item name starts with its containing module's name"
20892144
quote-1.0.7/src/ext.rs:10:1 clippy::module_name_repetitions "item name ends with its containing module's name"
20902145
quote-1.0.7/src/ext.rs:7:5 clippy::doc_markdown "you should put `TokenStream` between ticks in the documentation"
20912146
quote-1.0.7/src/ident_fragment.rs:13:5 clippy::missing_errors_doc "docs for function returning `Result` missing `# Errors` section"
@@ -3383,6 +3438,7 @@ clippy::should_implement_trait 1
33833438
clippy::stable_sort_primitive 1
33843439
clippy::unit_arg 1
33853440
clippy::unnecessary_lazy_evaluations 1
3441+
clippy::unsafe_derive_deserialize 1
33863442
clippy::used_underscore_binding 1
33873443
clippy::verbose_bit_mask 1
33883444
clippy::while_let_on_iterator 1
@@ -3410,7 +3466,6 @@ clippy::ptr_arg 3
34103466
clippy::zero_ptr 3
34113467
clippy::let_underscore_drop 4
34123468
clippy::too_many_arguments 4
3413-
clippy::collapsible_else_if 5
34143469
clippy::explicit_iter_loop 5
34153470
clippy::field_reassign_with_default 5
34163471
clippy::identity_op 5
@@ -3419,6 +3474,7 @@ clippy::match_like_matches_macro 5
34193474
clippy::needless_return 5
34203475
clippy::new_without_default 5
34213476
clippy::ptr_as_ptr 5
3477+
clippy::collapsible_else_if 6
34223478
clippy::manual_strip 6
34233479
clippy::non_ascii_literal 6
34243480
clippy::single_component_path_imports 6
@@ -3436,12 +3492,11 @@ clippy::missing_safety_doc 10
34363492
clippy::needless_doctest_main 10
34373493
clippy::multiple_crate_versions 11
34383494
clippy::needless_lifetimes 12
3439-
clippy::option_if_let_else 12
34403495
clippy::cargo_common_metadata 13
34413496
clippy::shadow_unrelated 13
34423497
clippy::linkedlist 14
34433498
clippy::single_char_add_str 14
3444-
clippy::default_trait_access 16
3499+
clippy::option_if_let_else 15
34453500
clippy::needless_pass_by_value 18
34463501
clippy::upper_case_acronyms 18
34473502
clippy::cast_possible_wrap 19
@@ -3452,26 +3507,27 @@ clippy::unusual_byte_groupings 19
34523507
clippy::map_unwrap_or 20
34533508
clippy::struct_excessive_bools 20
34543509
clippy::redundant_static_lifetimes 21
3510+
clippy::default_trait_access 22
34553511
clippy::cast_lossless 23
34563512
clippy::trivially_copy_pass_by_ref 26
34573513
clippy::redundant_else 29
3458-
clippy::too_many_lines 31
3459-
clippy::cast_precision_loss 35
3514+
clippy::too_many_lines 32
34603515
clippy::if_not_else 35
34613516
clippy::enum_glob_use 40
34623517
clippy::unseparated_literal_suffix 41
3518+
clippy::cast_precision_loss 44
34633519
clippy::single_match_else 45
34643520
clippy::inline_always 59
3465-
clippy::match_same_arms 64
3466-
clippy::similar_names 77
3467-
clippy::cast_possible_truncation 91
3468-
clippy::missing_panics_doc 106
3521+
clippy::match_same_arms 65
3522+
clippy::similar_names 78
3523+
clippy::cast_possible_truncation 95
3524+
clippy::missing_panics_doc 108
34693525
clippy::redundant_field_names 111
34703526
clippy::redundant_closure_for_method_calls 135
3471-
clippy::module_name_repetitions 137
34723527
clippy::items_after_statements 139
3473-
clippy::wildcard_imports 160
3528+
clippy::module_name_repetitions 142
3529+
clippy::wildcard_imports 163
34743530
clippy::doc_markdown 178
3475-
clippy::missing_errors_doc 338
3531+
clippy::missing_errors_doc 343
34763532
clippy::unreadable_literal 365
3477-
clippy::must_use_candidate 552
3533+
clippy::must_use_candidate 565

0 commit comments

Comments
 (0)