@@ -7,14 +7,16 @@ very flat hierarchy. The teams mainly have additional access rights to the repo.
7
7
This document outlines the onboarding process, as well as duties, and access
8
8
rights for members of a group.
9
9
10
+ All regular events mentioned in this chapter are tracked in the [ calendar repository] .
11
+ The calendar file is also available for download: [ clippy.ics]
12
+
10
13
## Everyone
11
14
12
15
Everyone, including you, is welcome to join discussions and contribute in other
13
16
ways, like PRs.
14
17
15
18
You also have some triage rights, using ` @rustbot ` to add labels and claim
16
- issues. See
17
- [ labeling with @rustbot ] ( https://forge.rust-lang.org/triagebot/labeling.html )
19
+ issues. See [ labeling with @rustbot ] .
18
20
19
21
A rule for everyone should be to keep a healthy work-life balance. Take a break
20
22
when you need one.
@@ -37,7 +39,7 @@ this group to help with triaging, which can include:
37
39
38
40
2 . ** Closing duplicate or resolved issues**
39
41
40
- When you manually close and issue, it's often a good idea, to add a short
42
+ When you manually close an issue, it's often a good idea, to add a short
41
43
comment explaining the reason.
42
44
43
45
3 . ** Ping people after two weeks of inactivity**
@@ -52,6 +54,9 @@ this group to help with triaging, which can include:
52
54
Checkout: https://triage.rust-lang.org/triage/rust-lang/rust-clippy to
53
55
monitor PRs.
54
56
57
+ While not part of their duties, contributors are encouraged to review PRs
58
+ and help on Zulip. The team always appreciates help!
59
+
55
60
### Membership
56
61
57
62
If you have been contributing to Clippy for some time, we'll probably ask you if
@@ -77,36 +82,49 @@ is responsible for maintaining Clippy.
77
82
It's totally fine, if you don't have the time for reviews right now.
78
83
You can reassign the PR to a random member by commenting ` r? clippy ` .
79
84
80
- 2 . ** Take a break when you need one. **
85
+ 2 . ** Take a break when you need one**
81
86
82
87
You are valuable! Clippy wouldn't be what it is without you. So take a break
83
88
early and recharge some energy when you need to.
84
89
85
- 3 . ** Sync Clippy with the rust-lang/rust repo**
90
+ 3 . ** Be responsive on Zulip**
91
+
92
+ This means in a reasonable time frame, so responding within one or two days
93
+ is totally fine.
86
94
87
- This should be done roughly every two weeks. This is usually done by our
88
- king @flip1995 .
95
+ It's also good, if you answer threads on Zulip and take part in our Clippy
96
+ meetings, every two weeks. The meeting dates are tracked in the [ calendar repository] .
97
+
89
98
90
- 4 . ** Update the changelog**
99
+ 4 . ** Sync Clippy with the rust-lang/rust repo**
100
+
101
+ This is done every two weeks, usually by @flip1995 .
102
+
103
+ 5 . ** Update the changelog**
91
104
92
105
This needs to be done for every release, every six weeks. This is usually
93
106
done by @xFrednet .
94
107
95
108
### Membership
96
109
97
- If you have been in the * Clippy-Contributors* team for some time, we'll probably
98
- reach out and ask if you want to help with reviews and eventually join the
99
- Clippy team.
110
+ If you have been active for some time, we'll probably reach out and ask
111
+ if you want to help with reviews and eventually join the Clippy team.
100
112
101
- During the onboarding process, you'll have an active Clippy team member as a
102
- mentor, who assigns PRs to you. They will shadow your reviews, meaning that
103
- they'll keep an eye on your PRs, help you with any questions, and once you're
104
- done, perform a full review. When everything looks good, they'll r+ the PR in
105
- the name of both of you .
113
+ During the onboarding process, you'll be assigned pull requests to review.
114
+ You'll also have an active team member as a mentor who'll stay in contact via
115
+ Zulip DMs to provide advice and feedback. If you have questions, you're always
116
+ welcome to ask, that is the best way to learn. Once you're done with the review,
117
+ you can ping your mentor for a full review and to r+ the PR in both of your names .
106
118
107
- When you've done several reviews and seem confident in the role, you'll be
108
- invited to join the team officially, as long as you're still interested. This
119
+ When your mentor is confident that you can handle reviews on your own, they'll
120
+ start an informal vote among the active team members to officially add you to
121
+ the team. This vote is usually accepted unanimously. Then you'll be added to
122
+ the team once you've confirmed that you're still interested in joining. The
109
123
onboarding phase typically takes a couple of weeks to a few months.
110
124
111
125
If you have been inactive in Clippy for over three months, we'll probably move
112
126
you to the alumni group. You're always welcome to come back.
127
+
128
+ [ calendar repository ] : https://github.com/rust-lang/calendar/blob/main/clippy.toml
129
+ [ clippy.ics ] : https://rust-lang.github.io/calendar/clippy.ics
130
+ [ labeling with @rustbot ] : https://forge.rust-lang.org/triagebot/labeling.html
0 commit comments