remove if_chain invocation

Author: Centri3

clippy_lints/src/unit_types/let_unit_value.rs

@@ -18,63 +18,61 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, local: &'tcx Local<'_>) {
         return;
     }
 
-    if_chain! {
-        if let Some(init) = local.init;
-        if !local.pat.span.from_expansion();
-        if !in_external_macro(cx.sess(), local.span);
-        if cx.typeck_results().pat_ty(local.pat).is_unit();
-        then {
-            // skip `let awa = ()`
-            if let ExprKind::Tup(elements) = init.kind && elements.is_empty() {
-                return;
-            }
+    if let Some(init) = local.init
+        && !local.pat.span.from_expansion()
+        && !in_external_macro(cx.sess(), local.span)
+        && cx.typeck_results().pat_ty(local.pat).is_unit()
+    {
+        // skip `let awa = ()`
+        if let ExprKind::Tup(elements) = init.kind && elements.is_empty() {
+            return;
+        }
 
-            if (local.ty.map_or(false, |ty| !matches!(ty.kind, TyKind::Infer))
-                || matches!(local.pat.kind, PatKind::Tuple([], ddpos) if ddpos.as_opt_usize().is_none()))
-                && expr_needs_inferred_result(cx, init)
+        if (local.ty.map_or(false, |ty| !matches!(ty.kind, TyKind::Infer))
+            || matches!(local.pat.kind, PatKind::Tuple([], ddpos) if ddpos.as_opt_usize().is_none()))
+            && expr_needs_inferred_result(cx, init)
+        {
+            if !matches!(local.pat.kind, PatKind::Wild)
+                && !matches!(local.pat.kind, PatKind::Tuple([], ddpos) if ddpos.as_opt_usize().is_none())
             {
-                if !matches!(local.pat.kind, PatKind::Wild)
-                   && !matches!(local.pat.kind, PatKind::Tuple([], ddpos) if ddpos.as_opt_usize().is_none())
-                {
-                    span_lint_and_then(
-                        cx,
-                        LET_UNIT_VALUE,
-                        local.span,
-                        "this let-binding has unit value",
-                        |diag| {
-                            diag.span_suggestion(
-                                local.pat.span,
-                                "use a wild (`_`) binding",
-                                "_",
-                                Applicability::MaybeIncorrect, // snippet
-                            );
-                        },
-                    );
-                }
-            } else {
-                if let ExprKind::Match(_, _, MatchSource::AwaitDesugar) = init.kind {
-                    return
-                }
-
                 span_lint_and_then(
                     cx,
                     LET_UNIT_VALUE,
                     local.span,
                     "this let-binding has unit value",
                     |diag| {
-                        if let Some(expr) = &local.init {
-                            let mut app = Applicability::MachineApplicable;
-                            let snip = snippet_with_context(cx, expr.span, local.span.ctxt(), "()", &mut app).0;
-                            diag.span_suggestion(
-                                local.span,
-                                "omit the `let` binding",
-                                format!("{snip};"),
-                                app,
-                            );
-                        }
+                        diag.span_suggestion(
+                            local.pat.span,
+                            "use a wild (`_`) binding",
+                            "_",
+                            Applicability::MaybeIncorrect, // snippet
+                        );
                     },
                 );
             }
+        } else {
+            if let ExprKind::Match(_, _, MatchSource::AwaitDesugar) = init.kind {
+                return
+            }
+
+            span_lint_and_then(
+                cx,
+                LET_UNIT_VALUE,
+                local.span,
+                "this let-binding has unit value",
+                |diag| {
+                    if let Some(expr) = &local.init {
+                        let mut app = Applicability::MachineApplicable;
+                        let snip = snippet_with_context(cx, expr.span, local.span.ctxt(), "()", &mut app).0;
+                        diag.span_suggestion(
+                            local.span,
+                            "omit the `let` binding",
+                            format!("{snip};"),
+                            app,
+                        );
+                    }
+                },
+            );
         }
     }
 }