Swap type checked expression

Instead of type checking the entire expression (causing a false
positive), only type check for a subset of the expression (the receiver of
the matched function: `take()`)

Author: b-NC

clippy_lints/src/methods/option_take_on_temporary.rs

@@ -8,14 +8,14 @@ use rustc_span::sym;
 
 use super::OPTION_TAKE_ON_TEMPORARY;
 
-pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, recv: &'tcx Expr<'_>) {
+pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, _expr: &'tcx Expr<'_>, recv: &'tcx Expr<'_>) {
     // Checks if expression type is equal to sym::Option and if the expr is not a syntactic place
-    if is_expr_option(cx, expr) && !expr.is_syntactic_place_expr() {
+    if is_expr_option(cx, recv) && !recv.is_syntactic_place_expr() {
         let mut applicability = Applicability::MachineApplicable;
         span_lint_and_sugg(
             cx,
             OPTION_TAKE_ON_TEMPORARY,
-            expr.span,
+            recv.span,
             "Called `Option::take()` on a temporary value",
             "try",
             format!(