iter_over_hash_type and enumerate

[niclashoyer]

This dumb mistake just happend to me today 💯 I did not realize that I'm iterating over a hash set instead of a vec.

By default iter_over_hash_type is allow. Which seems okay, given that iterating over e.g. keys of a hash map may not be a problem. Is it possible to expand this lint to also check the usage of the iterator? Maybe into a lint that is more strict by default, something like iter_over_hash_type_with_enumerate ?

Because hash_set.iter().enumerate() is definitely wrong, as the numbers returned this way are truly arbitrary and not useful at all.

[Alexendoo]

Arbitrary numbers could be fine for e.g. displaying a progress bar as you process a set

[niclashoyer]

Fair enough, that would be a use case 🤔