Fix and enhance next/prev message jumping. (#207)

* Sort build messages by level for next/prev shortcuts.

* Add tests for next/prev message order.

* Update for rust 1.22.

* Next/Prev message support when show_errors_inline is False.

Fixes #206.

* Add undocumented config variable to disable message sorting.

* Support scrolling the build output panel on next/prev message.

* Fix on-save checking when show_errors_inline is false.

To disable on-save checking, set rust_syntax_checking to false.

* Next/Prev message cycles through test errors.

* Ensure that all views are closed after running tests.

* Fix cyclic import.

* Fix test errors that panic outside of the crate.

Rust display the source file to the outside crate, which probably isn't
available in the current workspace.  Next/Prev message was opening a
non-existent file.

* Fix Next/Prev overriding find-in-files next/prev result.

Fixes #209.

Author: ehuss

SyntaxCheckPlugin.py

@@ -106,7 +106,7 @@ def run(self):
                 self.get_rustc_messages()
             except rust_proc.ProcessTerminatedError:
                 return
-            messages.draw_all_region_highlights(self.window)
+            messages.messages_finished(self.window)
         finally:
             self.view.erase_status('rust-check')
 
@@ -124,7 +124,8 @@ def get_rustc_messages(self):
         if method == 'clippy':
             # Clippy does not support cargo target filters, must be run for
             # all targets.
-            cmd = settings.get_command(method, command_info, self.cwd)
+            cmd = settings.get_command(method, command_info, self.cwd,
+                force_json=True)
             p = rust_proc.RustProc()
             p.run(self.window, cmd['command'], self.cwd, self, env=cmd['env'])
             p.wait()
@@ -135,7 +136,8 @@ def get_rustc_messages(self):
         targets = td.determine_targets(self.triggered_file_name)
         for (target_src, target_args) in targets:
             cmd = settings.get_command(method, command_info, self.cwd,
-                initial_settings={'target': ' '.join(target_args)})
+                initial_settings={'target': ' '.join(target_args)},
+                force_json=True)
             if method == 'no-trans':
                 cmd['command'].extend(['--', '-Zno-trans', '-Zunstable-options'])
                 if (util.get_setting('rust_syntax_checking_include_tests', True) and

cargo_build.py

@@ -196,7 +196,8 @@ def run(self):
             return
         messages.clear_messages(self.window)
         p = rust_proc.RustProc()
-        listener = opanel.OutputListener(self.window, self.working_dir)
+        listener = opanel.OutputListener(self.window, self.working_dir,
+                                         self.command_name)
         decode_json = util.get_setting('show_errors_inline', True) and \
             self.command_info.get('allows_json', False)
         try:
@@ -229,16 +230,28 @@ def on_load(self, view):
                 lambda: messages.show_messages_for_view(view), 1)
 
 
-class RustNextMessageCommand(sublime_plugin.WindowCommand):
+class NextPrevBase(sublime_plugin.WindowCommand):
+
+    def _has_inline(self):
+        return self.window.id() in messages.WINDOW_MESSAGES
+
+
+class RustNextMessageCommand(NextPrevBase):
 
     def run(self, levels='all'):
-        messages.show_next_message(self.window, levels)
+        if self._has_inline():
+            messages.show_next_message(self.window, levels)
+        else:
+            self.window.run_command('next_result')
 
 
-class RustPrevMessageCommand(sublime_plugin.WindowCommand):
+class RustPrevMessageCommand(NextPrevBase):
 
     def run(self, levels='all'):
-        messages.show_prev_message(self.window, levels)
+        if self._has_inline():
+            messages.show_prev_message(self.window, levels)
+        else:
+            self.window.run_command('prev_result')
 
 
 class RustCancelCommand(sublime_plugin.WindowCommand):

rust/cargo_settings.py

@@ -350,7 +350,7 @@ def get_merged(self, settings_path, variant, target, key,
         return result
 
     def get_command(self, cmd_name, cmd_info,
-                    settings_path, initial_settings={}):
+                    settings_path, initial_settings={}, force_json=False):
         """Generates the command arguments for running Cargo.
 
         :param cmd_name: The name of the command, the key used to select a
@@ -361,6 +361,7 @@ def get_command(self, cmd_name, cmd_info,
             directory.
         :keyword initial_settings: Initial settings to inject which override
             all other settings.
+        :keyword force_json: If True, will force JSON output.
 
         :Returns: A dictionary with the keys:
             - `command`: The command to run as a list of strings.
@@ -400,8 +401,8 @@ def get_computed(key, default=None):
             if v:
                 result.append('--release')
 
-        if cmd_info.get('allows_json', False) and \
-                util.get_setting('show_errors_inline', True):
+        if force_json or (cmd_info.get('allows_json', False) and
+                util.get_setting('show_errors_inline', True)):
             result.append('--message-format=json')
 
         # features