Skip to content

Commit 798feb2

Browse files
[beta] group old_tests by just the filename, not the test name
1 parent 1e8fbb1 commit 798feb2

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

src/librustdoc/test.rs

+3-10
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ fn partition_source(s: &str) -> (String, String) {
434434
pub struct Collector {
435435
pub tests: Vec<testing::TestDescAndFn>,
436436
// to be removed when hoedown will be definitely gone
437-
pub old_tests: HashMap<String, Vec<String>>,
437+
pub old_tests: HashMap<FileName, Vec<String>>,
438438

439439
// The name of the test displayed to the user, separated by `::`.
440440
//
@@ -501,14 +501,8 @@ impl Collector {
501501
format!("{} - {} (line {})", filename, self.names.join("::"), line)
502502
}
503503

504-
// to be removed once hoedown is gone
505-
fn generate_name_beginning(&self, filename: &FileName) -> String {
506-
format!("{} - {} (line", filename, self.names.join("::"))
507-
}
508-
509504
pub fn add_old_test(&mut self, test: String, filename: FileName) {
510-
let name_beg = self.generate_name_beginning(&filename);
511-
let entry = self.old_tests.entry(name_beg)
505+
let entry = self.old_tests.entry(filename.clone())
512506
.or_insert(Vec::new());
513507
entry.push(test.trim().to_owned());
514508
}
@@ -520,10 +514,9 @@ impl Collector {
520514
let name = self.generate_name(line, &filename);
521515
// to be removed when hoedown is removed
522516
if self.render_type == RenderType::Pulldown {
523-
let name_beg = self.generate_name_beginning(&filename);
524517
let mut found = false;
525518
let test = test.trim().to_owned();
526-
if let Some(entry) = self.old_tests.get_mut(&name_beg) {
519+
if let Some(entry) = self.old_tests.get_mut(&filename) {
527520
found = entry.remove_item(&test).is_some();
528521
}
529522
if !found {

0 commit comments

Comments
 (0)