Skip to content

Commit a397fdc

Browse files
authored
Remove ASCII fast path from rustc_lexer::{is_id_continue, is_id_start}
1 parent 08095fc commit a397fdc

File tree

1 file changed

+2
-12
lines changed
  • compiler/rustc_lexer/src

1 file changed

+2
-12
lines changed

compiler/rustc_lexer/src/lib.rs

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -273,24 +273,14 @@ pub fn is_whitespace(c: char) -> bool {
273273
/// a formal definition of valid identifier name.
274274
pub fn is_id_start(c: char) -> bool {
275275
// This is XID_Start OR '_' (which formally is not a XID_Start).
276-
// We also add fast-path for ascii idents
277-
('a'..='z').contains(&c)
278-
|| ('A'..='Z').contains(&c)
279-
|| c == '_'
280-
|| (c > '\x7f' && unicode_xid::UnicodeXID::is_xid_start(c))
276+
c == '_' || unicode_xid::UnicodeXID::is_xid_start(c)
281277
}
282278

283279
/// True if `c` is valid as a non-first character of an identifier.
284280
/// See [Rust language reference](https://doc.rust-lang.org/reference/identifiers.html) for
285281
/// a formal definition of valid identifier name.
286282
pub fn is_id_continue(c: char) -> bool {
287-
// This is exactly XID_Continue.
288-
// We also add fast-path for ascii idents
289-
('a'..='z').contains(&c)
290-
|| ('A'..='Z').contains(&c)
291-
|| ('0'..='9').contains(&c)
292-
|| c == '_'
293-
|| (c > '\x7f' && unicode_xid::UnicodeXID::is_xid_continue(c))
283+
unicode_xid::UnicodeXID::is_xid_continue(c)
294284
}
295285

296286
/// The passed string is lexically an identifier.

0 commit comments

Comments
 (0)