go back to ignoring "intra-doc links" with spaces in them

Author: lolbinarycat

src/librustdoc/passes/collect_intra_doc_links.rs

@@ -1003,7 +1003,7 @@ fn preprocess_link(
     assert!(!path_str.contains(['<', '>'].as_slice()));
 
     // The link is not an intra-doc link if it still contains spaces after stripping generics.
-    if can_be_url && path_str.contains(' ') {
+    if path_str.contains(' ') {
         return None;
     }
 

tests/rustdoc-ui/bad-intra-doc.rs

@@ -5,7 +5,7 @@
 
 /// this is not a link to [`example.com`] //~ERROR unresolved link
 ///
-/// this link [`has spaces in it`]. //~ERROR unresolved link
+/// this link [`has spaces in it`].
 ///
 /// attempted link to method: [`Foo.bar()`] //~ERROR unresolved link
 ///

tests/rustdoc-ui/bad-intra-doc.stderr

@@ -11,14 +11,6 @@ note: the lint level is defined here
 LL | #![deny(rustdoc::broken_intra_doc_links)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: unresolved link to `has spaces in it`
-  --> $DIR/bad-intra-doc.rs:8:17
-   |
-LL | /// this link [`has spaces in it`].
-   |                 ^^^^^^^^^^^^^^^^ no item named `has spaces in it` in scope
-   |
-   = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
-
 error: unresolved link to `Foo.bar`
   --> $DIR/bad-intra-doc.rs:10:33
    |
@@ -35,5 +27,5 @@ LL | /// classic broken intra-doc link: [`Bar`]
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
 
-error: aborting due to 4 previous errors
+error: aborting due to 3 previous errors