Skip to content

TAIT: concrete type differs from previous defining opaque type use at the same location #114727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xxchan opened this issue Aug 11, 2023 · 2 comments · Fixed by #114914
Closed

TAIT: concrete type differs from previous defining opaque type use at the same location #114727

xxchan opened this issue Aug 11, 2023 · 2 comments · Fixed by #114914
Assignees
@compiler-errors
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.

Comments

@xxchan
Copy link
Contributor

xxchan commented Aug 11, 2023 •
edited
Loading

"previous use here" seems to be the same location as the error?

error: concrete type differs from previous defining opaque type use
   --> src/storage/src/table/batch_table/storage_table.rs:505:9
    |
505 |         Ok(iter)
    |         ^^^^^^^^ expected `StorageTableInnerIter<S, SD>`, got `impl Stream<Item = std::result::Result<(Vec<u8>, OwnedRow), error::StorageError>> + 'static`
    |
note: previous use here
   --> src/storage/src/table/batch_table/storage_table.rs:412:54
    |
412 |       ) -> StorageResult<StorageTableInnerIter<S, SD>> {
    |  ______________________________________________________^
413 | |         let cache_policy = match (
414 | |             encoded_key_range.start_bound(),
415 | |             encoded_key_range.end_bound(),
...   |
505 | |         Ok(iter)
506 | |     }
    | |_____^

warning: `risingwave_storage` (lib) generated 1 warning

Note: tested latest 2023-08-11, and reports same error.

Tested on this commit risingwavelabs/risingwave@9d3e587

cargo build -p risingwave_storage

(Sorry for not having a minimal example yet)

Bisect rustc and found the regression commit:

searched nightlies: from nightly-2023-06-16 to nightly-2023-07-08
regressed nightly: nightly-2023-06-18
searched commit range: 6bba061...3b2073f
regressed commit: 0cc541e

bisected with cargo-bisect-rustc v0.6.6

Host triple: aarch64-apple-darwin
Reproduce with:

cargo bisect-rustc --start 2023-06-16 --end 2023-07-08 -- build -p risingwave_storage

Source code here

https://github.com/risingwavelabs/risingwave/blob/tygg-bump-toolchain-20230728/src/storage/src/table/batch_table/storage_table.rs#L386-L388

https://github.com/risingwavelabs/risingwave/blob/9d3e587b0aeb2b0f4236953b6015a6f1b864c1bf/src/storage/src/table/batch_table/storage_table.rs#L404-L504
@xxchan xxchan added the C-bug Category: This is a bug. label Aug 11, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 11, 2023
@xxchan
Copy link
Contributor Author

xxchan commented Aug 11, 2023

@rustbot label +F-type_alias_impl_trait

@rustbot rustbot added the F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` label Aug 11, 2023
xxchan referenced this issue in risingwavelabs/risingwave Aug 11, 2023
@TennyZhuang
bump toolchain
9d3e587 
Signed-off-by: TennyZhuang <[email protected]>
@oli-obk oli-obk added the A-diagnostics Area: Messages for errors, warnings, and lints label Aug 11, 2023
@oli-obk oli-obk moved this to Can do after stabilization in type alias impl trait stabilization Aug 11, 2023
@saethlin saethlin added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 11, 2023
@xxchan xxchan mentioned this issue Aug 16, 2023
Closed
@compiler-errors compiler-errors mentioned this issue Aug 16, 2023
Merged
@compiler-errors
Copy link
Member

I believe this is the same issue as #114909, so it should be fixed as #114914

@compiler-errors compiler-errors self-assigned this Aug 17, 2023
@bors bors closed this as completed in 39e0749 Aug 20, 2023
@github-project-automation github-project-automation bot moved this from Can do after stabilization to Done in type alias impl trait stabilization Aug 20, 2023
xxchan added a commit to risingwavelabs/risingwave that referenced this issue Aug 21, 2023
@xxchan
bump to 08-21, fixing TAIT bug
b78cf6e 
rust-lang/rust#114727

Also
- Update to nightly's new Error::provide API
- Fix some lints
xxchan added a commit to risingwavelabs/risingwave that referenced this issue Aug 21, 2023
@xxchan
bump to 08-21, fixing TAIT bug
94011cd 
rust-lang/rust#114727

Also
- Update to nightly's new Error::provide API
- Fix some lints
xxchan added a commit to risingwavelabs/risingwave that referenced this issue Aug 21, 2023
@xxchan
bump to 08-21, fixing TAIT bug
5a7bcbb 
rust-lang/rust#114727

Also
- Update to nightly's new Error::provide API
- Fix some lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compiler-errors compiler-errors

Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
type alias impl trait stabilization
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalize return type of deduce_future_output_from_obligations compiler-errors/rust
5 participants
@oli-obk @compiler-errors @saethlin @xxchan @rustbot