-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICE: failed to reparse
#139445
Labels
A-macros
Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
C-bug
Category: This is a bug.
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
mvce fn main() {
assert_eq!('u, 'a,)
} comma at the end is load bearing for the ice |
bisects to #139341 😆 cc @nnethercote |
nnethercote
added a commit
to nnethercote/rust
that referenced
this issue
Apr 6, 2025
This can happen when invalid syntax is passed to a declarative macro. We shouldn't be too strict about the token stream position once the parser has rejected the invalid syntax. Fixes rust-lang#139248 and rust-lang#139445.
nnethercote
added a commit
to nnethercote/rust
that referenced
this issue
Apr 6, 2025
This can happen when invalid syntax is passed to a declarative macro. We shouldn't be too strict about the token stream position once the parser has rejected the invalid syntax. Fixes rust-lang#139248 and rust-lang#139445.
nnethercote
added a commit
to nnethercote/rust
that referenced
this issue
Apr 6, 2025
This can happen when invalid syntax is passed to a declarative macro. We shouldn't be too strict about the token stream position once the parser has rejected the invalid syntax. Fixes rust-lang#139248 and rust-lang#139445.
nnethercote
added a commit
to nnethercote/rust
that referenced
this issue
Apr 7, 2025
Fixes rust-lang#139445. The additional errors aren't great but the first one is still good and it's the most important, and imperfect errors are better than ICEing.
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Apr 7, 2025
…5, r=<try> Allow for reparsing failure when reparsing a pasted metavar. Allow for reparsing failure when reparsing a pasted metavar. Fixes rust-lang#139445. The additional errors aren't great but the first one is still good and it's the most important, and imperfect errors are better than ICEing. r? `@petrochenkov`
Zalathar
added a commit
to Zalathar/rust
that referenced
this issue
Apr 8, 2025
…445, r=petrochenkov Allow for reparsing failure when reparsing a pasted metavar. Fix some metavar reparsing issues. Fixes rust-lang#139248 and rust-lang#139445. r? `@petrochenkov`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Apr 8, 2025
Rollup merge of rust-lang#139464 - nnethercote:fix-139248-AND-fix-139445, r=petrochenkov Allow for reparsing failure when reparsing a pasted metavar. Fix some metavar reparsing issues. Fixes rust-lang#139248 and rust-lang#139445. r? `@petrochenkov`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-macros
Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
C-bug
Category: This is a bug.
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
auto-reduced (treereduce-rust):
original:
Version information
Possibly related line of code:
rust/compiler/rustc_parse/src/parser/mod.rs
Lines 780 to 792 in 1de9312
Command:
/home/matthias/.rustup/toolchains/master/bin/rustc
Program output
The text was updated successfully, but these errors were encountered: