Skip to content

move coerce_match{,_calls} and related tests into run-pass-valgrind #21696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pnkfelix opened this issue Jan 27, 2015 · 3 comments
Closed

move coerce_match{,_calls} and related tests into run-pass-valgrind #21696

pnkfelix opened this issue Jan 27, 2015 · 3 comments
Assignees
@pnkfelix
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@pnkfelix
Copy link
Member

Put (copies of?) coerce_match{,_calls} and related tests into run-pass-valgrind. Because our current testing infrastructure is not aggressive enough in checking that tests like this are actually behaving in a sound manner.

spawned off of: #20055 (comment)

(I did not attempt this in PR #21692 because I wanted to expedite landing the fix for the trans bug.)
@pnkfelix pnkfelix added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 27, 2015
@pnkfelix
Copy link
Member Author

@nick29581 clarified the situation to me: even if valgrind is not available on a host, the tests in run-pass-valgrind will be run (just without valgrind checking them).

So resolving this is probably just a matter of moving the tests over.

(having said that, I am wary of the risk of injecting usage of valgrind will cause a PR to be inadvertently blocked, and thus I still want to wait to fix this until after PR #21692 lands.)

@pnkfelix pnkfelix changed the title put copies of coerce_match{,_calls} and related tests into run-pass-valgrind move coerce_match{,_calls} and related tests into run-pass-valgrind Jan 30, 2015
@steveklabnik steveklabnik added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Feb 8, 2016
@steveklabnik
Copy link
Member

Triage: it looks like these two tests are not yet in src/test/run-pass-valgrind/. This should be easy to do, though which tests exactly are "related" isn't quite clear to me.

@brson
Copy link
Contributor

brson commented Jun 27, 2016

Triage: no news.

@pnkfelix pnkfelix self-assigned this Jun 28, 2016
tamird added a commit to tamird/rust that referenced this issue Jul 24, 2016
@tamird
move coerce-match{,-calls} into run-pass-valgrind
9aca38e 
Closes rust-lang#21696.
@tamird tamird mentioned this issue Jul 24, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Jul 28, 2016
@Manishearth
Rollup merge of rust-lang#35013 - tamird:coerce-match-valgrind, r=ale…
be6b73f 
…xcrichton

move coerce-match{,-calls} into run-pass-valgrind

Closes rust-lang#21696.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnkfelix pnkfelix

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @brson @pnkfelix