Skip to content

Commit 6366c1d

Browse files
LeSeulArtichautJoshua Nelson
authored andcommitted
Apply suggestions from code review
Co-authored-by: Joshua Nelson <[email protected]>
1 parent ee99dea commit 6366c1d

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/contributing.md

+5-4
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ to the end of the pull request description, and [@rust-highfive][rust-highfive]
9292

9393
In addition to being reviewed by a human, pull requests are automatically tested
9494
thanks to continuous integration (CI). Basically, every time you open and update
95-
a pull request, the CI builds the compiler and tests it against the
95+
a pull request, CI builds the compiler and tests it against the
9696
[compiler test suite][rctd], and also performs other tests such as checking that
9797
your pull request is in compliance with Rust's style guidelines.
9898

@@ -103,7 +103,8 @@ of the status of a particular pull request.
103103
Rust has plenty of CI capacity, and you should never have to worry about wasting
104104
computational resources each time you push a change. It is also perfectly fine
105105
(and even encouraged!) to use the CI to test your changes if it can help your
106-
productivity, e.g. if your machine is not very powerful.
106+
productivity. In particular, we don't recommend running the full `x.py test` suite locally,
107+
since it takes a very long time to execute.
107108

108109
After someone has reviewed your pull request, they will leave an annotation
109110
on the pull request with an `r+`. It will look something like this:
@@ -136,11 +137,11 @@ should be aware of.
136137

137138
All pull requests should be filed against the `master` branch, except in very
138139
particular scenarios. Unless you know for sure that you should target another
139-
branch, `master` will be the right choice.
140+
branch, `master` will be the right choice (it's also the default).
140141

141142
Make sure your pull request is in compliance with Rust's style guidelines by running
142143

143-
$ ./x.py test tidy
144+
$ ./x.py test tidy --bless
144145

145146
We recommand to make this check before every pull request (and every new commit
146147
in a pull request); you can add [git hooks](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks)

0 commit comments

Comments
 (0)