@@ -92,7 +92,7 @@ to the end of the pull request description, and [@rust-highfive][rust-highfive]
92
92
93
93
In addition to being reviewed by a human, pull requests are automatically tested
94
94
thanks to continuous integration (CI). Basically, every time you open and update
95
- a pull request, the CI builds the compiler and tests it against the
95
+ a pull request, CI builds the compiler and tests it against the
96
96
[ compiler test suite] [ rctd ] , and also performs other tests such as checking that
97
97
your pull request is in compliance with Rust's style guidelines.
98
98
@@ -103,7 +103,8 @@ of the status of a particular pull request.
103
103
Rust has plenty of CI capacity, and you should never have to worry about wasting
104
104
computational resources each time you push a change. It is also perfectly fine
105
105
(and even encouraged!) to use the CI to test your changes if it can help your
106
- productivity, e.g. if your machine is not very powerful.
106
+ productivity. In particular, we don't recommend running the full ` x.py test ` suite locally,
107
+ since it takes a very long time to execute.
107
108
108
109
After someone has reviewed your pull request, they will leave an annotation
109
110
on the pull request with an ` r+ ` . It will look something like this:
@@ -136,11 +137,11 @@ should be aware of.
136
137
137
138
All pull requests should be filed against the ` master ` branch, except in very
138
139
particular scenarios. Unless you know for sure that you should target another
139
- branch, ` master ` will be the right choice.
140
+ branch, ` master ` will be the right choice (it's also the default) .
140
141
141
142
Make sure your pull request is in compliance with Rust's style guidelines by running
142
143
143
- $ ./x.py test tidy
144
+ $ ./x.py test tidy --bless
144
145
145
146
We recommand to make this check before every pull request (and every new commit
146
147
in a pull request); you can add [ git hooks] ( https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks )
0 commit comments