Skip to content

Commit 52812e0

Browse files
rylevrylev
authored
Merge pull request #2013 from Kobzol/triage-2024-11-26
Triage 2024 11 26
2 parents 01467a4 + 556db98 commit 52812e0

File tree

1 file changed

+149
-0
lines changed

1 file changed

+149
-0
lines changed

‎triage/2024-11-26.md

+149
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,149 @@
1+
# 2024-11-26 Triage Log
2+
3+
This week saw more regressions than improvements, mostly due to three PRs that performed internal
4+
refactorings that are necessary for further development and modification of the compiler.
5+
6+
Triage done by **@kobzol**.
7+
Revision range: [7d40450b..7db7489f](https://perf.rust-lang.org/?start=7d40450b2df92bdc9dec414b30cf5f7a5979a92e&end=7db7489f9bc274cb60c4956bfa56de0185eb1b9b&absolute=false&stat=instructions%3Au)
8+
9+
**Summary**:
10+
11+
| (instructions:u) | mean | range | count |
12+
|:----------------------------------:|:-----:|:--------------:|:-----:|
13+
| Regressions ❌ <br /> (primary) | 0.6% | [0.1%, 3.6%] | 57 |
14+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.0%, 2.7%] | 100 |
15+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.5%, -0.2%] | 11 |
16+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.3%] | 7 |
17+
| All ❌✅ (primary) | 0.4% | [-1.5%, 3.6%] | 68 |
18+
19+
20+
4 Regressions, 2 Improvements, 3 Mixed; 3 of them in rollups
21+
40 artifact comparisons made in total
22+
23+
#### Regressions
24+
25+
Rollup of 8 pull requests [#133219](https://github.com/rust-lang/rust/pull/133219) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ee612c45f00391aff71ec0c52b7fc08fae18c711&end=875df370be806c837f58abb638329905e969ace4&stat=instructions:u)
26+
27+
| (instructions:u) | mean | range | count |
28+
|:----------------------------------:|:----:|:------------:|:-----:|
29+
| Regressions ❌ <br /> (primary) | 0.7% | [0.2%, 1.1%] | 6 |
30+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.3%, 1.2%] | 13 |
31+
| Improvements ✅ <br /> (primary) | - | - | 0 |
32+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
33+
| All ❌✅ (primary) | 0.7% | [0.2%, 1.1%] | 6 |
34+
35+
- The regressions were on the helloworld benchmark and other tiny crates, and they were reverted
36+
in a follow-up merge commit.
37+
- Marked as triaged.
38+
39+
continue `ParamEnv` to `TypingEnv` transition [#133212](https://github.com/rust-lang/rust/pull/133212) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bcfea1f8d253fd43eab36832fa601d192ac603d5&end=70e814bd9e532a302763f870c665c5af59c2b632&stat=instructions:u)
40+
41+
| (instructions:u) | mean | range | count |
42+
|:----------------------------------:|:----:|:------------:|:-----:|
43+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.5%] | 5 |
44+
| Regressions ❌ <br /> (secondary) | 2.1% | [0.1%, 6.6%] | 12 |
45+
| Improvements ✅ <br /> (primary) | - | - | 0 |
46+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
47+
| All ❌✅ (primary) | 0.4% | [0.3%, 0.5%] | 5 |
48+
49+
- Regressions caused by internal refactoring of the type system that is necessary for further
50+
improvements.
51+
- Asked the PR author about the perf. effect of this PR and also
52+
of [#133242](https://github.com/rust-lang/rust/pull/133242) (mentioned below).
53+
- Not marking as triaged.
54+
55+
Rollup of 5 pull requests [#133280](https://github.com/rust-lang/rust/pull/133280) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=318f96a8cf3eca5c4aaf60a992f349bce5c3fd41&end=0b1bf71a71c2a1d34c212285362530ec2c4e4775&stat=instructions:u)
56+
57+
| (instructions:u) | mean | range | count |
58+
|:----------------------------------:|:----:|:------------:|:-----:|
59+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 7 |
60+
| Regressions ❌ <br /> (secondary) | 2.0% | [2.0%, 2.0%] | 1 |
61+
| Improvements ✅ <br /> (primary) | - | - | 0 |
62+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
63+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 7 |
64+
65+
- The secondary regression is noise.
66+
- The primary regressions look to be genuine, but they are only on a single benchmark and they are
67+
very small, so I don't think that further investigation is needed.
68+
- Marked as triaged.
69+
70+
finish `Reveal` removal [#133242](https://github.com/rust-lang/rust/pull/133242) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=826b673412d2f579e7865b6f26bc9771c6d3b097&end=386a7c7ae22a3727c6a06633212d5a95edabdd74&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:----:|:------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | 0.7% | [0.2%, 3.6%] | 11 |
75+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 24 |
76+
| Improvements ✅ <br /> (primary) | - | - | 0 |
77+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
78+
| All ❌✅ (primary) | 0.7% | [0.2%, 3.6%] | 11 |
79+
80+
- Similar situation as in [#133212](https://github.com/rust-lang/rust/pull/133212).
81+
- Not marking as triaged.
82+
83+
#### Improvements
84+
85+
Resolve tweaks [#132761](https://github.com/rust-lang/rust/pull/132761) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=78993684f2ba22082197d63627f3e91069911839&end=ee612c45f00391aff71ec0c52b7fc08fae18c711&stat=instructions:u)
86+
87+
| (instructions:u) | mean | range | count |
88+
|:----------------------------------:|:-----:|:--------------:|:-----:|
89+
| Regressions ❌ <br /> (primary) | - | - | 0 |
90+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
91+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.6%, -0.1%] | 68 |
92+
| Improvements ✅ <br /> (secondary) | -1.1% | [-1.1%, -1.1%] | 1 |
93+
| All ❌✅ (primary) | -0.3% | [-0.6%, -0.1%] | 68 |
94+
95+
96+
Drop debug info instead of panicking if we exceed LLVM's capability to represent it [#133194](https://github.com/rust-lang/rust/pull/133194) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=875df370be806c837f58abb638329905e969ace4&end=bcfea1f8d253fd43eab36832fa601d192ac603d5&stat=instructions:u)
97+
98+
| (instructions:u) | mean | range | count |
99+
|:----------------------------------:|:-----:|:--------------:|:-----:|
100+
| Regressions ❌ <br /> (primary) | - | - | 0 |
101+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
102+
| Improvements ✅ <br /> (primary) | -1.1% | [-1.1%, -1.1%] | 2 |
103+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.7%, -0.4%] | 8 |
104+
| All ❌✅ (primary) | -1.1% | [-1.1%, -1.1%] | 2 |
105+
106+
107+
#### Mixed
108+
109+
Rollup of 5 pull requests [#133234](https://github.com/rust-lang/rust/pull/133234) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=70e814bd9e532a302763f870c665c5af59c2b632&end=fda68927475070696fcc9d1f5c9c990f0e1af87a&stat=instructions:u)
110+
111+
| (instructions:u) | mean | range | count |
112+
|:----------------------------------:|:-----:|:--------------:|:-----:|
113+
| Regressions ❌ <br /> (primary) | 2.2% | [0.2%, 5.5%] | 8 |
114+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.8%, 0.8%] | 1 |
115+
| Improvements ✅ <br /> (primary) | - | - | 0 |
116+
| Improvements ✅ <br /> (secondary) | -5.9% | [-5.9%, -5.9%] | 1 |
117+
| All ❌✅ (primary) | 2.2% | [0.2%, 5.5%] | 8 |
118+
119+
- The regression was caused by [#132732](https://github.com/rust-lang/rust/pull/132732).
120+
- Asked the PR author if there is a way to reduce the compilation performance cost.
121+
- Not marking as triaged.
122+
123+
Reduce false positives of tail-expr-drop-order from consumed values (attempt #2) [#131326](https://github.com/rust-lang/rust/pull/131326) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a1f299953656f95004c69b24ad8071d6899fa9da&end=3fee0f12e4f595948f8f54f57c8b7a7a58127124&stat=instructions:u)
124+
125+
| (instructions:u) | mean | range | count |
126+
|:----------------------------------:|:-----:|:--------------:|:-----:|
127+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
128+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 2.3%] | 15 |
129+
| Improvements ✅ <br /> (primary) | -0.7% | [-2.2%, -0.2%] | 19 |
130+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.0%, -0.3%] | 8 |
131+
| All ❌✅ (primary) | -0.7% | [-2.2%, 0.2%] | 20 |
132+
133+
- This was a win on primary benchmarks.
134+
- Marked as triaged.
135+
136+
#124141 preliminaries [#132629](https://github.com/rust-lang/rust/pull/132629) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0b1bf71a71c2a1d34c212285362530ec2c4e4775&end=717f5df2c308dfb4b7b8e6c002c11fe8269c4011&stat=instructions:u)
137+
138+
| (instructions:u) | mean | range | count |
139+
|:----------------------------------:|:-----:|:--------------:|:-----:|
140+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.3%] | 29 |
141+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 16 |
142+
| Improvements ✅ <br /> (primary) | - | - | 0 |
143+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.3%] | 5 |
144+
| All ❌✅ (primary) | 0.2% | [0.1%, 0.3%] | 29 |
145+
146+
- The regressions are caused by changes in the parser that are required for further cleanup and
147+
refactoring work.
148+
- The regressions are genuine, but tiny. The author has deemed them to be unavoidable.
149+
- Already marked as triaged by @nnethercote.

0 commit comments

Comments
 (0)