Skip to content

Commit b49053c

Browse files
lqdlqd
authored
Merge pull request #2048 from Mark-Simulacrum/triage
Add triage for 2025-03-03
2 parents d5da1ef + e5a2c77 commit b49053c

File tree

1 file changed

+96
-0
lines changed

1 file changed

+96
-0
lines changed

‎triage/2025-03-03.md

Lines changed: 96 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
1+
# 2025-03-03 Triage Log
2+
3+
A pretty quiet week, with minimal changes in performance (positive or negative).
4+
5+
Triage done by **@simulacrum**.
6+
Revision range: [f5729cfe..daf59857](https://perf.rust-lang.org/?start=f5729cfed3c45e061e8a443677fc1d5ef9277df7&end=daf59857d6d2b87af4b846316bf1561a6083ed51&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.6%] | 16 |
13+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.6%] | 27 |
14+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.1%, -0.2%] | 27 |
15+
| Improvements ✅ <br /> (secondary) | -1.0% | [-4.1%, -0.1%] | 63 |
16+
| All ❌✅ (primary) | -0.1% | [-1.1%, 0.6%] | 43 |
17+
18+
19+
1 Regressions, 4 Improvements, 1 Mixed; 2 of them in rollups
20+
29 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Remove `NtPat`, `NtMeta`, and `NtPath` [#137517](https://github.com/rust-lang/rust/pull/137517) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=287487624357c19b22d27aa3ed584b8ccd080b4d&end=aa3c2d73eff57d6b019c26a1e9aa8afd8bc186ad&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 16 |
29+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.6%] | 9 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 16 |
33+
34+
> The perf regressions are expected and unavoidable, alas.
35+
36+
https://github.com/rust-lang/rust/pull/137517#issuecomment-2692915586
37+
38+
#### Improvements
39+
40+
Change interners to start preallocated with an increased capacity [#137354](https://github.com/rust-lang/rust/pull/137354) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2af87eab3b4890d62ad998cf9c55e076d91bf06a&end=ac91805f3179fc2225c60e8ccf5a1daa09d43f3d&stat=instructions:u)
41+
42+
| (instructions:u) | mean | range | count |
43+
|:----------------------------------:|:-----:|:--------------:|:-----:|
44+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.4%] | 2 |
45+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 2 |
46+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.6%, -0.2%] | 39 |
47+
| Improvements ✅ <br /> (secondary) | -0.4% | [-1.1%, -0.1%] | 63 |
48+
| All ❌✅ (primary) | -0.3% | [-0.6%, 0.4%] | 41 |
49+
50+
51+
Rollup of 8 pull requests [#137710](https://github.com/rust-lang/rust/pull/137710) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e6059f522264ed2ec3ede21bfeef15bf3d814bf7&end=cb08599451226d780b2490f1aa9b414fe9e36657&stat=instructions:u)
52+
53+
| (instructions:u) | mean | range | count |
54+
|:----------------------------------:|:-----:|:--------------:|:-----:|
55+
| Regressions ❌ <br /> (primary) | - | - | 0 |
56+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
57+
| Improvements ✅ <br /> (primary) | - | - | 0 |
58+
| Improvements ✅ <br /> (secondary) | -2.0% | [-2.8%, -1.3%] | 9 |
59+
| All ❌✅ (primary) | - | - | 0 |
60+
61+
62+
`librustdoc`: return `impl fmt::Display` in more places instead of writing to strings [#137425](https://github.com/rust-lang/rust/pull/137425) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4b696e6bf77b4df02634d346637bd35f2960c5f4&end=7c4a55c2ac6497629c273ccd00e185583542f0d2&stat=instructions:u)
63+
64+
| (instructions:u) | mean | range | count |
65+
|:----------------------------------:|:-----:|:--------------:|:-----:|
66+
| Regressions ❌ <br /> (primary) | - | - | 0 |
67+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
68+
| Improvements ✅ <br /> (primary) | -0.6% | [-1.2%, -0.2%] | 4 |
69+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
70+
| All ❌✅ (primary) | -0.6% | [-1.2%, -0.2%] | 4 |
71+
72+
73+
Optimize empty provenance range checks. [#137704](https://github.com/rust-lang/rust/pull/137704) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f4a216d28ee635afce685b4206e713579f66e130&end=daf59857d6d2b87af4b846316bf1561a6083ed51&stat=instructions:u)
74+
75+
| (instructions:u) | mean | range | count |
76+
|:----------------------------------:|:-----:|:--------------:|:-----:|
77+
| Regressions ❌ <br /> (primary) | - | - | 0 |
78+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
79+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 3 |
80+
| Improvements ✅ <br /> (secondary) | -1.9% | [-3.4%, -0.2%] | 13 |
81+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.3%] | 3 |
82+
83+
84+
#### Mixed
85+
86+
Rollup of 10 pull requests [#137796](https://github.com/rust-lang/rust/pull/137796) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=aa3c2d73eff57d6b019c26a1e9aa8afd8bc186ad&end=30508faeb3248d399079513b6e0107af30a43948&stat=instructions:u)
87+
88+
| (instructions:u) | mean | range | count |
89+
|:----------------------------------:|:-----:|:--------------:|:-----:|
90+
| Regressions ❌ <br /> (primary) | 0.3% | [0.1%, 0.4%] | 9 |
91+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.5%] | 8 |
92+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.9%, -0.2%] | 2 |
93+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
94+
| All ❌✅ (primary) | 0.1% | [-0.9%, 0.4%] | 11 |
95+
96+
Hoping for recovery in subsequent PRs (see comment: https://github.com/rust-lang/rust/pull/137796#issuecomment-2693307115).

0 commit comments

Comments
 (0)