Skip to content

Commit c6e4f57

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent 0695b84 commit c6e4f57

File tree

1 file changed

+240
-0
lines changed

1 file changed

+240
-0
lines changed

‎triage/2024-11-19.md

Lines changed: 240 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,240 @@
1+
# 2024-11-19 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [d4822c2d..7d40450b](https://perf.rust-lang.org/?start=d4822c2d84c242cc7403118b50c571464f38ef8f&end=7d40450b2df92bdc9dec414b30cf5f7a5979a92e&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:---------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 1.1% | [0.2%, 7.3%] | 195 |
13+
| Regressions ❌ <br /> (secondary) | 1.3% | [0.1%, 5.0%] | 194 |
14+
| Improvements ✅ <br /> (primary) | -7.3% | [-24.9%, -0.3%] | 60 |
15+
| Improvements ✅ <br /> (secondary) | -9.4% | [-67.0%, -0.3%] | 23 |
16+
| All ❌✅ (primary) | -0.9% | [-24.9%, 7.3%] | 255 |
17+
18+
19+
2 Regressions, 4 Improvements, 10 Mixed; 6 of them in rollups
20+
47 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 5 pull requests [#133039](https://github.com/rust-lang/rust/pull/133039) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c82e0dff84f922274c3060f09b5ae78d5dbf5c49&end=90ab8eaedd3efd7919bffa7638db66e67df3f0b8&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 1 |
29+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 13 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.3% | [0.3%, 0.3%] | 1 |
33+
34+
35+
Rollup of 7 pull requests [#133120](https://github.com/rust-lang/rust/pull/133120) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ee4a56e353dc3ddfcb12df5fe2dc1329a315c2f5&end=1e0df74445a185fc97b7e806cd6c636eaded1326&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.3%] | 25 |
40+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.1%, 0.4%] | 14 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 0.2% | [0.1%, 0.3%] | 25 |
44+
45+
46+
#### Improvements
47+
48+
move all mono-time checks into their own folder, and their own query [#132843](https://github.com/rust-lang/rust/pull/132843) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5700240affd222f69b8755e2ff5d4ccaae9e6cf9&end=583b25d8d1bf934f593d9d9811f88305888032b5&stat=instructions:u)
49+
50+
| (instructions:u) | mean | range | count |
51+
|:----------------------------------:|:-----:|:--------------:|:-----:|
52+
| Regressions ❌ <br /> (primary) | - | - | 0 |
53+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
54+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 4 |
55+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.4%, -0.4%] | 1 |
56+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 4 |
57+
58+
59+
Rollup of 4 pull requests [#133047](https://github.com/rust-lang/rust/pull/133047) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=90ab8eaedd3efd7919bffa7638db66e67df3f0b8&end=e84902d35a4d3039c794e139eb12fba3624c5ff1&stat=instructions:u)
60+
61+
| (instructions:u) | mean | range | count |
62+
|:----------------------------------:|:-----:|:--------------:|:-----:|
63+
| Regressions ❌ <br /> (primary) | - | - | 0 |
64+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
65+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.4%, -0.0%] | 2 |
66+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.4%, -0.1%] | 4 |
67+
| All ❌✅ (primary) | -0.2% | [-0.4%, -0.0%] | 2 |
68+
69+
70+
Rollup of 5 pull requests [#133086](https://github.com/rust-lang/rust/pull/133086) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=917a50a03931a9861c19a46f3e2a02a28f1da936&end=d3a4b1f46ba0fff6239e3d75abd285287ccd17f9&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | - | - | 0 |
77+
| Improvements ✅ <br /> (secondary) | -4.2% | [-4.2%, -4.2%] | 1 |
78+
| All ❌✅ (primary) | - | - | 0 |
79+
80+
81+
Rollup of 5 pull requests [#133179](https://github.com/rust-lang/rust/pull/133179) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c602e9aeaab636302d52b17da64e84044462a230&end=03ee4845197ce71aa5ee28cb937a3e863b18b42f&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.2%, -0.1%] | 3 |
88+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.2%] | 2 |
89+
| All ❌✅ (primary) | -0.1% | [-0.2%, -0.1%] | 3 |
90+
91+
92+
#### Mixed
93+
94+
Rollup of 7 pull requests [#132919](https://github.com/rust-lang/rust/pull/132919) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=81eef2d362a6f03db6f8928f82d94298d31eb81b&end=67f21277cd40cd12e69aa34089f4a20926fd6dc5&stat=instructions:u)
95+
96+
| (instructions:u) | mean | range | count |
97+
|:----------------------------------:|:-----:|:--------------:|:-----:|
98+
| Regressions ❌ <br /> (primary) | 0.4% | [0.1%, 1.3%] | 6 |
99+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.1%, 0.2%] | 2 |
100+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.1%, -0.1%] | 1 |
101+
| Improvements ✅ <br /> (secondary) | -2.4% | [-2.4%, -2.4%] | 1 |
102+
| All ❌✅ (primary) | 0.3% | [-0.1%, 1.3%] | 7 |
103+
104+
105+
`#[inline]` integer parsing functions [#132870](https://github.com/rust-lang/rust/pull/132870) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f7273e0044ad8f35ad27282e4ab776af50b61a54&end=b420d923cff05f51eb43f607f5d8dce827eeba97&stat=instructions:u)
106+
107+
| (instructions:u) | mean | range | count |
108+
|:----------------------------------:|:-----:|:--------------:|:-----:|
109+
| Regressions ❌ <br /> (primary) | 0.9% | [0.1%, 5.1%] | 12 |
110+
| Regressions ❌ <br /> (secondary) | 1.0% | [0.4%, 2.3%] | 9 |
111+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.6%, -0.2%] | 3 |
112+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
113+
| All ❌✅ (primary) | 0.6% | [-0.6%, 5.1%] | 15 |
114+
115+
116+
[perf] rustdoc: Perform less work when cleaning middle::ty parenthesized generic args [#132886](https://github.com/rust-lang/rust/pull/132886) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=44f233f2519ce5d633c87c38014d03d8a5f0e810&end=ec239b888f3945a6ce043db639f1741d14f08874&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:-----:|:--------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | 1.0% | [1.0%, 1.0%] | 2 |
121+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 1 |
122+
| Improvements ✅ <br /> (primary) | - | - | 0 |
123+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.1%] | 5 |
124+
| All ❌✅ (primary) | 1.0% | [1.0%, 1.0%] | 2 |
125+
126+
127+
Reland #132772: use `download-rustc="if-unchanged"` as a global default [#132872](https://github.com/rust-lang/rust/pull/132872) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ec239b888f3945a6ce043db639f1741d14f08874&end=65b3877488ccfef3b1a903bfdd269559c59b957c&stat=instructions:u)
128+
129+
| (instructions:u) | mean | range | count |
130+
|:----------------------------------:|:-----:|:--------------:|:-----:|
131+
| Regressions ❌ <br /> (primary) | - | - | 0 |
132+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.3%] | 2 |
133+
| Improvements ✅ <br /> (primary) | -1.1% | [-1.1%, -1.0%] | 3 |
134+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.9%, -0.3%] | 6 |
135+
| All ❌✅ (primary) | -1.1% | [-1.1%, -1.0%] | 3 |
136+
137+
138+
tweak attributes for const panic macro [#132662](https://github.com/rust-lang/rust/pull/132662) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a00df61387e5389d6fe23e38e657f90d672668b1&end=8adb4b30f40e6fbd21dc1ba26c3301c7eeb6de3c&stat=instructions:u)
139+
140+
| (instructions:u) | mean | range | count |
141+
|:----------------------------------:|:-----:|:--------------:|:-----:|
142+
| Regressions ❌ <br /> (primary) | 0.7% | [0.5%, 0.9%] | 2 |
143+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
144+
| Improvements ✅ <br /> (primary) | -0.7% | [-2.0%, -0.2%] | 6 |
145+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
146+
| All ❌✅ (primary) | -0.3% | [-2.0%, 0.9%] | 8 |
147+
148+
149+
rustc_metadata: Preprocess search paths for better performance [#132910](https://github.com/rust-lang/rust/pull/132910) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f00f68245ebe85960000adaab18c1fe8da104cfe&end=76fd47124b8f8037b6187169b2cdf39139466952&stat=instructions:u)
150+
151+
| (instructions:u) | mean | range | count |
152+
|:----------------------------------:|:-----:|:--------------:|:-----:|
153+
| Regressions ❌ <br /> (primary) | 0.0% | [0.0%, 0.0%] | 1 |
154+
| Regressions ❌ <br /> (secondary) | 2.2% | [0.1%, 4.4%] | 2 |
155+
| Improvements ✅ <br /> (primary) | - | - | 0 |
156+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.2%] | 2 |
157+
| All ❌✅ (primary) | 0.0% | [0.0%, 0.0%] | 1 |
158+
159+
160+
Querify MonoItem collection [#132566](https://github.com/rust-lang/rust/pull/132566) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5afd5ad29c014de69bea61d028a1ce832ed75a75&end=ee4a56e353dc3ddfcb12df5fe2dc1329a315c2f5&stat=instructions:u)
161+
162+
| (instructions:u) | mean | range | count |
163+
|:----------------------------------:|:-----:|:---------------:|:-----:|
164+
| Regressions ❌ <br /> (primary) | 1.7% | [0.3%, 6.6%] | 10 |
165+
| Regressions ❌ <br /> (secondary) | 1.7% | [0.3%, 3.7%] | 23 |
166+
| Improvements ✅ <br /> (primary) | -6.3% | [-25.1%, -0.1%] | 73 |
167+
| Improvements ✅ <br /> (secondary) | -9.9% | [-67.2%, -0.3%] | 22 |
168+
| All ❌✅ (primary) | -5.4% | [-25.1%, 6.6%] | 83 |
169+
170+
171+
Likely unlikely fix [#120370](https://github.com/rust-lang/rust/pull/120370) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5ec7d6eee7e0f5236ec1559499070eaf836bc608&end=3fb7e441aecc3c054d71eb4d752d06e7776e8888&stat=instructions:u)
172+
173+
| (instructions:u) | mean | range | count |
174+
|:----------------------------------:|:-----:|:--------------:|:-----:|
175+
| Regressions ❌ <br /> (primary) | 0.9% | [0.1%, 2.8%] | 4 |
176+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.2%, 1.7%] | 18 |
177+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.9%, -0.1%] | 21 |
178+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.1%] | 11 |
179+
| All ❌✅ (primary) | -0.2% | [-1.9%, 2.8%] | 25 |
180+
181+
182+
Use `TypingMode` throughout the compiler instead of `ParamEnv` [#132460](https://github.com/rust-lang/rust/pull/132460) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=03ee4845197ce71aa5ee28cb937a3e863b18b42f&end=b71fb5edc0217eaf8fc824a44cd7b0945e29ff4d&stat=instructions:u)
183+
184+
| (instructions:u) | mean | range | count |
185+
|:----------------------------------:|:-----:|:--------------:|:-----:|
186+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.4%] | 8 |
187+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.2%, 2.7%] | 6 |
188+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
189+
| Improvements ✅ <br /> (secondary) | -0.8% | [-0.9%, -0.7%] | 5 |
190+
| All ❌✅ (primary) | 0.1% | [-0.3%, 0.4%] | 9 |
191+
192+
193+
Improve VecCache under parallel frontend [#124780](https://github.com/rust-lang/rust/pull/124780) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b71fb5edc0217eaf8fc824a44cd7b0945e29ff4d&end=5926e82dd1eae211c6e2ffe446de54df04798e89&stat=instructions:u)
194+
195+
| (instructions:u) | mean | range | count |
196+
|:----------------------------------:|:-----:|:--------------:|:-----:|
197+
| Regressions ❌ <br /> (primary) | 1.0% | [0.2%, 3.3%] | 214 |
198+
| Regressions ❌ <br /> (secondary) | 1.0% | [0.2%, 2.9%] | 172 |
199+
| Improvements ✅ <br /> (primary) | - | - | 0 |
200+
| Improvements ✅ <br /> (secondary) | -1.9% | [-3.0%, -0.4%] | 8 |
201+
| All ❌✅ (primary) | 1.0% | [0.2%, 3.3%] | 214 |
202+
203+
204+
#### Untriaged Pull Requests
205+
206+
- [#133120 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/133120)
207+
- [#132919 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/132919)
208+
- [#132870 `#[inline]` integer parsing functions](https://github.com/rust-lang/rust/pull/132870)
209+
- [#132831 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/132831)
210+
- [#132662 tweak attributes for const panic macro](https://github.com/rust-lang/rust/pull/132662)
211+
- [#132566 Querify MonoItem collection](https://github.com/rust-lang/rust/pull/132566)
212+
- [#132542 add const_panic macro to make it easier to fall back to non-formatting panic in const](https://github.com/rust-lang/rust/pull/132542)
213+
- [#132460 Use `TypingMode` throughout the compiler instead of `ParamEnv`](https://github.com/rust-lang/rust/pull/132460)
214+
- [#132326 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/132326)
215+
- [#132116 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/132116)
216+
- [#131984 Stabilize if_let_rescope](https://github.com/rust-lang/rust/pull/131984)
217+
- [#131721 Add new unstable feature `const_eq_ignore_ascii_case`](https://github.com/rust-lang/rust/pull/131721)
218+
- [#131263 Introduce SolverRelating type relation to the new solver](https://github.com/rust-lang/rust/pull/131263)
219+
- [#131111 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/131111)
220+
- [#130091 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/130091)
221+
- [#129831 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/129831)
222+
- [#129817 Rollup of 12 pull requests](https://github.com/rust-lang/rust/pull/129817)
223+
- [#129797 Try to reduce space usage in dist CI](https://github.com/rust-lang/rust/pull/129797)
224+
- [#129790 Bump to 1.83](https://github.com/rust-lang/rust/pull/129790)
225+
- [#129632 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/129632)
226+
- [#129063 Apply size optimizations to panic machinery and some cold functions](https://github.com/rust-lang/rust/pull/129063)
227+
- [#128936 Support reading thin archives in ArArchiveBuilder](https://github.com/rust-lang/rust/pull/128936)
228+
- [#128443 Properly mark loop as diverging if it has no breaks](https://github.com/rust-lang/rust/pull/128443)
229+
- [#128357 Detect non-lifetime binder params shadowing item params](https://github.com/rust-lang/rust/pull/128357)
230+
- [#128301 Rollup of 3 pull requests](https://github.com/rust-lang/rust/pull/128301)
231+
- [#128299 Simplify the canonical clone method and the copy-like forms to copy](https://github.com/rust-lang/rust/pull/128299)
232+
- [#128169 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/128169)
233+
- [#128155 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/128155)
234+
- [#128104 Not lint pub structs without pub constructors intentionally](https://github.com/rust-lang/rust/pull/128104)
235+
- [#127998 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/127998)
236+
237+
#### Nags requiring follow up
238+
239+
TODO: Nags
240+

0 commit comments

Comments
 (0)