Skip to content

Commit c9a45e1

Browse files
rylevrylev
authored
Merge pull request #1569 from Mark-Simulacrum/triage
Triage for this week
2 parents 8e33cfe + 0c34a7f commit c9a45e1

File tree

1 file changed

+116
-0
lines changed

1 file changed

+116
-0
lines changed

‎triage/2023-04-04.md

Lines changed: 116 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,116 @@
1+
# 2023-04-04 Triage Log
2+
3+
A large improvement in const evaluation (particularly for large types) in
4+
[#109670](https://github.com/rust-lang/rust/pull/109670) and a large
5+
improvement to many-paged rustdoc workloads in
6+
[#109876](https://github.com/rust-lang/rust/pull/109876) by removing quadratic
7+
behavior. Regressions are comparatively limited this week.
8+
9+
Triage done by **@simulacrum**.
10+
Revision range: [cbc064b341be231403d181402a786cce7f1c73f1..7c96e40da81165beef4f273f44e96eeef5a1bd30](https://perf.rust-lang.org/?start=cbc064b341be231403d181402a786cce7f1c73f1&end=7c96e40da81165beef4f273f44e96eeef5a1bd30&absolute=false&stat=instructions%3Au)
11+
12+
**Summary**:
13+
14+
| (instructions:u) | mean | range | count |
15+
|:----------------------------------:|:-----:|:---------------:|:-----:|
16+
| Regressions ❌ <br /> (primary) | 2.3% | [0.4%, 8.4%] | 18 |
17+
| Regressions ❌ <br /> (secondary) | 1.6% | [0.3%, 10.7%] | 26 |
18+
| Improvements ✅ <br /> (primary) | -2.5% | [-77.6%, -0.3%] | 63 |
19+
| Improvements ✅ <br /> (secondary) | -4.0% | [-27.9%, -0.3%] | 52 |
20+
| All ❌✅ (primary) | -1.4% | [-77.6%, 8.4%] | 81 |
21+
22+
23+
1 Regressions, 4 Improvements, 3 Mixed; 2 of them in rollups
24+
54 artifact comparisons made in total
25+
26+
#### Regressions
27+
28+
Insert alignment checks for pointer dereferences when debug assertions are enabled [#98112](https://github.com/rust-lang/rust/pull/98112) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ec7bb8da11f3e5cc73be397b78d2aea4157df300&end=22a7a19f9333bc1fcba97ce444a3515cb5fb33e6&stat=instructions:u)
29+
30+
| (instructions:u) | mean | range | count |
31+
|:----------------------------------:|:----:|:------------:|:-----:|
32+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.5%] | 3 |
33+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
34+
| Improvements ✅ <br /> (primary) | - | - | 0 |
35+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
36+
| All ❌✅ (primary) | 0.4% | [0.4%, 0.5%] | 3 |
37+
38+
#### Improvements
39+
40+
Rollup of 6 pull requests [#109714](https://github.com/rust-lang/rust/pull/109714) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=acd27bb5572553a4dc9a2d6f21d9a3a68ff8a233&end=40cd0310db7f67867b305c28fb87b5b660e77df1&stat=instructions:u)
41+
42+
| (instructions:u) | mean | range | count |
43+
|:----------------------------------:|:-----:|:--------------:|:-----:|
44+
| Regressions ❌ <br /> (primary) | - | - | 0 |
45+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
46+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.7%, -0.3%] | 5 |
47+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
48+
| All ❌✅ (primary) | -0.4% | [-0.7%, -0.3%] | 5 |
49+
50+
51+
Make init mask lazy for fully initialized/uninitialized const allocations [#109670](https://github.com/rust-lang/rust/pull/109670) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cf32b9de1e8f66526c36ad2927458558d2e81093&end=86792086646b61342c9417b78b8a535392f1045f&stat=instructions:u)
52+
53+
| (instructions:u) | mean | range | count |
54+
|:----------------------------------:|:-----:|:---------------:|:-----:|
55+
| Regressions ❌ <br /> (primary) | - | - | 0 |
56+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
57+
| Improvements ✅ <br /> (primary) | - | - | 0 |
58+
| Improvements ✅ <br /> (secondary) | -5.1% | [-27.7%, -1.4%] | 17 |
59+
| All ❌✅ (primary) | - | - | 0 |
60+
61+
62+
Update `ty::VariantDef` to use `IndexVec<FieldIdx, FieldDef>` [#109762](https://github.com/rust-lang/rust/pull/109762) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=276029deae08ad5b62f7d1ef2ea1acb7f5f529d8&end=eb3e9c1f45981b47160543cfd882ca00e69bbfab&stat=instructions:u)
63+
64+
| (instructions:u) | mean | range | count |
65+
|:----------------------------------:|:-----:|:--------------:|:-----:|
66+
| Regressions ❌ <br /> (primary) | - | - | 0 |
67+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
68+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.6%, -0.5%] | 3 |
69+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.3%] | 8 |
70+
| All ❌✅ (primary) | -0.5% | [-0.6%, -0.5%] | 3 |
71+
72+
73+
rustdoc: make intra-doc link pass non-quadratic for repeated links [#109876](https://github.com/rust-lang/rust/pull/109876) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cf7ada217c8ac63367b184afd9fffaff30f6ed44&end=eb48e9771a924080a2a7a87b403278e61f3061ea&stat=instructions:u)
74+
75+
| (instructions:u) | mean | range | count |
76+
|:----------------------------------:|:------:|:---------------:|:-----:|
77+
| Regressions ❌ <br /> (primary) | - | - | 0 |
78+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
79+
| Improvements ✅ <br /> (primary) | -11.8% | [-77.7%, -0.6%] | 8 |
80+
| Improvements ✅ <br /> (secondary) | -3.6% | [-3.6%, -3.6%] | 1 |
81+
| All ❌✅ (primary) | -11.8% | [-77.7%, -0.6%] | 8 |
82+
83+
84+
#### Mixed
85+
86+
Add a builtin `FnPtr` trait that is implemented for all function pointers [#108080](https://github.com/rust-lang/rust/pull/108080) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=60660371efe59dfc99644e9d709a1b71e25ae2ac&end=bf57e8ada6dc62369d1cee7ab055fb4074bd2d10&stat=instructions:u)
87+
88+
| (instructions:u) | mean | range | count |
89+
|:----------------------------------:|:-----:|:--------------:|:-----:|
90+
| Regressions ❌ <br /> (primary) | 3.2% | [1.1%, 5.5%] | 10 |
91+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.3%, 1.1%] | 5 |
92+
| Improvements ✅ <br /> (primary) | -1.8% | [-7.3%, -0.3%] | 17 |
93+
| Improvements ✅ <br /> (secondary) | -4.0% | [-7.5%, -0.4%] | 27 |
94+
| All ❌✅ (primary) | 0.1% | [-7.3%, 5.5%] | 27 |
95+
96+
97+
Rollup of 8 pull requests [#109692](https://github.com/rust-lang/rust/pull/109692) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bf57e8ada6dc62369d1cee7ab055fb4074bd2d10&end=478cbb42b730ba4739351b72ce2aa928e78e2f81&stat=instructions:u)
98+
99+
| (instructions:u) | mean | range | count |
100+
|:----------------------------------:|:-----:|:--------------:|:-----:|
101+
| Regressions ❌ <br /> (primary) | 0.9% | [0.2%, 9.2%] | 31 |
102+
| Regressions ❌ <br /> (secondary) | 1.7% | [0.2%, 10.9%] | 25 |
103+
| Improvements ✅ <br /> (primary) | - | - | 0 |
104+
| Improvements ✅ <br /> (secondary) | -1.1% | [-1.6%, -0.5%] | 5 |
105+
| All ❌✅ (primary) | 0.9% | [0.2%, 9.2%] | 31 |
106+
107+
108+
numeric vars can only be unified with numerical types in deep reject [#109750](https://github.com/rust-lang/rust/pull/109750) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c1d3610ac1ddd1cd605479274047fd0a3f37d220&end=276029deae08ad5b62f7d1ef2ea1acb7f5f529d8&stat=instructions:u)
109+
110+
| (instructions:u) | mean | range | count |
111+
|:----------------------------------:|:-----:|:--------------:|:-----:|
112+
| Regressions ❌ <br /> (primary) | 0.6% | [0.6%, 0.6%] | 3 |
113+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.5%] | 8 |
114+
| Improvements ✅ <br /> (primary) | -0.6% | [-1.8%, -0.2%] | 44 |
115+
| Improvements ✅ <br /> (secondary) | -0.8% | [-1.5%, -0.2%] | 3 |
116+
| All ❌✅ (primary) | -0.6% | [-1.8%, 0.6%] | 47 |

0 commit comments

Comments
 (0)