Skip to content

Commit d02c933

Browse files
Mark-SimulacrumMark-Simulacrum
committed
Add triage for this week
1 parent 5c87745 commit d02c933

File tree

1 file changed

+189
-0
lines changed

1 file changed

+189
-0
lines changed

‎triage/2024-01-08.md

Lines changed: 189 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,189 @@
1+
# 2024-01-08 Triage Log
2+
3+
Not a particularly notable week. Large swings aren't spurious but also are
4+
driven by changes in high-level behavior (diagnostics going from zero to one
5+
emission primarily), which causes a lot more work to happen. This isn't really
6+
representative of the underlying rustc performance changing though.
7+
8+
Triage done by **@simulacrum**.
9+
Revision range: [67b6975051b83ef2bd28f06e8467470d570aceb3..76101eecbe9aa80753664bbe637ad06d1925f315](https://perf.rust-lang.org/?start=67b6975051b83ef2bd28f06e8467470d570aceb3&end=76101eecbe9aa80753664bbe637ad06d1925f315&absolute=false&stat=instructions%3Au)
10+
11+
**Summary**:
12+
13+
| (instructions:u) | mean | range | count |
14+
|:----------------------------------:|:-----:|:--------------:|:-----:|
15+
| Regressions ❌ <br /> (primary) | 4.9% | [0.2%, 24.3%] | 14 |
16+
| Regressions ❌ <br /> (secondary) | 4.6% | [0.2%, 29.9%] | 55 |
17+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.5%, -0.2%] | 61 |
18+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.0%, -0.4%] | 14 |
19+
| All ❌✅ (primary) | 0.5% | [-1.5%, 24.3%] | 75 |
20+
21+
22+
4 Regressions, 4 Improvements, 6 Mixed; 1 of them in rollups
23+
24+
33 artifact comparisons made in total
25+
26+
#### Regressions
27+
28+
rustc_lint: Enforce `rustc::potential_query_instability` lint [#119251](https://github.com/rust-lang/rust/pull/119251) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=67b6975051b83ef2bd28f06e8467470d570aceb3&end=e51e98dde6a60637b6a71b8105245b629ac3fe77&stat=instructions:u)
29+
30+
| (instructions:u) | mean | range | count |
31+
|:----------------------------------:|:----:|:------------:|:-----:|
32+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.3%] | 2 |
33+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 8 |
34+
| Improvements ✅ <br /> (primary) | - | - | 0 |
35+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
36+
| All ❌✅ (primary) | 0.2% | [0.2%, 0.3%] | 2 |
37+
38+
Minor change in just a few benchmarks. Not clear whether this is noise or not
39+
but the overall change is required for correctness.
40+
41+
Merge `unused_tuple_struct_fields` into `dead_code` [#118297](https://github.com/rust-lang/rust/pull/118297) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a59a98024e3fe317e37e218392f5c34e932b2394&end=5113ed28ea1451a13eae3a05dca0dbabfd56f587&stat=instructions:u)
42+
43+
| (instructions:u) | mean | range | count |
44+
|:----------------------------------:|:----:|:-------------:|:-----:|
45+
| Regressions ❌ <br /> (primary) | 0.6% | [0.3%, 0.8%] | 7 |
46+
| Regressions ❌ <br /> (secondary) | 8.3% | [0.2%, 30.4%] | 28 |
47+
| Improvements ✅ <br /> (primary) | - | - | 0 |
48+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
49+
| All ❌✅ (primary) | 0.6% | [0.3%, 0.8%] | 7 |
50+
51+
Regressions are related to this lint firing in a few benchmarks, which causes a
52+
good deal of lazy loading to actually happen in diagnostics infra.
53+
54+
Exhaustiveness: Statically enforce revealing of opaques [#119329](https://github.com/rust-lang/rust/pull/119329) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=595bc6f00369475047538fdae1ff8cea692ac385&end=5bcd86d89b2b7b6a490f7e075dd4eb346deb5f98&stat=instructions:u)
55+
56+
| (instructions:u) | mean | range | count |
57+
|:----------------------------------:|:----:|:------------:|:-----:|
58+
| Regressions ❌ <br /> (primary) | - | - | 0 |
59+
| Regressions ❌ <br /> (secondary) | 1.9% | [1.7%, 2.0%] | 6 |
60+
| Improvements ✅ <br /> (primary) | - | - | 0 |
61+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
62+
| All ❌✅ (primary) | - | - | 0 |
63+
64+
Only a match-stress regression, seems like an acceptable change for the
65+
correctness fix.
66+
67+
Inline a few utility functions around MIR [#119459](https://github.com/rust-lang/rust/pull/119459) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5bcd86d89b2b7b6a490f7e075dd4eb346deb5f98&end=d62f05b842d94d3bcad4d41d4b81df3949bad7c6&stat=instructions:u)
68+
69+
| (instructions:u) | mean | range | count |
70+
|:----------------------------------:|:----:|:------------:|:-----:|
71+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.4%] | 3 |
72+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
73+
| Improvements ✅ <br /> (primary) | - | - | 0 |
74+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
75+
| All ❌✅ (primary) | 0.3% | [0.3%, 0.4%] | 3 |
76+
77+
Potentially just noise. Overall impact is limited to just one benchmark and
78+
only incr-full.
79+
80+
#### Improvements
81+
82+
Separate immediate and in-memory ScalarPair representation [#118991](https://github.com/rust-lang/rust/pull/118991) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6bc08a725f888a06ea3c6844f3d0cc2d2ebc5142&end=432fffa8afb8fcfe658e6548e5e8f10ad2001329&stat=instructions:u)
83+
84+
| (instructions:u) | mean | range | count |
85+
|:----------------------------------:|:-----:|:--------------:|:-----:|
86+
| Regressions ❌ <br /> (primary) | 0.6% | [0.6%, 0.6%] | 1 |
87+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
88+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.5%, -0.6%] | 13 |
89+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.2%] | 1 |
90+
| All ❌✅ (primary) | -0.9% | [-1.5%, 0.6%] | 14 |
91+
92+
93+
rustc_span: Optimize syntax context comparisons [#119531](https://github.com/rust-lang/rust/pull/119531) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=efb3f1108750ab68c855bafd8caffe5d078b6f75&end=9212108a9b32cc381995cf509dd2627123c11a25&stat=instructions:u)
94+
95+
| (instructions:u) | mean | range | count |
96+
|:----------------------------------:|:-----:|:--------------:|:-----:|
97+
| Regressions ❌ <br /> (primary) | - | - | 0 |
98+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
99+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.8%, -0.4%] | 5 |
100+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
101+
| All ❌✅ (primary) | -0.6% | [-0.8%, -0.4%] | 5 |
102+
103+
104+
Exhaustiveness: remove `Matrix.wildcard_row` [#119667](https://github.com/rust-lang/rust/pull/119667) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=87e1430893d55001034bd76c5dbe832d80bc50c3&end=d8b44d2802ab665b183dce06d527bf09175dd8cf&stat=instructions:u)
105+
106+
| (instructions:u) | mean | range | count |
107+
|:----------------------------------:|:-----:|:--------------:|:-----:|
108+
| Regressions ❌ <br /> (primary) | - | - | 0 |
109+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
110+
| Improvements ✅ <br /> (primary) | - | - | 0 |
111+
| Improvements ✅ <br /> (secondary) | -2.8% | [-3.0%, -2.6%] | 6 |
112+
| All ❌✅ (primary) | - | - | 0 |
113+
114+
115+
macro_rules: Add an expansion-local cache to span marker [#119693](https://github.com/rust-lang/rust/pull/119693) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=76101eecbe9aa80753664bbe637ad06d1925f315&end=0ee9cfd54db7b5f4be35f026588904500c866196&stat=instructions:u)
116+
117+
| (instructions:u) | mean | range | count |
118+
|:----------------------------------:|:-----:|:---------------:|:-----:|
119+
| Regressions ❌ <br /> (primary) | - | - | 0 |
120+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
121+
| Improvements ✅ <br /> (primary) | -1.4% | [-20.5%, -0.2%] | 80 |
122+
| Improvements ✅ <br /> (secondary) | -0.8% | [-1.9%, -0.3%] | 16 |
123+
| All ❌✅ (primary) | -1.4% | [-20.5%, -0.2%] | 80 |
124+
125+
Largest improvements here are recovery from a spurious regression in previous
126+
PR, but this is still a good win even aside from that.
127+
128+
#### Mixed
129+
130+
Reorder check_item_type diagnostics so they occur next to the corresponding `check_well_formed` diagnostics [#117213](https://github.com/rust-lang/rust/pull/117213) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f688dd684faca5b31b156fac2c6e0ae81fc9bc90&end=791a53f380d5cf800191f25941c94ace5099876e&stat=instructions:u)
131+
132+
| (instructions:u) | mean | range | count |
133+
|:----------------------------------:|:-----:|:--------------:|:-----:|
134+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.4%] | 7 |
135+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.2%, 2.3%] | 5 |
136+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 2 |
137+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
138+
| All ❌✅ (primary) | 0.1% | [-0.3%, 0.4%] | 9 |
139+
140+
141+
Stabilize THIR unsafeck [#117673](https://github.com/rust-lang/rust/pull/117673) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8d39ec1825024f3014e1f847942ac5bbfcf055b0&end=6bc08a725f888a06ea3c6844f3d0cc2d2ebc5142&stat=instructions:u)
142+
143+
| (instructions:u) | mean | range | count |
144+
|:----------------------------------:|:-----:|:--------------:|:-----:|
145+
| Regressions ❌ <br /> (primary) | - | - | 0 |
146+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 2 |
147+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.9%, -0.2%] | 39 |
148+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.1%, -0.4%] | 9 |
149+
| All ❌✅ (primary) | -0.4% | [-0.9%, -0.2%] | 39 |
150+
151+
Improvements outweigh regressions.
152+
153+
Replace a number of FxHashMaps/Sets with stable-iteration-order alternatives [#119192](https://github.com/rust-lang/rust/pull/119192) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=11035f9f52c65739d9613f5b9ecd332e9e640e71&end=b8c207435c85955d0c0806240d5491f5ccd1def5&stat=instructions:u)
154+
155+
| (instructions:u) | mean | range | count |
156+
|:----------------------------------:|:-----:|:--------------:|:-----:|
157+
| Regressions ❌ <br /> (primary) | - | - | 0 |
158+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.5%] | 7 |
159+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.6%, -0.2%] | 2 |
160+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
161+
| All ❌✅ (primary) | -0.4% | [-0.6%, -0.2%] | 2 |
162+
163+
Correctness fix, acceptable regressions.
164+
165+
Rollup of 9 pull requests [#119662](https://github.com/rust-lang/rust/pull/119662) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9212108a9b32cc381995cf509dd2627123c11a25&end=b6a8c762eed0ae0383658c38d65cb91bbd9800a1&stat=instructions:u)
166+
167+
| (instructions:u) | mean | range | count |
168+
|:----------------------------------:|:-----:|:--------------:|:-----:|
169+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
170+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.2%, 1.3%] | 13 |
171+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.2%] | 6 |
172+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
173+
| All ❌✅ (primary) | -0.3% | [-0.4%, 0.2%] | 7 |
174+
175+
tt-muncher is the primary significant regression, and appears to be
176+
significantly beyond the noise level for that benchmark. Investigation is
177+
ongoing.
178+
179+
mark vec::IntoIter pointers as `!nonnull` [#114205](https://github.com/rust-lang/rust/pull/114205) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6f4af9cbfc5ec176359c85446d1259a988299ea0&end=9522993b033e57579dcdee960d8792932aba791f&stat=instructions:u)
180+
181+
| (instructions:u) | mean | range | count |
182+
|:----------------------------------:|:-----:|:--------------:|:-----:|
183+
| Regressions ❌ <br /> (primary) | 0.7% | [0.6%, 0.8%] | 2 |
184+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
185+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
186+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
187+
| All ❌✅ (primary) | 0.4% | [-0.4%, 0.8%] | 3 |
188+
189+
Likely slightly more work for LLVM.

0 commit comments

Comments
 (0)