Skip to content

Commit fbae228

Browse files
committed
Add the significance threshold to the table
1 parent af2bdd3 commit fbae228

File tree

1 file changed

+17
-7
lines changed

1 file changed

+17
-7
lines changed

site/static/compare/script.js

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ const app = Vue.createApp({
134134
category: (benchmarkMap[c.benchmark] || {}).category || "secondary",
135135
isRelevant: c.is_relevant,
136136
significanceFactor: c.significance_factor,
137+
significanceThreshold: (c.significance_threshold * 100.0), // ensure the threshold is in %
137138
datumA,
138139
datumB,
139140
percent,
@@ -152,7 +153,7 @@ const app = Vue.createApp({
152153
bootstrapTotals() {
153154
const a = this.data.a.bootstrap_total / 1e9;
154155
const b = this.data.b.bootstrap_total / 1e9;
155-
return {a, b};
156+
return { a, b };
156157
},
157158
bootstraps() {
158159
return Object.entries(this.data.a.bootstrap).map(e => {
@@ -359,10 +360,16 @@ app.component('test-cases-table', {
359360
Significance Factor<span class="tooltip">?
360361
<span class="tooltiptext">
361362
How much a particular result is over the significance threshold. A factor of 2.50x
362-
means
363-
the result is 2.5 times over the significance threshold. You can see <a
364-
href="https://github.com/rust-lang/rustc-perf/blob/master/docs/comparison-analysis.md#what-makes-a-test-result-significant">
365-
here</a> how the significance threshold is calculated.
363+
means the result is 2.5 times over the significance threshold.
364+
</span>
365+
</span>
366+
</th>
367+
<th>
368+
Significance Threshold<span class="tooltip">?
369+
<span class="tooltiptext">
370+
The minimum % change that is considered significant. The higher the significance, the noisier a test case is.
371+
You can see <a href="https://github.com/rust-lang/rustc-perf/blob/master/docs/comparison-analysis.md#what-makes-a-test-result-significant">
372+
here</a> how the significance threshold is calculated.
366373
</span>
367374
</span>
368375
</th>
@@ -396,6 +403,9 @@ app.component('test-cases-table', {
396403
<td>
397404
{{ testCase.significanceFactor ? testCase.significanceFactor.toFixed(2) + "x" : "-" }}
398405
</td>
406+
<td>
407+
{{ testCase.significanceThreshold ? testCase.significanceThreshold.toFixed(2) + "%" : "-" }}
408+
</td>
399409
<td v-if="showRawData" class="numeric">
400410
<a v-bind:href="detailedQueryLink(commitA, testCase)">
401411
<abbr :title="testCase.datumA">{{ prettifyRawNumber(testCase.datumA) }}</abbr>
@@ -447,7 +457,7 @@ const SummaryRange = {
447457
[<SummaryPercentValue :value="range[0]" :padWidth="6" />, <SummaryPercentValue :value="range[1]" :padWidth="6" />]
448458
</div>
449459
<div v-else style="text-align: center;">-</div>
450-
`, components: {SummaryPercentValue}
460+
`, components: { SummaryPercentValue }
451461
};
452462
const SummaryCount = {
453463
props: {
@@ -510,7 +520,7 @@ app.component('summary-table', {
510520
</tbody>
511521
</table>
512522
`,
513-
components: {SummaryRange, SummaryPercentValue, SummaryCount}
523+
components: { SummaryRange, SummaryPercentValue, SummaryCount }
514524
});
515525

516526
app.component("aggregations", {

0 commit comments

Comments
 (0)