Skip to content

TRIAGE: Fetch PR titles when generating the weekly report #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ecstatic-morse opened this issue Sep 22, 2020 · 6 comments
Closed

TRIAGE: Fetch PR titles when generating the weekly report #767

ecstatic-morse opened this issue Sep 22, 2020 · 6 comments
Labels
design ready E-easy This issue should be relatively easy to complete help wanted We are looking for volunteers to take on this issue

Comments

@ecstatic-morse
Copy link
Contributor

ecstatic-morse commented Sep 22, 2020

We already have the PR number from rustc-perf, so all you need to do is call out to the GitHub API at the appropriate part of the triage report generator. It should be added after the first part of msg:

pr = res['b']['pr']
start = res['a']['commit']
end = res['b']['commit']
msg = f'[#{pr}]({gh_link(pr)})'

@ecstatic-morse
Copy link
Contributor Author

@rustbot modify labels to +help-wanted +good-first-issue

@rustbot
Copy link

rustbot commented Sep 22, 2020

Error: This repository is not enabled to use triagebot.
Add a triagebot.toml in the root of the master branch to enable it.

Please let @rust-lang/release know if you're having trouble with this bot.

@ecstatic-morse
Copy link
Contributor Author

@Mark-Simulacrum Not sure how often people look for issues in this repo, but I meant for this to be a contribution opportunity. Can you label it as such?

@Mark-Simulacrum Mark-Simulacrum added design ready E-easy This issue should be relatively easy to complete help wanted We are looking for volunteers to take on this issue labels Sep 22, 2020
@Mark-Simulacrum
Copy link
Member

Probably not very often, but labeled as such. I would be happy to add triagebot btw, just not something I've gotten around to. Feel free to send a PR if you'd like.

@Horki
Copy link
Contributor

Horki commented Dec 12, 2020

@Mark-Simulacrum #809 please review

@Horki
Copy link
Contributor

Horki commented Dec 12, 2020

@Mark-Simulacrum thanks for merging, this can be closed now right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design ready E-easy This issue should be relatively easy to complete help wanted We are looking for volunteers to take on this issue
Projects
None yet
Development

No branches or pull requests

4 participants