Skip to content

Commit 705ae4e

Browse files
committed
Use WIX environment variable
1 parent 35b8626 commit 705ae4e

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/rustup-win-installer/build.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
1+
use std::env;
2+
13
fn main() {
24
println!("cargo:rustc-link-lib=dylib=msi");
35
println!("cargo:rustc-link-lib=dylib=wcautil");
46
println!("cargo:rustc-link-lib=dylib=dutil");
57
println!("cargo:rustc-link-lib=dylib=user32");
68
println!("cargo:rustc-link-lib=dylib=mincore");
79

8-
// TODO: maybe don't hardcode path to WiX 3.10
9-
println!("cargo:rustc-link-search=native=C:\\Program Files (x86)\\WiX Toolset v3.10\\SDK\\VS2015\\lib\\x86");
10+
let wix_path = env::var("WIX").unwrap();
11+
// x86 target is hard-coded because we only build an x86 installer (works just fine on x64)
12+
println!("cargo:rustc-link-search=native={}SDK\\VS2015\\lib\\x86", wix_path);
1013
}

src/rustup-win-installer/msi/build.ps1

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ $env:CFG_VER_MINOR = $version[1]
55
$env:CFG_VER_PATCH = $version[2]
66

77
foreach($file in Get-ChildItem *.wxs) {
8-
&'C:\Program Files (x86)\WiX Toolset v3.10\bin\candle.exe' -nologo -arch x86 -ext WixUIExtension -ext WixUtilExtension -out "target\$($file.Name.Replace(".wxs",".wixobj"))" $($file.Name)
8+
$in = $file.Name
9+
$out = $($file.Name.Replace(".wxs",".wixobj"))
10+
&"$($env:WIX)bin\candle.exe" -nologo -arch x86 -ext WixUIExtension -ext WixUtilExtension -out "target\$out" $in
911
if ($LASTEXITCODE -ne 0) { exit }
1012
}
1113

1214
# ICE57 wrongly complains about per-machine data in per-user install, because it doesn't know that INSTALLLOCATION is in per-user directory
13-
&'C:\Program Files (x86)\WiX Toolset v3.10\bin\light.exe' -nologo -ext WixUIExtension -ext WixUtilExtension -out "target\rustup.msi" -sice:ICE57 $(Get-ChildItem target\*.wixobj)
15+
&"$($env:WIX)\bin\light.exe" -nologo -ext WixUIExtension -ext WixUtilExtension -out "target\rustup.msi" -sice:ICE57 $(Get-ChildItem target\*.wixobj)

0 commit comments

Comments
 (0)