build(windows/gnu): disable gc-sections to work around linker crash

Author: rami3l

build.rs

@@ -28,43 +28,52 @@ fn main() {
     let target = env::var("TARGET").unwrap();
     println!("cargo:rustc-env=TARGET={target}");
 
-    // Set linker options specific to Windows MSVC.
     let target_os = env::var("CARGO_CFG_TARGET_OS");
     let target_env = env::var("CARGO_CFG_TARGET_ENV");
-    if !(target_os.as_deref() == Ok("windows") && target_env.as_deref() == Ok("msvc")) {
-        return;
-    }
+    if target_os.as_deref() == Ok("windows") {
+        match target_env.as_deref() {
+            Ok("gnu") => {
+                // Disable `gc-sections` to work around linker crash.
+                //
+                // https://stackoverflow.com/a/45107167
+                // https://github.com/rust-lang/rustup/pull/3849#issuecomment-2142571761
+                println!("cargo:rustc-link-arg=-Wl,--no-gc-sections");
+            }
+            Ok("msvc") => {
+                // # Only search system32 for DLLs
+                //
+                // This applies to DLLs loaded at load time. However, this setting is ignored
+                // before Windows 10 RS1 (aka 1601).
+                // https://learn.microsoft.com/en-us/cpp/build/reference/dependentloadflag?view=msvc-170
+                println!("cargo:cargo:rustc-link-arg-bin=rustup-init=/DEPENDENTLOADFLAG:0x800");
 
-    // # Only search system32 for DLLs
-    //
-    // This applies to DLLs loaded at load time. However, this setting is ignored
-    // before Windows 10 RS1 (aka 1601).
-    // https://learn.microsoft.com/en-us/cpp/build/reference/dependentloadflag?view=msvc-170
-    println!("cargo:cargo:rustc-link-arg-bin=rustup-init=/DEPENDENTLOADFLAG:0x800");
+                // # Delay load
+                //
+                // Delay load dlls that are not "known DLLs"[1].
+                // Known DLLs are always loaded from the system directory whereas other DLLs
+                // are loaded from the application directory. By delay loading the latter
+                // we can ensure they are instead loaded from the system directory.
+                // [1]: https://learn.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-search-order#factors-that-affect-searching
+                //
+                // This will work on all supported Windows versions but it relies on
+                // us using `SetDefaultDllDirectories` before any libraries are loaded.
+                // See also: src/bin/rustup-init.rs
+                let delay_load_dlls = ["bcrypt", "powrprof", "secur32"];
+                for dll in delay_load_dlls {
+                    println!("cargo:rustc-link-arg-bin=rustup-init=/delayload:{dll}.dll");
+                }
+                // When using delayload, it's necessary to also link delayimp.lib
+                // https://learn.microsoft.com/en-us/cpp/build/reference/dependentloadflag?view=msvc-170
+                println!("cargo:rustc-link-arg-bin=rustup-init=delayimp.lib");
 
-    // # Delay load
-    //
-    // Delay load dlls that are not "known DLLs"[1].
-    // Known DLLs are always loaded from the system directory whereas other DLLs
-    // are loaded from the application directory. By delay loading the latter
-    // we can ensure they are instead loaded from the system directory.
-    // [1]: https://learn.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-search-order#factors-that-affect-searching
-    //
-    // This will work on all supported Windows versions but it relies on
-    // us using `SetDefaultDllDirectories` before any libraries are loaded.
-    // See also: src/bin/rustup-init.rs
-    let delay_load_dlls = ["bcrypt", "powrprof", "secur32"];
-    for dll in delay_load_dlls {
-        println!("cargo:rustc-link-arg-bin=rustup-init=/delayload:{dll}.dll");
+                // # Turn linker warnings into errors
+                //
+                // Rust hides linker warnings meaning mistakes may go unnoticed.
+                // Turning them into errors forces them to be displayed (and the build to fail).
+                // If we do want to ignore specific warnings then `/IGNORE:` should be used.
+                println!("cargo:cargo:rustc-link-arg-bin=rustup-init=/WX");
+            }
+            _ => {}
+        }
     }
-    // When using delayload, it's necessary to also link delayimp.lib
-    // https://learn.microsoft.com/en-us/cpp/build/reference/dependentloadflag?view=msvc-170
-    println!("cargo:rustc-link-arg-bin=rustup-init=delayimp.lib");
-
-    // # Turn linker warnings into errors
-    //
-    // Rust hides linker warnings meaning mistakes may go unnoticed.
-    // Turning them into errors forces them to be displayed (and the build to fail).
-    // If we do want to ignore specific warnings then `/IGNORE:` should be used.
-    println!("cargo:cargo:rustc-link-arg-bin=rustup-init=/WX");
 }