Skip to content

Commit d48ee4a

Browse files
committed
note why fallible-iterator is a dependency
`fallible-iterator` doesn't need to be a dependency, it is pulled in by `gimli/std` which can't be fixed without rust-lang/cargo#8832. Signed-off-by: David Wood <[email protected]>
1 parent 5f54f22 commit d48ee4a

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

thorin-bin/Cargo.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,18 @@ edition = "2021"
1111
thorin = { path = "../thorin" }
1212

1313
memmap2 = "0.5.0"
14-
object = { version = "0.27.1", features = [ "archive", "read", "write", "compression" ] }
1514
structopt = "0.3.25"
1615
thiserror = "1.0.30"
1716
tracing = "0.1.29"
1817
tracing-subscriber = { version = "0.2.25", features = [ "env-filter" ] }
1918
tracing-tree = "0.1.10"
2019
typed-arena = "2.0.1"
2120

21+
[dependencies.object]
22+
version = "0.27.1"
23+
default-features = false
24+
features = [ "archive", "read", "write", "compression" ]
25+
2226
[[bin]]
2327
name = "thorin"
2428
path = "src/main.rs"

thorin/Cargo.toml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,17 @@ version = "0.1.0"
88
edition = "2021"
99

1010
[dependencies]
11-
gimli = "0.26.1"
1211
indexmap = "1.7.0"
13-
object = { version = "0.27.1", features = [ "archive", "read", "write", "compression" ] }
1412
tracing = "0.1.29"
13+
14+
[dependencies.gimli]
15+
version = "0.26.1"
16+
default-features = false
17+
# `gimli/std` pulls in `fallible-iterator` which we don't use, but can't opt out of, because of
18+
# cargo#8832.
19+
features = [ "read", "write", "std" ]
20+
21+
[dependencies.object]
22+
version = "0.27.1"
23+
default-features = false
24+
features = [ "archive", "read", "write", "compression" ]

0 commit comments

Comments
 (0)