You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think it should be part of tidy, because it could have false positives. tidy is a hard error, I want this to be more like submodules where it says 'only do this if you're sure'.
The text was updated successfully, but these errors were encountered:
Currently, the norm is to add UI tests because by default they're useful and comprehensive, but this has led to many "should be a unit test" tests getting added as UI tests, slowing compile/test iteration massively. So, we should
Add the ability to respond to PR diffs.
Enable a simple rule to check against this, likely
Warn if a PR modifies onlylibrary/ and src/test.
This actually should bring false-positive rate to almost zero I think.
From rust-lang/highfive#286.
cc rust-lang/rust#76268
I don't think it should be part of tidy, because it could have false positives. tidy is a hard error, I want this to be more like submodules where it says 'only do this if you're sure'.
The text was updated successfully, but these errors were encountered: