Skip to content

feature request: warn if a PR modifies only src/test/ and library/ #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyn514 opened this issue Sep 15, 2020 · 2 comments
Open

feature request: warn if a PR modifies only src/test/ and library/ #831

jyn514 opened this issue Sep 15, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@jyn514
Copy link
Member

jyn514 commented Sep 15, 2020

From rust-lang/highfive#286.
cc rust-lang/rust#76268

I don't think it should be part of tidy, because it could have false positives. tidy is a hard error, I want this to be more like submodules where it says 'only do this if you're sure'.

@workingjubilee
Copy link
Member

workingjubilee commented Sep 15, 2020

-#[inline(details)]
+#[doc(inline)]

AFAIK, no checks on the diff of PRs exists in triagebot today so we'll probably need to add some logic for that.

Originally posted by @Mark-Simulacrum in rust-lang/highfive#286 (comment)

Currently, the norm is to add UI tests because by default they're useful and comprehensive, but this has led to many "should be a unit test" tests getting added as UI tests, slowing compile/test iteration massively. So, we should

  1. Add the ability to respond to PR diffs.
  2. Enable a simple rule to check against this, likely
  • Warn if a PR modifies only library/ and src/test.

This actually should bring false-positive rate to almost zero I think.

Originally posted by @matklad in rust-lang/highfive#286 (comment)

@jyn514
Copy link
Member Author

jyn514 commented Sep 15, 2020

I think you meant #[doc(inline)] ;)

@ehuss ehuss added the enhancement New feature or request label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants