Skip to content

Commit 0223a2d

Browse files
committed
Bumps the MSRV of blas testing crates to 1.67
This is unfortunately out of our control: users can select their blas implementations, and those implementations may not be MSRV 1.64, like ndarray itself. So we should add some documentation that makes this clear (or bump our MSRV). For now, we'll just add a gate in our test driver to handle this case
1 parent d575848 commit 0223a2d

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

crates/blas-tests/Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ version = "0.1.0"
44
authors = ["bluss"]
55
publish = false
66
edition = "2018"
7+
rust-version = "1.67"
78

89
[lib]
910
test = false

crates/numeric-tests/Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ version = "0.1.0"
44
authors = ["bluss"]
55
publish = false
66
edition = "2018"
7+
rust-version = "1.67"
78

89
[lib]
910
test = false

scripts/all-tests.sh

+4-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@ cargo test -v -p ndarray -p ndarray-rand --release --features "$FEATURES" $QC_FE
2121
# BLAS tests
2222
cargo test -p ndarray --lib -v --features blas
2323
cargo test -p blas-mock-tests -v
24-
cargo test -p blas-tests -v --features blas-tests/openblas-system
25-
cargo test -p numeric-tests -v --features numeric-tests/test_blas
24+
if [[ "$CHANNEL" != "1.64.0" ]]; then # Fix openblas-build requiring MSRV 1.67
25+
cargo test -p blas-tests -v --features blas-tests/openblas-system
26+
cargo test -p numeric-tests -v --features numeric-tests/test_blas
27+
fi
2628

2729
# Examples
2830
cargo test --examples

0 commit comments

Comments
 (0)