assert: Make use of asserts consistent

- Use debug asserts in code
- Use normal asserts in tests
- Use *assert_eq! methods when possible
- Remove unnecessary asserts

Author: josephlr

custom/stdweb/src/lib.rs

@@ -10,7 +10,6 @@
 #[cfg(not(all(target_arch = "wasm32", target_os = "unknown")))]
 compile_error!("This crate is only for the `wasm32-unknown-unknown` target");
 
-use core::mem;
 use std::sync::Once;
 
 use stdweb::js;
@@ -26,7 +25,6 @@ enum RngSource {
 register_custom_getrandom!(getrandom_inner);
 
 fn getrandom_inner(dest: &mut [u8]) -> Result<(), Error> {
-    assert_eq!(mem::size_of::<usize>(), 4);
     static ONCE: Once = Once::new();
     static mut RNG_SOURCE: Result<RngSource, Error> = Ok(RngSource::Node);
 

custom/wasm-bindgen/src/lib.rs

@@ -10,7 +10,6 @@
 compile_error!("This crate is only for the `wasm32-unknown-unknown` target");
 
 use core::cell::RefCell;
-use core::mem;
 use std::thread_local;
 
 use wasm_bindgen::prelude::*;
@@ -32,8 +31,6 @@ thread_local!(
 register_custom_getrandom!(getrandom_inner);
 
 fn getrandom_inner(dest: &mut [u8]) -> Result<(), Error> {
-    assert_eq!(mem::size_of::<usize>(), 4);
-
     RNG_SOURCE.with(|f| {
         let mut source = f.borrow_mut();
         if source.is_none() {

src/use_file.rs

@@ -99,7 +99,7 @@ fn wait_until_rng_ready() -> Result<(), Error> {
         // A negative timeout means an infinite timeout.
         let res = unsafe { libc::poll(&mut pfd, 1, -1) };
         if res >= 0 {
-            assert_eq!(res, 1); // We only used one fd, and cannot timeout.
+            debug_assert_eq!(res, 1); // We only used one fd, and cannot timeout.
             return Ok(());
         }
         let err = crate::util_libc::last_os_error();

src/util_libc.rs

@@ -108,7 +108,7 @@ cfg_if! {
 
 // SAFETY: path must be null terminated, FD must be manually closed.
 pub unsafe fn open_readonly(path: &str) -> Result<libc::c_int, Error> {
-    debug_assert!(path.as_bytes().last() == Some(&0));
+    debug_assert_eq!(path.as_bytes().last(), Some(&0));
     let fd = open(path.as_ptr() as *const _, libc::O_RDONLY | libc::O_CLOEXEC);
     if fd < 0 {
         return Err(last_os_error());