Logging errors: remove log_cause; output details via Debug

Author: dhardy

src/lib.rs

@@ -856,11 +856,9 @@ impl<R: SeedableRng> NewRng for R {
 
         trace!("Seeding new RNG");
         new_os().or_else(|e1| {
-            warn!("OsRng failed: {}; falling back to JitterRng", e1);
-            log_cause(&e1);
+            warn!("OsRng failed [falling back to JitterRng]: {:?}", e1);
             new_jitter().map_err(|e2| {
-                warn!("JitterRng failed: {}", e2);
-                log_cause(&e2);
+                warn!("JitterRng failed: {:?}", e2);
                 // TODO: can we somehow return both error sources?
                 Error::with_cause(
                     ErrorKind::Unavailable,
@@ -1093,14 +1091,6 @@ pub fn sample<T, I, R>(rng: &mut R, iterable: I, amount: usize) -> Vec<T>
         .unwrap_or_else(|e| e)
 }
 
-#[cfg(feature="std")]
-fn log_cause(mut e: &::std::error::Error) {
-    while let Some(cause) = e.cause() {
-        warn!("cause: {}", cause);
-        e = cause;
-    }
-}
-
 #[cfg(test)]
 mod test {
     use impls;

src/os.rs

@@ -17,7 +17,7 @@ use std::io::Read;
 #[allow(unused)] use std::path::Path;
 #[allow(unused)] use std::sync::{Once, Mutex, ONCE_INIT};
 
-use {Rng, Error, ErrorKind, impls, log_cause};
+use {Rng, Error, ErrorKind, impls};
 
 /// A random number generator that retrieves randomness straight from
 /// the operating system.
@@ -74,8 +74,7 @@ impl Rng for OsRng {
         loop {
             if let Err(e) = self.try_fill_bytes(dest) {
                 if log_err == 0 {
-                    warn!("OsRng failed: {}", e);
-                    log_cause(&e);
+                    warn!("OsRng failed: {:?}", e);
                 }
 
                 if e.kind().should_retry() {