Skip to content

Use the derive feature of serde in rand_core #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KodrAus opened this issue Apr 10, 2018 · 2 comments
Closed

Use the derive feature of serde in rand_core #387

KodrAus opened this issue Apr 10, 2018 · 2 comments

Comments

@KodrAus
Copy link

KodrAus commented Apr 10, 2018

I was just having a quick poke through rand_core for #386 and it looks like we could simplify current the serde + serde_derive feature. Instead of creating a new feature called serde1, we could just use the derive feature that serde provides. Was there any other rationale for serde1 besides letting us pull in serde_derive too in the same feature?

It would look something like:

[dependencies.serde]
features = ["derive"]
optional = true
@pitdicker
Copy link
Contributor

There was a little bit of discussion in #325 (comment). I don't care much for how we do it to be honest. It seems from the side of Serde there is a small preference to depend on both crates (the derive feature is not advertised well), and @dhardy had a preference for a name including a version number.

@KodrAus
Copy link
Author

KodrAus commented Apr 12, 2018

Ah I see, that makes sense 👍 I'll go ahead and close this

@KodrAus KodrAus closed this as completed Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants