You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was just having a quick poke through rand_core for #386 and it looks like we could simplify current the serde + serde_derive feature. Instead of creating a new feature called serde1, we could just use the derive feature that serde provides. Was there any other rationale for serde1 besides letting us pull in serde_derive too in the same feature?
It would look something like:
[dependencies.serde]
features = ["derive"]
optional = true
The text was updated successfully, but these errors were encountered:
There was a little bit of discussion in #325 (comment). I don't care much for how we do it to be honest. It seems from the side of Serde there is a small preference to depend on both crates (the derive feature is not advertised well), and @dhardy had a preference for a name including a version number.
I was just having a quick poke through
rand_core
for #386 and it looks like we could simplify current theserde
+serde_derive
feature. Instead of creating a new feature calledserde1
, we could just use thederive
feature thatserde
provides. Was there any other rationale forserde1
besides letting us pull inserde_derive
too in the same feature?It would look something like:
The text was updated successfully, but these errors were encountered: