Add coding guideline(s) for trait upcasting #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

PLeVasseur opened this issue Apr 3, 2025 · 0 comments

Labels

coding-guideline

Collaborator

PLeVasseur commented Apr 3, 2025

A really cool new feature in 1.86.0!

However, note this portion:

Note that this means that raw pointers to trait objects carry a non-trivial invariant: "leaking" a raw pointer to a trait object with an invalid vtable into safe code may lead to undefined behavior.

So it seems like a good idea to capture some coding guidelines around this.

PLeVasseur added the coding-guideline label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment