disable missing_const_for_fn lint globally

Author: hkratz

src/compat.rs

@@ -32,7 +32,6 @@ impl Utf8Error {
     /// ...
     #[inline]
     #[must_use]
-    #[allow(clippy::missing_const_for_fn)] // would not provide any benefit
     pub fn valid_up_to(&self) -> usize {
         self.valid_up_to
     }

src/implementation/aarch64/neon.rs

@@ -236,7 +236,6 @@ unsafe fn simd_prefetch(ptr: *const u8) {
 
 #[inline]
 #[cfg(not(feature = "aarch64_neon_prefetch"))]
-#[allow(clippy::missing_const_for_fn)]
 unsafe fn simd_prefetch(_ptr: *const u8) {}
 
 const PREFETCH: bool = false;

src/implementation/helpers.rs

@@ -38,7 +38,6 @@ pub(crate) fn get_compat_error(input: &[u8], failing_block_pos: usize) -> Utf8Er
 }
 
 #[allow(dead_code)]
-#[allow(clippy::missing_const_for_fn)] // clippy is wrong, it cannot really be const
 pub(crate) unsafe fn memcpy_unaligned_nonoverlapping_inline_opt_lt_64(
     mut src: *const u8,
     mut dest: *mut u8,

src/lib.rs

@@ -11,6 +11,7 @@
 #![allow(clippy::redundant_else)] // can make code more readable
 #![allow(clippy::explicit_iter_loop)] // can make code more readable
 #![allow(clippy::semicolon_if_nothing_returned)] // see https://github.com/rust-lang/rust-clippy/issues/7768
+#![allow(clippy::missing_const_for_fn)] // not necessary most of the times
 #![deny(missing_docs)]
 #![cfg_attr(not(feature = "std"), no_std)]
 #![cfg_attr(docsrs, feature(doc_cfg))]

tests/tests.rs

@@ -107,7 +107,6 @@ fn test_chunked_streaming_with_chunk_size<T: simdutf8::basic::imp::ChunkedUtf8Va
 }
 
 #[cfg(feature = "public_imp")]
-#[allow(clippy::missing_const_for_fn)]
 #[allow(unused_variables)]
 fn test_valid_public_imp(input: &[u8]) {
     if cfg!(any(target_arch = "x86", target_arch = "x86_64")) {
@@ -175,7 +174,6 @@ fn test_invalid(input: &[u8], valid_up_to: usize, error_len: Option<usize>) {
 }
 
 #[cfg(feature = "public_imp")]
-#[allow(clippy::missing_const_for_fn)]
 #[allow(unused_variables)]
 fn test_invalid_public_imp(input: &[u8], valid_up_to: usize, error_len: Option<usize>) {
     if cfg!(any(target_arch = "x86", target_arch = "x86_64")) {