From 226a6d6dad7b8dd1d5177cc41bb167dff342232e Mon Sep 17 00:00:00 2001 From: Yechan Bae Date: Sun, 28 Jun 2020 01:09:32 -0400 Subject: [PATCH 1/2] Security advisory for SergioBenitez/Rocket#1312 --- crates/rocket/RUSTSEC-0000-0000.toml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 crates/rocket/RUSTSEC-0000-0000.toml diff --git a/crates/rocket/RUSTSEC-0000-0000.toml b/crates/rocket/RUSTSEC-0000-0000.toml new file mode 100644 index 0000000000..9463feb272 --- /dev/null +++ b/crates/rocket/RUSTSEC-0000-0000.toml @@ -0,0 +1,20 @@ +[advisory] +id = "RUSTSEC-0000-0000" +package = "rocket" +date = "2020-05-27" +title = "`LocalRequest::clone` creates multiple mutable references to the same object" +url = "https://github.com/SergioBenitez/Rocket/issues/1312" +description = """ +The affected version of `rocket` contains a `Clone` trait implementation of +`LocalRequest` that reuses the pointer to inner `Request` object. +This causes data race in rare combinations of APIs if the original and the +cloned objects are modified at the same time. +""" + +[affected] +# TODO: confirm that this path is correct +functions = { "rocket::local::LocalRequest::Clone::clone" = ["< 0.4.5, >= 0.4.0"] } + +[versions] +patched = [">= 0.4.5"] +unaffected = ["< 0.4.0"] From f17f55472c93b0d85fdb5dd143b32e57afb74e01 Mon Sep 17 00:00:00 2001 From: Yechan Bae Date: Sat, 4 Jul 2020 01:53:33 -0400 Subject: [PATCH 2/2] Fix the function path and make the advisory informational --- crates/rocket/RUSTSEC-0000-0000.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/rocket/RUSTSEC-0000-0000.toml b/crates/rocket/RUSTSEC-0000-0000.toml index 9463feb272..ff33208027 100644 --- a/crates/rocket/RUSTSEC-0000-0000.toml +++ b/crates/rocket/RUSTSEC-0000-0000.toml @@ -2,6 +2,7 @@ id = "RUSTSEC-0000-0000" package = "rocket" date = "2020-05-27" +informational = "unsound" title = "`LocalRequest::clone` creates multiple mutable references to the same object" url = "https://github.com/SergioBenitez/Rocket/issues/1312" description = """ @@ -12,8 +13,7 @@ cloned objects are modified at the same time. """ [affected] -# TODO: confirm that this path is correct -functions = { "rocket::local::LocalRequest::Clone::clone" = ["< 0.4.5, >= 0.4.0"] } +functions = { "rocket::local::LocalRequest::clone" = ["< 0.4.5, >= 0.4.0"] } [versions] patched = [">= 0.4.5"]