Skip to content

CI Tests no longer succeeding since recent commit #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
egfx-notifications opened this issue Mar 4, 2022 · 2 comments
Closed

CI Tests no longer succeeding since recent commit #1118

egfx-notifications opened this issue Mar 4, 2022 · 2 comments

Comments

@egfx-notifications
Copy link
Contributor

egfx-notifications commented Mar 4, 2022 •
edited
Loading

🐛 Bug description

The recently merged commit af8eb33 broke the test build::build_different_profiles() in master. As a result all Pull Request pipelines triggered after this merge fail as well even if their changes pass the tests locally.

🤔 Expected Behavior

The tests should succeed as they did on the commit before af8eb33.

👟 Steps to reproduce

Check out af8eb33 or any commit after that and run the tests. Alternatively make a new Pull Request against master, tests will also fail.

🌍 Your environment

The environment is the project's own GitHub Actions CI.
@egfx-notifications egfx-notifications mentioned this issue Mar 4, 2022
Merged
3 tasks
@egfx-notifications
Copy link
Contributor Author

Root cause seems to be write_package_json() which does not work nicely with a package.json being processed twice by wasm-pack.

@egfx-notifications egfx-notifications mentioned this issue Mar 4, 2022
Merged
@egfx-notifications
Copy link
Contributor Author

Continueing discussion in #1110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egfx-notifications