Nginx fails to start because of log format

[Oicho]

Hi,

Using 17.8.4 and nginx fails to start.

2025-02-28 07:40:32,943 INFO success: cron entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2025-02-28 07:40:32,958 INFO exited: nginx (exit status 1; not expected)
2025-02-28 07:40:35,092 INFO spawned: 'nginx' with pid 2968
2025-02-28 07:40:35,109 INFO exited: nginx (exit status 1; not expected)
2025-02-28 07:40:38,118 INFO spawned: 'nginx' with pid 2969
2025-02-28 07:40:38,135 INFO exited: nginx (exit status 1; not expected)
2025-02-28 07:40:39,137 INFO gave up: nginx entered FATAL state, too many start retries too quickly

Looking at the nginx error logs

2025/02/28 07:39:17 [emerg] 2437#2437: unknown log format "gitlab_access" in /etc/nginx/conf.d/gitlab-registry.conf:14
2025/02/28 07:39:18 [emerg] 2609#2609: unknown log format "gitlab_access" in /etc/nginx/conf.d/gitlab-registry.conf:14
2025/02/28 07:39:20 [emerg] 2623#2623: unknown log format "gitlab_access" in /etc/nginx/conf.d/gitlab-registry.conf:14

The workaround was to remove the two access-log lines in the gitlab registry file

• https://github.com/sameersbn/docker-gitlab/blob/master/assets/runtime/config/nginx/gitlab-registry#L14
• https://github.com/sameersbn/docker-gitlab/blob/master/assets/runtime/config/nginx/gitlab-registry#L40

Btw if you want i'd gladly work on a fix for this.

[kkimurak]

#3064 (by me) introduced the bug and fixed by #3072 (by sachilles).
#3064 is merged before 17.9.0 so both 17.8.4 and 17.9.x contains it but #3072 only affects to 17.9.0.
It seems sachilles simply forgot the backport..

17.9.0 : https://github.com/sameersbn/docker-gitlab/releases/tag/17.9.0

Changelog

• [b9f8719] Fix nginx configuration (Steven Achilles)
• [2f38d3e] Upgrade GitLab CE to 17.9.0 (Steven Achilles)
• [928fc10] Remove default nginx conf after installation (Kazunori Kimura)
• [fc0012a] Change nginx log format name from main (Kazunori Kimura)
• [9dff930] Change path to install nginx configuration (Kazunori Kimura)
• [b59c075] Use official nginx repository (Kazunori Kimura)

17.8.4 : https://github.com/sameersbn/docker-gitlab/releases/tag/17.8.4

Changelog

• [4e08d92] Upgrade GitLab CE to 17.8.4 (Steven Achilles)
• [928fc10] Remove default nginx conf after installation (Kazunori Kimura)
• [fc0012a] Change nginx log format name from main (Kazunori Kimura)
• [9dff930] Change path to install nginx configuration (Kazunori Kimura)
• [b59c075] Use official nginx repository (Kazunori Kimura)

[sachilles]

@Oicho Thanks for pointing this out. In 17.8.5 the fix will be backported.

@kkimurak What do you think? Shall I provide an additional version, e.g. 17.8.4-1 to include the missing backport in version 17.8.4 as well?

[kkimurak]

@sachilles Thank you for your work. About releasing 17.8.4-1, I have no special opinion, but I think you probably don't need to do it. There will be no reason to prevent from updating to 17.8.5. If there's a request from people who need to stay on 17.8.4, we can revisit it then (personally I'd prefer people build or patch it themselves - it's open source).

[Oicho]

I can confirm it works on 17.8.5

I also think build 17.8.4-1 is useless..

Closing