Fix lint warnings (cloudevents#100)

* Fix clippy warnings

Signed-off-by: Francesco Guardiani <[email protected]>

* Cargo fmt

Signed-off-by: Francesco Guardiani <[email protected]>

Author: slinkydeveloper

cloudevents-sdk-actix-web/src/server_request.rs

@@ -65,7 +65,7 @@ impl<'a> BinaryDeserializer for HttpRequestDeserializer<'a> {
             )?
         }
 
-        if self.body.len() != 0 {
+        if !self.body.is_empty() {
             visitor.end_with_data(self.body.to_vec())
         } else {
             visitor.end()

cloudevents-sdk-rdkafka/src/headers.rs

@@ -24,6 +24,6 @@ lazy_static! {
         attributes_to_headers(SpecVersion::all_attribute_names());
 }
 
-pub(crate) static SPEC_VERSION_HEADER: &'static str = "ce_specversion";
-pub(crate) static CLOUDEVENTS_JSON_HEADER: &'static str = "application/cloudevents+json";
-pub(crate) static CONTENT_TYPE: &'static str = "content-type";
+pub(crate) static SPEC_VERSION_HEADER: &str = "ce_specversion";
+pub(crate) static CLOUDEVENTS_JSON_HEADER: &str = "application/cloudevents+json";
+pub(crate) static CONTENT_TYPE: &str = "content-type";

cloudevents-sdk-rdkafka/src/kafka_consumer_record.rs

@@ -33,7 +33,7 @@ impl ConsumerRecordDeserializer {
     pub fn new(message: &impl Message) -> Result<ConsumerRecordDeserializer> {
         Ok(ConsumerRecordDeserializer {
             headers: Self::get_kafka_headers(message)?,
-            payload: message.payload().map(|s| Vec::from(s)),
+            payload: message.payload().map(Vec::from),
         })
     }
 }

cloudevents-sdk-rdkafka/src/kafka_producer_record.rs

@@ -33,6 +33,12 @@ impl MessageRecord {
     }
 }
 
+impl Default for MessageRecord {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl BinarySerializer<MessageRecord> for MessageRecord {
     fn set_spec_version(mut self, spec_version: SpecVersion) -> Result<Self> {
         self.headers = self

cloudevents-sdk-reqwest/src/client_response.rs

@@ -64,7 +64,7 @@ impl BinaryDeserializer for ResponseDeserializer {
             )?
         }
 
-        if self.body.len() != 0 {
+        if !self.body.is_empty() {
             visitor.end_with_data(self.body.to_vec())
         } else {
             visitor.end()
@@ -84,6 +84,7 @@ impl StructuredDeserializer for ResponseDeserializer {
 impl MessageDeserializer for ResponseDeserializer {
     fn encoding(&self) -> Encoding {
         match (
+            #[allow(clippy::borrow_interior_mutable_const)]
             unwrap_optional_header!(self.headers, reqwest::header::CONTENT_TYPE)
                 .map(|r| r.ok())
                 .flatten()

src/event/attributes.rs

@@ -261,7 +261,7 @@ pub(crate) fn default_hostname() -> Url {
                 .ok()
                 .map(|s| s.into_string().ok())
                 .flatten()
-                .unwrap_or(String::from("localhost".to_string()))
+                .unwrap_or_else(|| "localhost".to_string())
         )
         .as_ref(),
     )

src/event/event.rs

@@ -53,8 +53,7 @@ macro_rules! parse_field {
 
 macro_rules! parse_data_json {
     ($in:ident, $error:ty) => {
-        Ok(serde_json::Value::deserialize($in.into_deserializer())
-            .map_err(|e| <$error>::custom(e))?)
+        serde_json::Value::deserialize($in.into_deserializer()).map_err(<$error>::custom)
     };
 }
 
@@ -73,7 +72,7 @@ macro_rules! parse_data_string {
 macro_rules! parse_json_data_base64 {
     ($in:ident, $error:ty) => {{
         let data = parse_data_base64!($in, $error)?;
-        serde_json::from_slice(&data).map_err(|e| <$error>::custom(e))
+        serde_json::from_slice(&data).map_err(<$error>::custom)
     }};
 }
 
@@ -113,7 +112,7 @@ pub(crate) trait EventFormatDeserializer {
             .into_iter()
             .map(|(k, v)| Ok((k, ExtensionValue::deserialize(v.into_deserializer())?)))
             .collect::<Result<HashMap<String, ExtensionValue>, serde_value::DeserializerError>>()
-            .map_err(|e| E::custom(e))?;
+            .map_err(E::custom)?;
 
         Ok(Event {
             attributes,