Merge pull request #453 from scala/backport-lts-3.3-23256

Backport "Dealias for unused param check" to 3.3 LTS

Author: tgodzik

compiler/src/dotty/tools/dotc/core/SymDenotations.scala

@@ -684,7 +684,7 @@ object SymDenotations {
       isAbstractOrAliasType && !isAbstractOrParamType
 
     /** Is this symbol an abstract or alias type? */
-    final def isAbstractOrAliasType: Boolean = isType & !isClass
+    final def isAbstractOrAliasType: Boolean = isType && !isClass
 
     /** Is this symbol an abstract type or type parameter? */
     final def isAbstractOrParamType(using Context): Boolean = this.isOneOf(DeferredOrTypeParam)

compiler/src/dotty/tools/dotc/transform/CheckUnused.scala

@@ -613,14 +613,14 @@ object CheckUnused:
         || m.hasAnnotation(dd.UnusedAnnot)          // param of unused method
         || sym.owner.name.isContextFunction         // a ubiquitous parameter
         || sym.isCanEqual
-        || sym.info.typeSymbol.match                // more ubiquity
+        || sym.info.dealias.typeSymbol.match        // more ubiquity
            case dd.DummyImplicitClass | dd.SubTypeClass | dd.SameTypeClass => true
            case tps =>
              tps.isMarkerTrait // no members to use; was only if sym.name.is(ContextBoundParamName)
              ||                // but consider NotGiven
              tps.hasAnnotation(dd.LanguageFeatureMetaAnnot)
         || sym.info.isSingleton // DSL friendly
-        || sym.info.isInstanceOf[RefinedType] // can't be expressed as a context bound
+        || sym.info.dealias.isInstanceOf[RefinedType] // can't be expressed as a context bound
       if ctx.settings.WunusedHas.implicits
         && !infos.skip(m)
         && !m.isEffectivelyOverride
@@ -943,7 +943,7 @@ object CheckUnused:
     def isCanEqual: Boolean =
       sym.isOneOf(GivenOrImplicit) && sym.info.finalResultType.baseClasses.exists(_.derivesFrom(defn.CanEqualClass))
     def isMarkerTrait: Boolean =
-      sym.isClass && sym.info.allMembers.forall: d =>
+      sym.info.hiBound.allMembers.forall: d =>
         val m = d.symbol
         !m.isTerm || m.isSelfSym || m.is(Method) && (m.owner == defn.AnyClass || m.owner == defn.ObjectClass)
     def isEffectivelyPrivate: Boolean =

tests/warn/i17314.scala

@@ -1,4 +1,4 @@
-//> using options -Wunused:all -deprecation -feature
+//> using options -Wunused:all -deprecation -feature -Werror
 
 import java.net.URI
 
@@ -10,7 +10,7 @@ object circelike {
   type Configuration
   trait ConfiguredCodec[T]
   object ConfiguredCodec:
-    inline final def derived[A](using conf: Configuration)(using inline mirror: Mirror.Of[A]): ConfiguredCodec[A] = // warn // warn
+    inline final def derived[A](using conf: Configuration)(using inline mirror: Mirror.Of[A]): ConfiguredCodec[A] =
       class InlinedConfiguredCodec extends ConfiguredCodec[A]:
         val codec = summonInline[Codec[URI]] // simplification
       new InlinedConfiguredCodec

tests/warn/i23250.scala

@@ -0,0 +1,17 @@
+//> using options -Wunused:all -Werror
+
+trait MonadError[F[_], E]
+type MonadThrow[F[_]] = MonadError[F, Throwable]
+
+trait MetaStreams[F[_]]:
+  def use[A]: F[A] = ???
+trait WriteResult
+
+trait MetaStreamsSyntax:
+  extension [F[_]](ms: MetaStreams[F])(using MonadThrow[F])
+    def setMaxAge(): F[WriteResult] =
+      summon[MonadThrow[F]]
+      ms.use[WriteResult]
+
+    def setTruncateBefore(): F[WriteResult] =
+      ms.use[WriteResult]

tests/warn/i23250b.scala

@@ -0,0 +1,18 @@
+//> using options -Wunused:all
+
+trait Memberly:
+  def member: Int
+
+object Members:
+  type MemberType <: Memberly
+  type Empty
+
+object Test:
+  import Members.*
+
+  type MT = MemberType
+  def membered(using MT) = println() // warn abstract type offers member in upper bound
+  def remembered(using mt: MT) = mt.member
+
+  type Ignore = Empty
+  def emptily(using Ignore) = println()