Skip to content

Commit 2a863af

Browse files
binjiCommit bot
binji
authored and
Commit bot
committed
Add messageerror event handler
This event is not currently wired up anywhere, but will be used in a subsequent CL. The idea is that when posting a message that cannot be decoded by the receiver, the receiver will dispatch a messageerror event instead of a message event. Spec changes: whatwg/html#2530 web platform tests: web-platform-tests/wpt#5567 Intent-to-implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Z_XzejHJTrs BUG=chromium:714842 Review-Url: https://codereview.chromium.org/2860483002 Cr-Commit-Position: refs/heads/master@{#471491}
1 parent 64b691c commit 2a863af

File tree

34 files changed

+126
-6
lines changed

34 files changed

+126
-6
lines changed

‎third_party/WebKit/LayoutTests/external/wpt/webmessaging/messageerror-expected.txt

Lines changed: 0 additions & 6 deletions
This file was deleted.

‎third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ PASS oldChildWindow.onloadedmetadata is newChildWindow.onloadedmetadata
109109
PASS oldChildWindow.onloadstart is newChildWindow.onloadstart
110110
PASS oldChildWindow.onlostpointercapture is newChildWindow.onlostpointercapture
111111
PASS oldChildWindow.onmessage is newChildWindow.onmessage
112+
PASS oldChildWindow.onmessageerror is newChildWindow.onmessageerror
112113
PASS oldChildWindow.onmousedown is newChildWindow.onmousedown
113114
PASS oldChildWindow.onmouseenter is newChildWindow.onmouseenter
114115
PASS oldChildWindow.onmouseleave is newChildWindow.onmouseleave

‎third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ PASS childWindow.onloadedmetadata is null
8181
PASS childWindow.onloadstart is null
8282
PASS childWindow.onlostpointercapture is null
8383
PASS childWindow.onmessage is null
84+
PASS childWindow.onmessageerror is null
8485
PASS childWindow.onmousedown is null
8586
PASS childWindow.onmouseenter is null
8687
PASS childWindow.onmouseleave is null

‎third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ PASS childWindow.onloadedmetadata is null
8181
PASS childWindow.onloadstart is null
8282
PASS childWindow.onlostpointercapture is null
8383
PASS childWindow.onmessage is null
84+
PASS childWindow.onmessageerror is null
8485
PASS childWindow.onmousedown is null
8586
PASS childWindow.onmouseenter is null
8687
PASS childWindow.onmouseleave is null

‎third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,12 @@ interface Blob
4242
interface BroadcastChannel : EventTarget
4343
getter name
4444
getter onmessage
45+
getter onmessageerror
4546
method close
4647
method constructor
4748
method postMessage
4849
setter onmessage
50+
setter onmessageerror
4951
interface BudgetService
5052
method constructor
5153
method getBudget
@@ -616,11 +618,13 @@ interface MessageEvent : Event
616618
method initMessageEvent
617619
interface MessagePort : EventTarget
618620
getter onmessage
621+
getter onmessageerror
619622
method close
620623
method constructor
621624
method postMessage
622625
method start
623626
setter onmessage
627+
setter onmessageerror
624628
interface NavigationPreloadManager
625629
method constructor
626630
method disable

‎third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ PASS oldChildWindow.onloadedmetadata is newChildWindow.onloadedmetadata
109109
PASS oldChildWindow.onloadstart is newChildWindow.onloadstart
110110
PASS oldChildWindow.onlostpointercapture is newChildWindow.onlostpointercapture
111111
PASS oldChildWindow.onmessage is newChildWindow.onmessage
112+
PASS oldChildWindow.onmessageerror is newChildWindow.onmessageerror
112113
PASS oldChildWindow.onmousedown is newChildWindow.onmousedown
113114
PASS oldChildWindow.onmouseenter is newChildWindow.onmouseenter
114115
PASS oldChildWindow.onmouseleave is newChildWindow.onmouseleave

‎third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,12 @@ interface Blob
66
interface BroadcastChannel : EventTarget
77
getter name
88
getter onmessage
9+
getter onmessageerror
910
method close
1011
method constructor
1112
method postMessage
1213
setter onmessage
14+
setter onmessageerror
1315
interface ByteLengthQueuingStrategy
1416
method constructor
1517
method size
@@ -390,11 +392,13 @@ interface MessageEvent : Event
390392
method initMessageEvent
391393
interface MessagePort : EventTarget
392394
getter onmessage
395+
getter onmessageerror
393396
method close
394397
method constructor
395398
method postMessage
396399
method start
397400
setter onmessage
401+
setter onmessageerror
398402
interface NavigationPreloadManager
399403
method constructor
400404
method disable

‎third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@ Starting worker: resources/global-interface-listing.js
1515
[Worker] attribute @@toStringTag
1616
[Worker] getter name
1717
[Worker] getter onmessage
18+
[Worker] getter onmessageerror
1819
[Worker] method close
1920
[Worker] method constructor
2021
[Worker] method postMessage
2122
[Worker] setter onmessage
23+
[Worker] setter onmessageerror
2224
[Worker] interface ByteLengthQueuingStrategy
2325
[Worker] method constructor
2426
[Worker] method size
@@ -416,11 +418,13 @@ Starting worker: resources/global-interface-listing.js
416418
[Worker] interface MessagePort : EventTarget
417419
[Worker] attribute @@toStringTag
418420
[Worker] getter onmessage
421+
[Worker] getter onmessageerror
419422
[Worker] method close
420423
[Worker] method constructor
421424
[Worker] method postMessage
422425
[Worker] method start
423426
[Worker] setter onmessage
427+
[Worker] setter onmessageerror
424428
[Worker] interface NavigationPreloadManager
425429
[Worker] attribute @@toStringTag
426430
[Worker] method constructor
@@ -762,6 +766,7 @@ Starting worker: resources/global-interface-listing.js
762766
[Worker] attribute console
763767
[Worker] attribute internals
764768
[Worker] getter onmessage
769+
[Worker] getter onmessageerror
765770
[Worker] method close
766771
[Worker] method gc
767772
[Worker] method postMessage
@@ -770,6 +775,7 @@ Starting worker: resources/global-interface-listing.js
770775
[Worker] method webkitResolveLocalFileSystemSyncURL
771776
[Worker] method webkitResolveLocalFileSystemURL
772777
[Worker] setter onmessage
778+
[Worker] setter onmessageerror
773779
PASS successfullyParsed is true
774780

775781
TEST COMPLETE

‎third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -331,10 +331,12 @@ interface BroadcastChannel : EventTarget
331331
attribute @@toStringTag
332332
getter name
333333
getter onmessage
334+
getter onmessageerror
334335
method close
335336
method constructor
336337
method postMessage
337338
setter onmessage
339+
setter onmessageerror
338340
interface ByteLengthQueuingStrategy
339341
method constructor
340342
method size
@@ -1555,6 +1557,7 @@ interface HTMLBodyElement : HTMLElement
15551557
getter onlanguagechange
15561558
getter onload
15571559
getter onmessage
1560+
getter onmessageerror
15581561
getter onoffline
15591562
getter ononline
15601563
getter onpagehide
@@ -1581,6 +1584,7 @@ interface HTMLBodyElement : HTMLElement
15811584
setter onlanguagechange
15821585
setter onload
15831586
setter onmessage
1587+
setter onmessageerror
15841588
setter onoffline
15851589
setter ononline
15861590
setter onpagehide
@@ -1993,6 +1997,7 @@ interface HTMLFrameSetElement : HTMLElement
19931997
getter onlanguagechange
19941998
getter onload
19951999
getter onmessage
2000+
getter onmessageerror
19962001
getter onoffline
19972002
getter ononline
19982003
getter onpagehide
@@ -2015,6 +2020,7 @@ interface HTMLFrameSetElement : HTMLElement
20152020
setter onlanguagechange
20162021
setter onload
20172022
setter onmessage
2023+
setter onmessageerror
20182024
setter onoffline
20192025
setter ononline
20202026
setter onpagehide
@@ -3494,11 +3500,13 @@ interface MessageEvent : Event
34943500
interface MessagePort : EventTarget
34953501
attribute @@toStringTag
34963502
getter onmessage
3503+
getter onmessageerror
34973504
method close
34983505
method constructor
34993506
method postMessage
35003507
method start
35013508
setter onmessage
3509+
setter onmessageerror
35023510
interface MimeType
35033511
attribute @@toStringTag
35043512
getter description
@@ -7708,6 +7716,7 @@ interface webkitURL
77087716
getter onloadstart
77097717
getter onlostpointercapture
77107718
getter onmessage
7719+
getter onmessageerror
77117720
getter onmousedown
77127721
getter onmouseenter
77137722
getter onmouseleave
@@ -7885,6 +7894,7 @@ interface webkitURL
78857894
setter onloadstart
78867895
setter onlostpointercapture
78877896
setter onmessage
7897+
setter onmessageerror
78887898
setter onmousedown
78897899
setter onmouseenter
78907900
setter onmouseleave

‎third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@ Starting worker: resources/global-interface-listing.js
1515
[Worker] attribute @@toStringTag
1616
[Worker] getter name
1717
[Worker] getter onmessage
18+
[Worker] getter onmessageerror
1819
[Worker] method close
1920
[Worker] method constructor
2021
[Worker] method postMessage
2122
[Worker] setter onmessage
23+
[Worker] setter onmessageerror
2224
[Worker] interface ByteLengthQueuingStrategy
2325
[Worker] method constructor
2426
[Worker] method size
@@ -411,11 +413,13 @@ Starting worker: resources/global-interface-listing.js
411413
[Worker] interface MessagePort : EventTarget
412414
[Worker] attribute @@toStringTag
413415
[Worker] getter onmessage
416+
[Worker] getter onmessageerror
414417
[Worker] method close
415418
[Worker] method constructor
416419
[Worker] method postMessage
417420
[Worker] method start
418421
[Worker] setter onmessage
422+
[Worker] setter onmessageerror
419423
[Worker] interface NavigationPreloadManager
420424
[Worker] attribute @@toStringTag
421425
[Worker] method constructor

‎third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,10 +260,12 @@ interface BroadcastChannel : EventTarget
260260
attribute @@toStringTag
261261
getter name
262262
getter onmessage
263+
getter onmessageerror
263264
method close
264265
method constructor
265266
method postMessage
266267
setter onmessage
268+
setter onmessageerror
267269
interface ByteLengthQueuingStrategy
268270
method constructor
269271
method size
@@ -1484,6 +1486,7 @@ interface HTMLBodyElement : HTMLElement
14841486
getter onlanguagechange
14851487
getter onload
14861488
getter onmessage
1489+
getter onmessageerror
14871490
getter onoffline
14881491
getter ononline
14891492
getter onpagehide
@@ -1510,6 +1513,7 @@ interface HTMLBodyElement : HTMLElement
15101513
setter onlanguagechange
15111514
setter onload
15121515
setter onmessage
1516+
setter onmessageerror
15131517
setter onoffline
15141518
setter ononline
15151519
setter onpagehide
@@ -1922,6 +1926,7 @@ interface HTMLFrameSetElement : HTMLElement
19221926
getter onlanguagechange
19231927
getter onload
19241928
getter onmessage
1929+
getter onmessageerror
19251930
getter onoffline
19261931
getter ononline
19271932
getter onpagehide
@@ -1944,6 +1949,7 @@ interface HTMLFrameSetElement : HTMLElement
19441949
setter onlanguagechange
19451950
setter onload
19461951
setter onmessage
1952+
setter onmessageerror
19471953
setter onoffline
19481954
setter ononline
19491955
setter onpagehide
@@ -3423,11 +3429,13 @@ interface MessageEvent : Event
34233429
interface MessagePort : EventTarget
34243430
attribute @@toStringTag
34253431
getter onmessage
3432+
getter onmessageerror
34263433
method close
34273434
method constructor
34283435
method postMessage
34293436
method start
34303437
setter onmessage
3438+
setter onmessageerror
34313439
interface MimeType
34323440
attribute @@toStringTag
34333441
getter description
@@ -7637,6 +7645,7 @@ interface webkitURL
76377645
getter onloadstart
76387646
getter onlostpointercapture
76397647
getter onmessage
7648+
getter onmessageerror
76407649
getter onmousedown
76417650
getter onmouseenter
76427651
getter onmouseleave
@@ -7814,6 +7823,7 @@ interface webkitURL
78147823
setter onloadstart
78157824
setter onlostpointercapture
78167825
setter onmessage
7826+
setter onmessageerror
78177827
setter onmousedown
78187828
setter onmouseenter
78197829
setter onmouseleave

‎third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,12 @@ interface Blob
4242
interface BroadcastChannel : EventTarget
4343
getter name
4444
getter onmessage
45+
getter onmessageerror
4546
method close
4647
method constructor
4748
method postMessage
4849
setter onmessage
50+
setter onmessageerror
4951
interface BudgetService
5052
method constructor
5153
method getBudget
@@ -615,11 +617,13 @@ interface MessageEvent : Event
615617
method initMessageEvent
616618
interface MessagePort : EventTarget
617619
getter onmessage
620+
getter onmessageerror
618621
method close
619622
method constructor
620623
method postMessage
621624
method start
622625
setter onmessage
626+
setter onmessageerror
623627
interface NetworkInformation : EventTarget
624628
getter downlinkMax
625629
getter onchange

‎third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,12 @@ Starting worker: resources/global-interface-listing.js
3939
[Worker] attribute @@toStringTag
4040
[Worker] getter name
4141
[Worker] getter onmessage
42+
[Worker] getter onmessageerror
4243
[Worker] method close
4344
[Worker] method constructor
4445
[Worker] method postMessage
4546
[Worker] setter onmessage
47+
[Worker] setter onmessageerror
4648
[Worker] interface BudgetService
4749
[Worker] attribute @@toStringTag
4850
[Worker] method constructor
@@ -638,11 +640,13 @@ Starting worker: resources/global-interface-listing.js
638640
[Worker] interface MessagePort : EventTarget
639641
[Worker] attribute @@toStringTag
640642
[Worker] getter onmessage
643+
[Worker] getter onmessageerror
641644
[Worker] method close
642645
[Worker] method constructor
643646
[Worker] method postMessage
644647
[Worker] method start
645648
[Worker] setter onmessage
649+
[Worker] setter onmessageerror
646650
[Worker] interface NetworkInformation : EventTarget
647651
[Worker] attribute @@toStringTag
648652
[Worker] getter downlinkMax
@@ -2324,6 +2328,7 @@ Starting worker: resources/global-interface-listing.js
23242328
[Worker] attribute console
23252329
[Worker] attribute internals
23262330
[Worker] getter onmessage
2331+
[Worker] getter onmessageerror
23272332
[Worker] method close
23282333
[Worker] method gc
23292334
[Worker] method postMessage
@@ -2332,6 +2337,7 @@ Starting worker: resources/global-interface-listing.js
23322337
[Worker] method webkitResolveLocalFileSystemSyncURL
23332338
[Worker] method webkitResolveLocalFileSystemURL
23342339
[Worker] setter onmessage
2340+
[Worker] setter onmessageerror
23352341
PASS successfullyParsed is true
23362342

23372343
TEST COMPLETE

0 commit comments

Comments
 (0)