Code health: port away from deprecated ListValue::GetString

This is a portion for /components/omnibox.
(And in some cases also adjust away from other deprecated Value APIs,
 when convenient/nearby)

This CL was uploaded by git cl split.

[email protected]

Bug: 1187090
Change-Id: Ib4ee847be8b545ecb2f185b280aa3b793f5ab94b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306900
Auto-Submit: Maksim Orlovich <[email protected]>
Reviewed-by: Orin Jaworski <[email protected]>
Commit-Queue: Maksim Orlovich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#946194}

Author: Maks Orlovich

components/omnibox/browser/search_suggestion_parser.cc

@@ -618,8 +618,12 @@ bool SearchSuggestionParser::ParseSuggestResults(
       }
     }
 
-    if (types && types->GetString(index, &type))
-      match_type = GetAutocompleteMatchType(type);
+    if (types && index < types->GetList().size() &&
+        types->GetList()[index].is_string()) {
+      match_type =
+          GetAutocompleteMatchType(types->GetList()[index].GetString());
+    }
+
     std::string deletion_url;
     if (suggestion_details) {
       const base::Value& suggestion_detail =