Remove Event.Latency.OS_NO_VALIDATION

According to https://crbug.com/1039833#c56 the investigation using this
metric is over.

R=bokan

Bug: 1039833
Change-Id: Iaae37cf2116656a339dbe159074ac955d7a359ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3526413
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Auto-Submit: Joe Mason <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#981543}

Author: JoeNotCharlesGoogle

content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm

@@ -972,8 +972,7 @@ - (void)keyEvent:(NSEvent*)theEvent wasKeyEquivalent:(BOOL)equiv {
   // Don't cancel child popups; the key events are probably what's triggering
   // the popup in the first place.
 
-  NativeWebKeyboardEvent event =
-      NativeWebKeyboardEvent::CreateForRenderer(theEvent);
+  NativeWebKeyboardEvent event(theEvent);
   ui::LatencyInfo latency_info;
   if (event.GetType() == blink::WebInputEvent::Type::kRawKeyDown ||
       event.GetType() == blink::WebInputEvent::Type::kChar) {

content/browser/renderer_host/input/web_input_event_builders_mac.h

@@ -19,15 +19,7 @@ namespace content {
 
 class CONTENT_EXPORT WebKeyboardEventBuilder {
  public:
-  // TODO(bokan): Temporarily added the |record_debug_uma| param to help debug
-  // https://crbug.com/1039833. This parameter controls whether
-  // Event.Latency.OS_NO_VALIDATION metrics are collected for the key event.
-  // The purpose is to limit this to only those events that are being handled
-  // synchronously from the OS message loop since we can reinject the same
-  // NSEvent back into the app multiple times; we want to record this stat only
-  // the first time the event was received.
-  static blink::WebKeyboardEvent Build(NSEvent* event,
-                                       bool record_debug_uma = false);
+  static blink::WebKeyboardEvent Build(NSEvent* event);
 };
 
 class CONTENT_EXPORT WebMouseEventBuilder {

content/browser/renderer_host/input/web_input_event_builders_mac.mm

@@ -254,20 +254,8 @@ bool IsSystemKeyEvent(const blink::WebKeyboardEvent& event) {
 
 }  // namespace
 
-blink::WebKeyboardEvent WebKeyboardEventBuilder::Build(NSEvent* event,
-                                                       bool record_debug_uma) {
+blink::WebKeyboardEvent WebKeyboardEventBuilder::Build(NSEvent* event) {
   ui::ComputeEventLatencyOS(event);
-  base::TimeTicks now = ui::EventTimeForNow();
-  base::TimeTicks hardware_timestamp =
-      ui::EventTimeStampFromSeconds([event timestamp]);
-  if (record_debug_uma) {
-    if (ui::EventTypeFromNative(event) == ui::ET_KEY_PRESSED) {
-      base::TimeDelta diff = (now - hardware_timestamp).magnitude();
-      UMA_HISTOGRAM_CUSTOM_TIMES(
-          "Event.Latency.OS_NO_VALIDATION.POSITIVE.KEY_PRESSED", diff,
-          base::Milliseconds(1), base::Seconds(60), 50);
-    }
-  }
 
   ui::DomCode dom_code = ui::DomCodeFromNSEvent(event);
   int modifiers =
@@ -327,15 +315,6 @@ bool IsSystemKeyEvent(const blink::WebKeyboardEvent& event) {
     blink::WebPointerProperties::PointerType pointerType,
     bool unacceleratedMovement) {
   ui::ComputeEventLatencyOS(event);
-  base::TimeTicks now = ui::EventTimeForNow();
-  base::TimeTicks hardware_timestamp =
-      ui::EventTimeStampFromSeconds([event timestamp]);
-  if (ui::EventTypeFromNative(event) == ui::ET_MOUSE_PRESSED) {
-    base::TimeDelta diff = (now - hardware_timestamp).magnitude();
-    UMA_HISTOGRAM_CUSTOM_TIMES(
-        "Event.Latency.OS_NO_VALIDATION.POSITIVE.MOUSE_PRESSED", diff,
-        base::Milliseconds(1), base::Seconds(60), 50);
-  }
   blink::WebInputEvent::Type event_type =
       blink::WebInputEvent::Type::kUndefined;
   int click_count = 0;
@@ -454,13 +433,6 @@ bool IsSystemKeyEvent(const blink::WebKeyboardEvent& event) {
     NSEvent* event,
     NSView* view) {
   ui::ComputeEventLatencyOS(event);
-  base::TimeTicks now = ui::EventTimeForNow();
-  base::TimeTicks hardware_timestamp =
-      ui::EventTimeStampFromSeconds([event timestamp]);
-  base::TimeDelta diff = (now - hardware_timestamp).magnitude();
-  UMA_HISTOGRAM_CUSTOM_TIMES(
-      "Event.Latency.OS_NO_VALIDATION.POSITIVE.MOUSE_WHEEL", diff,
-      base::Milliseconds(1), base::Seconds(60), 50);
   blink::WebMouseWheelEvent result(
       blink::WebInputEvent::Type::kMouseWheel, ModifiersFromEvent(event),
       ui::EventTimeStampFromSeconds([event timestamp]));
@@ -692,15 +664,6 @@ bool IsSystemKeyEvent(const blink::WebKeyboardEvent& event) {
 
   blink::WebTouchEvent result(event_type, ModifiersFromEvent(event),
                               ui::EventTimeStampFromSeconds([event timestamp]));
-  if (ui::EventTypeFromNative(event) == ui::ET_TOUCH_PRESSED) {
-    base::TimeTicks now = ui::EventTimeForNow();
-    base::TimeTicks hardware_timestamp =
-        ui::EventTimeStampFromSeconds([event timestamp]);
-    UMA_HISTOGRAM_CUSTOM_TIMES(
-        "Event.Latency.OS.NO_VALIDATION.POSITIVE.TOUCH_PRESSED",
-        (now - hardware_timestamp).magnitude(), base::Milliseconds(1),
-        base::Seconds(60), 50);
-  }
   ui::ComputeEventLatencyOS(event);
   result.hovering = event_type == blink::WebInputEvent::Type::kTouchEnd;
   result.unique_touch_event_id = ui::GetNextTouchEventId();

content/browser/renderer_host/native_web_keyboard_event_mac.mm

@@ -97,23 +97,8 @@ size_t WebKeyboardEventTextLength(const char16_t* text) {
   [os_event eventRef];
 }
 
-// static
-NativeWebKeyboardEvent NativeWebKeyboardEvent::CreateForRenderer(
-    gfx::NativeEvent native_event) {
-  return NativeWebKeyboardEvent(native_event, true);
-}
-
-NativeWebKeyboardEvent::NativeWebKeyboardEvent(gfx::NativeEvent native_event,
-                                               bool record_debug_uma)
-    : WebKeyboardEvent(
-          WebKeyboardEventBuilder::Build(native_event, record_debug_uma)),
-      os_event([native_event retain]),
-      skip_in_browser(false) {}
-
 NativeWebKeyboardEvent::NativeWebKeyboardEvent(gfx::NativeEvent native_event)
-    : WebKeyboardEvent(
-          WebKeyboardEventBuilder::Build(native_event,
-                                         /*record_debug_uma=*/false)),
+    : WebKeyboardEvent(WebKeyboardEventBuilder::Build(native_event)),
       os_event([native_event retain]),
       skip_in_browser(false) {}
 

content/public/browser/native_web_keyboard_event.h

@@ -54,17 +54,6 @@ struct CONTENT_EXPORT NativeWebKeyboardEvent : public blink::WebKeyboardEvent {
 #endif
 #endif
 
-#if BUILDFLAG(IS_MAC)
-  // TODO(bokan): Temporarily added to debug https://crbug.com/1039833. This is
-  // used to allow collecting Event.Latency.OS_NO_VALIDATION only in contexts
-  // where the key event will be sent to the renderer.  The purpose is to avoid
-  // recording it for reinjected events after the renderer has already
-  // processed the event.
-  static NativeWebKeyboardEvent CreateForRenderer(
-      gfx::NativeEvent native_event);
-  NativeWebKeyboardEvent(gfx::NativeEvent native_event, bool record_debug_uma);
-#endif
-
   NativeWebKeyboardEvent(const NativeWebKeyboardEvent& event);
   ~NativeWebKeyboardEvent() override;
 

tools/metrics/histograms/metadata/event/histograms.xml

@@ -396,20 +396,6 @@ [email protected].
   </summary>
 </histogram>
 
-<histogram name="Event.Latency.OS_NO_VALIDATION.POSITIVE" units="ms"
-    expires_after="2021-08-09">
-  <owner>[email protected]</owner>
-  <owner>[email protected]</owner>
-  <summary>
-    For Mac, a version of Event.Latency.OS that has the positive values it would
-    contain if ValidateEventTimeClock() were not called on the timestamps.
-
-    This metric is intended to debug http://crbug.com/1039833 where very high
-    numbers are seen for PageLoad.InputDelay3. The units of this metric are the
-    same as PageLoad.InputDelay3 for consistency while debugging.
-  </summary>
-</histogram>
-
 <histogram name="Event.Latency.Scroll.Wheel.TimeToHandled2"
     units="microseconds" expires_after="2021-12-19">
   <owner>[email protected]</owner>

tools/metrics/histograms/metadata/histogram_suffixes_list.xml

@@ -2740,8 +2740,6 @@ [email protected].
   <suffix name="TOUCH_RELEASED" label=""/>
   <affected-histogram name="Event.Latency.OS"/>
   <affected-histogram name="Event.Latency.OS2"/>
-  <affected-histogram name="Event.Latency.OS_NO_VALIDATION.NEGATIVE"/>
-  <affected-histogram name="Event.Latency.OS_NO_VALIDATION.POSITIVE"/>
 </histogram_suffixes>
 
 <histogram_suffixes name="ExtensionsDatabaseRestore" separator=".">