Skip to content

Commit 158f421

Browse files
committed
Version.toRelease() is rolled buck because scm4j-releaser can not be build on master
1 parent e6110ce commit 158f421

File tree

2 files changed

+23
-20
lines changed

2 files changed

+23
-20
lines changed

src/main/java/org/scm4j/commons/Version.java

+7-4
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,13 @@ public Version toSnapshot() {
152152
return new Version(toSnapshotString());
153153
}
154154

155+
public Version toRelease() {
156+
if (!isSemantic) {
157+
return this;
158+
}
159+
return new Version(prefix + minor + (patch.isEmpty() ? "" : "." + patch));
160+
}
161+
155162
public String toReleaseString() {
156163
return toRelease().toString();
157164
}
@@ -195,10 +202,6 @@ public String getReleaseNoPatchString() {
195202
return prefix + minor;
196203
}
197204

198-
public String toReleaseString() {
199-
return toRelease().toString();
200-
}
201-
202205
public Version setMinor(String minor) {
203206
if (!isSemantic) {
204207
throw new IllegalStateException("can not set minor for non-semantic version");

src/test/java/org/scm4j/commons/VersionTest.java

+16-16
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ public void testToString() {
3131

3232
@Test
3333
public void testToReleaseString() {
34-
assertEquals("11.21.31.0", new Version("11.21.31.41-SNAPSHOT").toReleaseString());
35-
assertEquals("11.21.31.0", new Version("11.21.31.41").toReleaseString());
36-
assertEquals("11.21.0", new Version("11.21.31").toReleaseString());
37-
assertEquals("11.0", new Version("11.21").toReleaseString());
38-
assertEquals("11", new Version("11-SNAPSHOT").toReleaseString());
39-
assertEquals("-SNAPSHOT", new Version("-SNAPSHOT").toReleaseString());
34+
assertEquals(new Version("11.21.31.41-SNAPSHOT").toReleaseString(), "11.21.31.41");
35+
assertEquals(new Version("11.21.31.41").toReleaseString(), "11.21.31.41");
36+
assertEquals(new Version("11.21.31").toReleaseString(), "11.21.31");
37+
assertEquals(new Version("11.21").toReleaseString(), "11.21");
38+
assertEquals(new Version("11-SNAPSHOT").toReleaseString(), "11");
39+
assertEquals(new Version("-SNAPSHOT").toReleaseString(), "-SNAPSHOT");
4040

4141
}
4242

@@ -50,12 +50,12 @@ public void testSnapshot() {
5050

5151
@Test
5252
public void testMinorBumping() {
53-
assertEquals("11.21.30.0", new Version("11.21.31.41").toPreviousMinor().toReleaseString());
54-
assertEquals("11.21.30.0", new Version("11.21.31.41-SNAPSHOT").toPreviousMinor().toReleaseString());
55-
assertEquals("11.21.32.0", new Version("11.21.31.41").toNextMinor().toReleaseString());
56-
assertEquals("11.21.32.0", new Version("11.21.31.41-SNAPSHOT").toNextMinor().toReleaseString());
57-
assertEquals("11.21.32.0", new Version("11.21.31.41").toNextMinor().toReleaseString());
58-
assertEquals("11.21.32.41-SNAPSHOT", new Version("11.21.31.41-SNAPSHOT").toNextMinor().toString());
53+
assertEquals(new Version("11.21.31.41").toPreviousMinor().toReleaseString(), "11.21.30.41");
54+
assertEquals(new Version("11.21.31.41-SNAPSHOT").toPreviousMinor().toReleaseString(), "11.21.30.41");
55+
assertEquals(new Version("11.21.31.41").toNextMinor().toReleaseString(), "11.21.32.41");
56+
assertEquals(new Version("11.21.31.41-SNAPSHOT").toNextMinor().toReleaseString(), "11.21.32.41");
57+
assertEquals(new Version("11.21.31.41").toNextMinor().toReleaseString(), "11.21.32.41");
58+
assertEquals(new Version("11.21.31.41-SNAPSHOT").toNextMinor().toString(), "11.21.32.41-SNAPSHOT");
5959
Version version = new Version("");
6060
try {
6161
version.toNextMinor();
@@ -151,10 +151,10 @@ public void testGetReleaseNoPatchString() {
151151

152152
@Test
153153
public void testToRelease() {
154-
assertEquals(new Version("11.21.31.0"), new Version("11.21.31.41-SNAPSHOT").toRelease());
155-
assertEquals(new Version("11.21.31.0"), new Version("11.21.31.41").toRelease());
156-
assertEquals(new Version("11.21.0"), new Version("11.21.31").toRelease());
157-
assertEquals(new Version("11.0"), new Version("11.21").toRelease());
154+
assertEquals(new Version("11.21.31.41"), new Version("11.21.31.41-SNAPSHOT").toRelease());
155+
assertEquals(new Version("11.21.31.41"), new Version("11.21.31.41").toRelease());
156+
assertEquals(new Version("11.21.31"), new Version("11.21.31").toRelease());
157+
assertEquals(new Version("11.21"), new Version("11.21").toRelease());
158158
assertEquals(new Version("11"), new Version("11-SNAPSHOT").toRelease());
159159
assertEquals(new Version("-SNAPSHOT"), new Version("-SNAPSHOT").toRelease());
160160
}

0 commit comments

Comments
 (0)