added validation messages

Author: scriptmonkey

app/controllers/ds18b20s_controller.rb

@@ -11,6 +11,11 @@ def create
       temp_sensor.save
       redirect_to home_path
     else
+      if temp_sensor.path.empty? or temp_sensor.file.empty?
+        flash[:error] = 'Something is missing' + temp_sensor.path
+      else
+        flash[:error]  = 'Path must have trailing /'
+      end
       redirect_to new_ds18b20_path
     end
   end
@@ -29,6 +34,11 @@ def update
     if temp_sensor.valid?
       redirect_to home_path
     else
+      if temp_sensor.path.empty? or temp_sensor.file.empty?
+        flash[:error] = 'Something is missing' + temp_sensor.path
+      else
+        flash[:error]  = 'Path must have trailing /'
+      end
       redirect_to edit_ds18b20_path(temp_sensor)
     end
   end

app/models/ds18b20.rb

@@ -4,6 +4,9 @@ class Ds18b20 < ApplicationRecord
     with: /\/\z/,
     message: 'Path must end with a /'
   }
+  validates :file, presence: true
+  validates :path, presence: true
+  validates :name, presence: true
 
   def creading
     if File.exist?(path + file)

app/views/pages/home.html.erb

@@ -1,12 +1,13 @@
 <h1>
   Sensor Manager
-  <p>
-  
-  <%= link_to I18n.t("views.home.link.ds18b20_create"), new_ds18b20_path%>
-  <p>
- 
-  <% @sensors = Ds18b20.all %>
-  <% @sensors.each do |s| %>
-    <%= link_to s.name, ds18b20_path(s) %>
-  <% end %>
 </h1>
+<p>
+
+<%= link_to I18n.t("views.home.link.ds18b20_create"), new_ds18b20_path%>
+<p>
+<h2> Sensors list:</h2>
+<% @sensors = Ds18b20.all %>
+<% @sensors.each do |s| %>
+  <%= link_to s.name, ds18b20_path(s) %>
+  <p>
+<% end %>

spec/features/using_ds18b20_spec.rb

@@ -3,22 +3,23 @@
 feature 'Visitor' do
   scenario 'creates a new DS18B20 sensor' do
     sensor = build(:ds18b20)
-    create_ds18b20(sensor)
+    create_ds18b20_via_form(sensor)
+    visit '/'
 
     expect(page).to have_link('sensor1')
   end
 
   scenario 'views the sensor reading' do
-    sensor = build(:ds18b20)
-    create_ds18b20(sensor)
+    sensor = create(:ds18b20)
+    visit '/'
     click_link('sensor1')
 
     expect(page).to have_content('156')
   end
 
-  scenario 'edits an existing ds10b20' do
-    sensor = build(:ds18b20)
-    create_ds18b20(sensor)
+  scenario 'edits an existing ds18b20' do
+    sensor = create(:ds18b20)
+    visit '/'
     click_link('sensor1')
     click_link('edit')
     fill_in 'ds18b20_name', with: 'sensor2'
@@ -35,36 +36,49 @@
     visit '/'
     click_link(sensor.name)
     click_link('edit')
-    fill_in 'ds18b20_name', with: 'sensor2'
     fill_in 'ds18b20_path', with: '/bad/path'
     click_button I18n.t('views.generic.buttons.save')
 
     expect(page).to have_current_path(edit_ds18b20_path(sensor))
-
+    expect(page).to have_content('Path must have trailing /')
   end
 
-  scenario 'provides a bad file and/or path' do
-    sensor = build(:ds18b20)
-    sensor.file='bad_file'
+  scenario 'edits and exsting ds18b20 and does not include path' do
+    sensor = create(:ds18b20)
+    visit '/'
+    click_link(sensor.name)
+    click_link('edit')
+    fill_in 'ds18b20_path', with: ''
+    click_button I18n.t('views.generic.buttons.save')
+
+    expect(page).to have_current_path(edit_ds18b20_path(sensor))
+    expect(page).to have_content('Something is missing')
+  end
 
-    create_ds18b20(sensor)
+  scenario 'provides a bad file' do
+    sensor = create(:ds18b20, file: 'bad_file')
+    visit '/'
     click_link('sensor1')
 
     expect(page).to have_content('-256')
   end
 
-  scenario 'does not provide a trailing / for the path' do
-    sensor = build(:ds18b20)
-    sensor.path.chop!
-    create_ds18b20(sensor)
-
-    expect(page).to have_current_path(new_ds18b20_path)
+  scenario 'provides no file' do
+    sensor = build(:ds18b20, file: nil)
+    create_ds18b20_via_form(sensor)
 
+    expect(page).to have_content('Something is missing')
   end
 
+  scenario 'provides no trailing / on path' do
+    sensor = build(:ds18b20, path: '/bad/path')
+    create_ds18b20_via_form(sensor)
+
+    expect(page).to have_content('Path must have trailing /')
+  end
   private
 
-  def create_ds18b20(sensor)
+  def create_ds18b20_via_form(sensor)
     visit '/'
     click_link I18n.t('views.home.link.ds18b20_create')
     fill_in 'ds18b20_name', with: sensor.name

spec/models/ds18b20_spec.rb

@@ -6,6 +6,9 @@
   it {should respond_to :file}
   it {should respond_to :creading }
   it {should respond_to :freading }
+  it {should validate_presence_of :file }
+  it {should validate_presence_of :path }
+  it {should validate_presence_of :name }
 
   context 'has a file to read' do
     it 'expects a temp reading from sensor1.txt' do