Skip to content
This repository was archived by the owner on Nov 12, 2022. It is now read-only.

Commit 94c4715

Browse files
author
bors-servo
authored
Auto merge of #421 - marmistrz:review-rm, r=cbrewster
Remove stray comments asking for review :) They were introduced by #393 and meant to be removed once the questions had been answered - but they ended up merged. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/421) <!-- Reviewable:end -->
2 parents 5b79f78 + 488a9c8 commit 94c4715

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/rust.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -425,8 +425,6 @@ impl<'a, T: 'a + RootKind + GCMethods> RootedGuard<'a, T> {
425425
}
426426
}
427427

428-
// REVIEW: is this equivalent to?
429-
// pub fn handle(&self) -> Handle<T>
430428
pub fn handle(&'a self) -> Handle<'a, T> {
431429
Handle::new(&self.root.ptr)
432430
}
@@ -629,7 +627,6 @@ impl<'a, T: 'a + CustomTrace> CustomAutoRooterGuard<'a, T> {
629627
}
630628
}
631629

632-
// REVIEW: as in line 429
633630
pub fn handle(&'a self) -> Handle<'a, T> where T: RootKind {
634631
Handle::new(&self.rooter.data)
635632
}

0 commit comments

Comments
 (0)