Skip to content

Commit 1c134c5

Browse files
authored
Merge pull request #52 from session-foundation/android-1241
Android 1.24.1 changes
2 parents 8e0b68e + 7ba5704 commit 1c134c5

7 files changed

+12
-4
lines changed

.github/workflows/android-regression.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@ on:
55
workflow_dispatch:
66
inputs:
77
APK_URL:
8-
description: 'url to test'
8+
description: 'apk url to test (.tar.xz)'
99
required: true
1010
type: string
11-
default: https://oxen.rocks/session-foundation/session-android/release/1.22.1/session-android-20250406T231441Z-a9bfe783a-universal.tar.xz
1211

1312
RISK:
1413
description: 'risks to target'

.github/workflows/ios-regression.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@ on:
55
workflow_dispatch:
66
inputs:
77
APK_URL:
8-
description: 'ipa url to test'
8+
description: 'ipa url to test (.tar.xz)'
99
required: true
1010
type: string
11-
default: https://oxen.rocks/session-foundation/session-ios/dev/session-ios-20250408T201952Z-233314350-sim.tar.xz
1211

1312
RISK:
1413
description: 'risks to target'

run/test/specs/linked_device_block_user.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ async function blockUserInConversationOptions(platform: SupportedPlatformsType)
6363
alice1.clickOnElementAll(new UserSettings(alice1)),
6464
alice2.clickOnElementAll(new UserSettings(alice2)),
6565
]);
66+
// 'Conversations' might be hidden beyond the Settings view, gotta scroll down to find it
67+
await Promise.all([alice1.scrollDown(), alice2.scrollDown()]);
6668
await Promise.all([
6769
alice1.clickOnElementAll({ strategy: 'accessibility id', selector: 'Conversations' }),
6870
alice2.clickOnElementAll({ strategy: 'accessibility id', selector: 'Conversations' }),

run/test/specs/message_requests_block.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ async function blockedRequest(platform: SupportedPlatformsType) {
7676
device2.clickOnElementAll(new UserSettings(device2)),
7777
device3.clickOnElementAll(new UserSettings(device3)),
7878
]);
79+
// 'Conversations' might be hidden beyond the Settings view, gotta scroll down to find it
80+
await Promise.all([device2.scrollDown(), device3.scrollDown()]);
7981
await Promise.all([
8082
device2.clickOnElementAll({ strategy: 'accessibility id', selector: 'Conversations' }),
8183
device3.clickOnElementAll({ strategy: 'accessibility id', selector: 'Conversations' }),

run/test/specs/user_actions_block_conversation_list.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ async function blockUserInConversationList(platform: SupportedPlatformsType) {
4444
});
4545
await alice1.navigateBack();
4646
await alice1.clickOnElementAll(new UserSettings(alice1));
47+
// 'Conversations' might be hidden beyond the Settings view, gotta scroll down to find it
48+
await alice1.scrollDown();
4749
await alice1.clickOnElementAll({ strategy: 'accessibility id', selector: 'Conversations' });
4850
await alice1.clickOnElementAll(new BlockedContactsSettings(alice1));
4951
await alice1.waitForTextElementToBePresent({

run/test/specs/user_actions_block_conversation_options.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ async function blockUserInConversationOptions(platform: SupportedPlatformsType)
5858
// Check settings for blocked user
5959
await alice1.navigateBack();
6060
await alice1.clickOnElementAll(new UserSettings(alice1));
61+
// 'Conversations' might be hidden beyond the Settings view, gotta scroll down to find it
62+
await alice1.scrollDown();
6163
await alice1.clickOnElementAll({ strategy: 'accessibility id', selector: 'Conversations' });
6264
await alice1.clickOnElementAll(new BlockedContactsSettings(alice1));
6365
// Accessibility ID for Blocked Contact not present on iOS

run/test/specs/voice_calls.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { open_Alice1_bob1_notfriends } from './state_builder';
55
import { sleepFor } from './utils/index';
66
import { SupportedPlatformsType, closeApp } from './utils/open_app';
77

8+
// skipping tests because they are unreliable on virtual devices, see QA-478
89
bothPlatformsItSeparate({
910
title: 'Voice calls',
1011
risk: 'high',
@@ -15,6 +16,7 @@ bothPlatformsItSeparate({
1516
},
1617
android: {
1718
testCb: voiceCallAndroid,
19+
shouldSkip: true,
1820
},
1921
});
2022

0 commit comments

Comments
 (0)